strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6209 commits 1 branch 0 tags 244 MiB
Commit graph

751 commits

Author SHA1 Message Date
Ashod Nakashian
b0fa4c33cd wsd: pass lambda args by value 
These callbacks are executed on a different thread
and passing by ref is clearly invalid (and unintentional).

Change-Id: I02e5359594f912baf67028202e6262d74b5769eb
Reviewed-on: https://gerrit.libreoffice.org/47624
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-09 04:13:31 +01:00
Ashod Nakashian
94781ec6d9 wsd: log at trace level until first child is forked 
Change-Id: I1b995b4714738f3bffd6dac58cf90ee6f1a32898
Reviewed-on: https://gerrit.libreoffice.org/47565
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-08 05:52:39 +01:00
Ashod Nakashian
040a211d60 wsd: set modified flag on the storage when set on the DocumentBroker 
Change-Id: Ieb4eb02f68f2d02ad88d6f59ad61de8f1e309670
Reviewed-on: https://gerrit.libreoffice.org/47365
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-06 22:14:23 +01:00
Ashod Nakashian
57d535b15b wsd: lambda cleanup and better readability 
Change-Id: Iabb850be7a7c162847514ee0fb600297accfcffb
Reviewed-on: https://gerrit.libreoffice.org/47364
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-06 22:13:50 +01:00
Ashod Nakashian
fb92fdb142 wsd: properly initialize members 
Change-Id: I4cf10b57ab37a88383e9d2cc6408427df9acfb38
Reviewed-on: https://gerrit.libreoffice.org/47363
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-06 22:12:42 +01:00
Ashod Nakashian
37593072eb wsd: log some config values for reference 
Change-Id: I5d3ea06de3253e5bfec3f9e6fed749f441f1a979
Reviewed-on: https://gerrit.libreoffice.org/47362
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-06 22:11:57 +01:00
Ashod Nakashian
d96cb94d02 wsd: set modified flag on the storage when set on the DocumentBroker 
Reviewed-on: https://gerrit.libreoffice.org/47367
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 752e3b7002f2199438aa81d5b660088da3faac44)

Change-Id: I13e25b2edff33d6fd9999dec5eb34d7847fbbd2e
Reviewed-on: https://gerrit.libreoffice.org/47400
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit e9ce36f26ea3f007e00efbf9012bbbe8f93ccc9d)
 2018-01-05 14:38:34 +01:00
Pranav Kant
9cbef14160 loplugin:nullptr 
Change-Id: I5f0dc970e8522b63570faa0ba05ab19dd0f45d5a
 2017-12-20 22:36:41 +05:30
Pranav Kant
f63858433b loplugin:includeform 
Change-Id: Ib62a7aa61062f00698aa3e8a144438de5c57e53d
 2017-12-20 21:21:05 +05:30
Pranav Kant
0d4bc145ba Explicit is better than implicit; avoid invalid mem access 
The form.get function is something like this:

const std::string& get(const std::string& abc) { return abc; }

passing a string literal implicitly gets converted to temporary
std::string whose reference is then returned and used. This causes
crash, atleast for me, on building online with GCC 7

Change-Id: I09d0aeea57a3dbeeefd1bb28ff645723714aa6b4
Reviewed-on: https://gerrit.libreoffice.org/46727
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 75c2147b7f774afccf55bb93f7fae79efb615361)
Reviewed-on: https://gerrit.libreoffice.org/46730
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2017-12-18 16:25:57 +01:00
Pranav Kant
53fc694a3c lokdialog: Use dialog close LOK API when user clicks 'X' 
Change-Id: I3a90eb8b83688eed7db8228763633e31f82e58d1
 2017-12-05 00:41:19 +05:30
Pranav Kant
849eb0d500 lokdialog: Adapt to LOK dialog API changes 
Change-Id: I653304e71573eb253e09a72bc87d54b8554ba7ff
 2017-12-04 22:13:50 +05:30
Marco Cecchetti
29a233e5a9 calc: set outline state 
use a specific message from the client for set the visibility state of
a group instead of hijacking the update row/column header message

Change-Id: I69d66b30db0b4d8a0082cbd2524120491d4f97cb
Reviewed-on: https://gerrit.libreoffice.org/45446
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
 2017-12-01 01:10:43 +01:00
Jan Holesovsky
5032529cb9 Don't crash when ssl.cipher_list is not present in loolwsd.xml. 
Change-Id: I3834550328ebd8627fc130c6ac2d0fccd2505311
Reviewed-on: https://gerrit.libreoffice.org/45525
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2017-11-29 20:07:40 +01:00
Pranav Kant
a19121bbbc Adapt to dialog API changes in LOK 
... and bypass some unncessary DocumentBroker handling of dialog
messages.

Change-Id: I378dff7a9786479baaa43f5fde9d30f35bc7f948
 2017-11-28 22:18:21 +05:30
Michael Meeks
92379ffbf2 Make the WSD SSL cipher list configurable. 
Change-Id: If79b9efc9438cf0a2345b8e81385adafef63ce22
 2017-11-22 15:55:03 +00:00
Michael Meeks
78398d4482 Move the Delta generator out into its own file. 
Change-Id: I7f7553c292970b1a52879b6d6c14e67172022310
 2017-11-22 15:55:03 +00:00
Tor Lillqvist
269ee2f0f5 Most distros should provide usable Poco packages by now surely 
Drop the mention of /opt/poco as the place where to put a self-built
Poco as that seems to make some people think /opt would be a
recommended place to do a clone of the LibreOffice repository, too.
Which is a weird place for it.

Change-Id: I17543a915a7f9ea4716379283b0a51723d39b376
 2017-11-20 18:32:07 +02:00
Jan Holesovsky
fc1680a253 Document UserExtraInfo. 
Change-Id: Ibf73b20c4ec7271579d203564fc8f4594eb6e73b
 2017-11-15 13:16:08 +01:00
Tor Lillqvist
0df65d2110 Bin accidental debugging printout leftover 
Change-Id: I06f21d3facc39fcbf35a3516bb48136f8660a10f
 2017-11-13 23:50:29 +02:00
Tor Lillqvist
7c77a6c3a3 Add handling of "prefilter" plug-ins 
When the name of a document to be edited ends with an extension
matching that mentioned in a prefilter plug-in's configuration file,
the command specified is run and it is the output file that is
actually edited.
 2017-11-13 16:27:53 +02:00
Tor Lillqvist
0831a94299 Add a "plug-in" mechanism 
Look in the directory LOOLWSD_CONFIGDIR/conf.d (or pathname passed
with --config-dir option) for extra .xml files containing a Poco
configuration tree. These are not merged with the actual configuration
but kept separate. This commit does not yet actually use them for
anything.
 2017-11-13 16:23:52 +02:00
Jan Holesovsky
61ce9c38e6 Save: Inform the user when saving has failed in LOK. 
Change-Id: Ie3bcdf9f6ca898b2763c31e6eb05c3a20be5859f
Reviewed-on: https://gerrit.libreoffice.org/44399
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2017-11-10 11:08:53 +01:00
Jan Holesovsky
b20faa8bdc Save As: Advertise the correct size when uploading the new file. 
Change-Id: I9b20c4bdb7ddc848437edceae1a77ddb49d55133
Reviewed-on: https://gerrit.libreoffice.org/44357
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2017-11-10 11:08:53 +01:00
Jan Holesovsky
513ffe36c1 Save As: UI for changing the document name. 
Change-Id: I23aba95ff0f8d867b021ba3cf0a6bc5eb4754f9d
Reviewed-on: https://gerrit.libreoffice.org/44282
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2017-11-10 11:08:53 +01:00
Miklos Vajna
8568f47667 wsd: fix -Werror,-Wunused-private-field 
Change-Id: I4522caa338d874628509f4382914b39406797da5
 2017-11-10 09:45:03 +01:00
Pranav Kant
768b0c0404 Bin some duplicate 404 handling 
Change-Id: Ibf3ed6c5558492b122662f25f31d321a6bbc151c
 2017-11-10 12:35:45 +05:30
Pranav Kant
f1d78c7e62 lokdialog: send invalidate rectangle in dialog command 
Change-Id: Iae00498a0ead1ee65dfce0332721e0d0fd2202fb
Reviewed-on: https://gerrit.libreoffice.org/44518
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2017-11-09 04:24:24 +01:00
Tor Lillqvist
4ab070ec38 Sort #include and using lines for consistency 
... but did not have the time or energy to do it in all files.

Change-Id: I92ea101cae1ad7be0fd2f31ce5a8d4b4149332c9
 2017-11-08 10:34:37 +02:00
Miklos Vajna
bb7ac21d44 Make sure that loop index type is never narrower than the length type 
Change-Id: I19aac80850c0371085ca6364412d5ac9207220d0
 2017-11-06 09:14:38 +01:00
Miklos Vajna
a3d6dee503 Remove unused strings 
Change-Id: I621c462bca38222dcf26dfa1e414cf27e1a3e088
 2017-11-03 15:25:09 +01:00
Tor Lillqvist
12aaff7d1a Bin some superfluous vertical whitespace 
Change-Id: I770342c34c87e38597d5eb3695c432af69273ce1
 2017-10-31 12:09:52 +02:00
Jan Holesovsky
bf1aa3326f Fix convert-to after the Save As work. 
Change-Id: I1871dd8331367798ee42b2ca35505847b43b639d
Reviewed-on: https://gerrit.libreoffice.org/43881
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2017-10-26 17:52:55 +02:00
Jan Holesovsky
343c5bc690 tdf#99744 SaveAs: Extend test to check that the Save As result was sent. 
Change-Id: I3788b87d2599c01000af97f496ee2b840c0cae3e
 2017-10-26 11:11:38 +02:00
Jan Holesovsky
6745464c70 tdf#99744 SaveAs: Report back to loleaflet that the saveas succeeded. 
Change-Id: I670c8b4503c1a4c0a88001a1343f6dec2974e044
 2017-10-26 11:11:38 +02:00
Jan Holesovsky
6fe4484395 tdf#99744 SaveAs: Use X-WOPI-SuggestedTarget instead of X-WOPI-RelativeTarget. 
And the correct encoding - UTF-7 (huh).

Change-Id: I6634fedb598c620128cc25a3e8fdc46e4096a756
 2017-10-26 11:11:38 +02:00
Jan Holesovsky
7ff432a370 tdf#99744 SaveAs: Reimplementation of the PutRelativeFile going through Kit. 
This is necessary so that changing of the file type works.

Includes a unit test.

Change-Id: Id01d44e555b6bac1002ff950de461fd330602f63
 2017-10-26 11:11:38 +02:00
Jan Holesovsky
f4198526ca tdf#99744 SaveAs: Reverts parts of the previous Save As work. 
It is necessary to go through the Kit when performing the Save As, so that we
can change the file type, sync with loading the file, etc.
 2017-10-26 11:11:38 +02:00
Pranav Kant
6e86fefc4e tdf#99744: Check if params exist before accessing them 
Change-Id: I5a36281f281b5d1fa4a8b7a3551ce1d49c2efaad
 2017-10-25 13:22:02 -07:00
Pranav Kant
e9e162b35e lokdialog: Mouse/key events, canvas use & child window impl. 
Change-Id: If8ae5c284e7166d4a01bd664644134f11197f988
 2017-10-25 00:39:03 -07:00
Pranav Kant
de780f8253 lokdialog: wsd: first cut at lok dialog rendering api 
Change-Id: Id522e0796428ed0a15ea3496e6726f51ed232e75
 2017-10-25 00:37:41 -07:00
Miklos Vajna
7ab856b196 common, wsd: clean up redundant casts 
Change-Id: Iad7e2417c6b1a154f6ad21839b841ca452e835c5
 2017-10-24 09:23:54 +02:00
Jan Holesovsky
557479e288 More information about the support key state. 
Change-Id: I0fb7792df3c0ba97497b7d9f5281640c40eb49a4
Reviewed-on: https://gerrit.libreoffice.org/43112
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2017-10-06 11:38:14 +02:00
Jan Holesovsky
783e3552c0 Support key logic in loolws + improvements in loolconfig. 
To be able to set the support key directly from the command line, and to show
the option, etc.

Change-Id: Iac93bc47a6f4b9d5a5ad0ac8b06bda978e01b760
Reviewed-on: https://gerrit.libreoffice.org/43098
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2017-10-06 11:37:18 +02:00
Jan Holesovsky
c0fcd071d7 rlimits: Let's default to 0 when there's nothing in the config file too. 
Change-Id: Ib99939a11d1e7cef112bf352b7c1dc6ac2d045c4
Reviewed-on: https://gerrit.libreoffice.org/43170
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 2d2398aa06c66d0a79178becf90b28fdcc20bdfd)
Reviewed-on: https://gerrit.libreoffice.org/43171
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2017-10-05 16:21:14 +02:00
Pranav Kant
6a73c19d16 Show save-as option based on CheckFileInfo params 
If UserCanNotWriteRelative is mentioned in the CheckFileInfo response.

Change-Id: I33d2e21159b3e18ae88fd72f404f2d1d1d9b64e5
 2017-10-03 20:58:36 +05:30
Jan Holesovsky
7f49b1eba6 PutFile ext: X-LOOL-WOPI-IsAutosave header to indicate autosave + unit test. 
Change-Id: I65ed711dae5100467fe6ed9902bd7bad8c7f8d68
Reviewed-on: https://gerrit.libreoffice.org/43074
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2017-10-03 12:04:18 +02:00
Pranav Kant
3008342c57 Don't kill the process when debugging 
Assume that when SLEEPFORDEBUGGER or SLEEPKITFORDEBUGGER is mentioned,
loolwsd is being debugged. In that case, don't set any timeout to exit
before first child is forked.

Change-Id: I2527f02187d8452ef6bebb70e1d750b5e796c4b6
 2017-10-03 13:47:39 +05:30
Jan Holesovsky
f658067eaa Don't crash when the parameters are missing. 
Change-Id: I96ace7ad7757e7e0c74dd9f361c78ecff6171a96
Reviewed-on: https://gerrit.libreoffice.org/42854
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2017-09-27 16:36:13 +02:00
Jan Holesovsky
5c604e9f78 PutFile ext: X-LOOL-WOPI-IsModifiedByUser header to indicate modifications. 
Change-Id: I5d69903211045969d678df695717eae7452e7f04
Reviewed-on: https://gerrit.libreoffice.org/42852
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2017-09-27 16:36:02 +02:00