The context menu items are obtained from core. Add a 'Delete'
entry to the context-menu json data just after 'Paste' only if
the selection is graphic and online is in Mobile mode.
Change-Id: Ie5810038bbca5d8ace01b236508b2dd4d31ca2a7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88510
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Single taping and double taping now enter
cell-edit mode and show the keyboard.
And improve graphic selection and adding text.
Change-Id: Ib38aac3165078cf143009d9ace530027bf630432
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88034
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
The patch :
-------------------------------------------------
commit ab64d2e0c3
Author: Dennis Francis <dennis.francis@collabora.com>
Date: Wed Jan 29 13:38:16 2020 +0530
Adjust column-header height with zoom-level too
--------------------------------------------------
introduced adjusting of column header height with zoom level.
But that messes up the positions of headers in the below scenario:
1. First zoom-in or out in mobile mode before enabling edit permissions
2. Then enable edit permissions, and now the header positions are all
messed up.
This happens because the formulabar ui is show only while in edit-mode
and the resize() method is not very robust(it adjusts 'top' style attribute
with height deltas) and does not consider the introduction of formula-bar
div into account when one changes the permission of the sheet from
'readonly' to 'edit' in mobile mode.
So lets not do resize() of the column-header container before entering
edit mode and avoid complications of adjusting for the introduction of
the formula-bar.
Change-Id: Ib03f89ad7a34cbd2a3cbfb65af2a9a016b47c125
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88175
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
This makes the on-screen keyboard behaviour more consistent between
phones and tablets.
One effect is that it now requires a double-tap on a cell in a
spreadsheet document also in the iOS app on iPad to get the on-screen
keyboard.
Change-Id: I0dee87b76a1781d6acde1270322a207958cba045
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88178
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
added momentum to scrolling making scolling feel smoother and easier
Change-Id: If760761580aeea57116673b67787f9f5451ab5e2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88072
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
from core to control the state of toolbar's align
buttons (based on the current selection type).
Change-Id: I1c4c4ce1776091c05196d7c8257ea59f8248284a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88160
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Use map._clip._selectionType to decide what align command to send
when one clicks on one of the toolbar align buttons. selectionType
is either 'text' or 'complex'; 'complex' by definition is set for
non-text selections like images and charts.
What is to be done next ?
1. Need to setup statechange: messages from core.git for
.uno:ObjectAlignLeft, .uno:AlignCenter, .uno:ObjectAlignRight
from sw/ sd/ in Get*State() methods of the relevant shells. After
this we need to make online toolbar align buttons to react to the
correct statechange messages based on selectionType.
2. _selectionType is not always correct. In Impress it
is always 'text' regardless of selection type. In Writer, for
shape selection, it is set to 'text'. SelectionType comes from
XTransferable2::isComplex(). Its implementations in sw/ and sd/
in core.git need fixing.
PS: In Calc, aligning images/objects does not make sense w.r.t to the
sheet in general. The align buttons are disabled in core-desktop
when an image is selected.
Change-Id: I8223cd03f864fa92523224bf88ccb992edfc2686
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87739
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
when document type is Impress
Change-Id: I33af9c10827f50be25a8490b7de8fe5504b06352
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88216
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Change-Id: I488758dc28d05ddaf7c59db7ef59047b0e2d9a11
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88104
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
To achive a better test covarage.
Now, the simple click() method is recognized
as 'tap' by hummerjs. For long press we need
to use low level events.
I expect that we can emulate other mobile events too
on a similar way.
Change-Id: I5f43afafe087133e707eed6ff8a43765324d5e24
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88161
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Since no longer it is used 'iframe' element ensure
to add event listener 'resize' of the window object
Change-Id: I89d301ddaf9e5f26c9cbf0c87c8ee157fe77247b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88099
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Introduce a new method 'getHeaderZoomScale' to L.Control.Header
that returns current zoom-scale w.r.t to 100% zoom. It also lets
you limit the zoomScale between a upper and lower bound. Use this
method to scale column header height. Reuse this method to
scale font-size too.
Change-Id: I841ef2d73752cdc2206549d540633e179f19677f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87671
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Creating an "iframe" element inside a container the browser usually creates
another sandbox window object. This is not required in mobile browser also
we can reduce complexity operations.
Change-Id: I75c57479af1cbf51beb1eaa812293432aeaf221c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87974
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Also some (commented-out) logging improvement.
Change-Id: I1d667f30c780d06e1bf4e7ad8ea6cda6ecbb2adf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87973
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
It opens a tunneled dialog, what we try to avoid on mobile.
Also after the recent focus related changes this dialog
can't get the focus, so can't add the name of the new style.
Even if I workround this focus issue and I manage to add a new
style, then that style won't be part of the style list displayed
on the mobile wizard.
All in all adding new style does not work now, so better to hide
this item.
Change-Id: I35c3686129621656f3f63914c9590248f320c15d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87965
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In a desktop LO, this item opens a drop down list,
which seems to be not implemented in online yet.
Change-Id: Ia9d82cf9a058a43077043dc128dbbc16f18da83a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87772
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This item triggers the character dialog, which we should
avoid on mobile. In a desktop LO, this item opens a drop
down list, which seems to be not implemented in online yet.
Change-Id: I56a584e6665184c4242cddc4e78ba849a150c711
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87771
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Necessary to add 'parent' member to parsed JSON structures to
allow walking up the hierarchy easily while building.
Change-Id: I52da1ba415e07bb7fef60a1c667e8c46cb0d640a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87902
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Still work in progress. The new UNO command is "MoveTabstop" with two
arguments: Tabstop (the index of the tabsetop) and Amount (in twips,
left (negative) or right).
The intent is that moving a tabstop in core will cause a callback that
will redraw the ruler, like moving a paragraph margin does.
Change-Id: Ic6b8b11811d2a7f6510c505fff421e1796300c70
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87868
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
After user has chosen to close it, of course.
Change-Id: I82fcabdae5b0f0c96b4a1101a5f55856c8dd2c60
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87800
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
The mobile wizard would not perform any actions
if opened when the mobile keyboard is visible
Change-Id: Id8722b551ea6c13f3fe22b78c996e2bb4b2db2f8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87712
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
The document object has already prevented default actions
Change-Id: I4d60ec0c6915ca266f3e2c24f0958127186ca970
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87752
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
They are no longer used instead of the Hammer recognizer library
Change-Id: Ied076c5731dcaeca37e1a15b6b637cbb62250b20
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87751
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Unfortunately the emulate 'context menu' conflict with the default
horizontal scroll behavior
Change-Id: I3cd45520a6f1e00460031b78e4963db59bc9ae59
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87750
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Change-Id: If137e015930f3918d230a86b6e2940747389ec5d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87746
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
