547f9ea731
This is meant to reduce lots of small allocations and instead have pointers into the single string for the various tokens instead. This has a few requirements, though: 1) It's no longer OK to modify the tokens, changing their length would invalidate the start/length of other tokens. Rework DocumentBroker::load() to avoid such mutation. 2) The iterators no longer expose zero-terminated strings, so Poco::cat() doesn't work anymore: add an own cat() instead and use that in e.g. ChildSession. The own cat() has the benefit that it won't read past the end of the array if the begin index is out of bounds to add more safety. (This nicely works towards killing Poco usage in general.) 3) If zero-terminated strings for all individual tokens is needed, a copy has to be made, as done in spawnProcess(). (For all of these requirements, the build fails if there are problems.) Change-Id: Iea40e4400e630b2d669f5c72aea85cb40edf9a2c Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89711 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> |
||
|---|---|---|
| .. | ||
| ChildSession.cpp | ||
| ChildSession.hpp | ||
| Delta.hpp | ||
| DummyLibreOfficeKit.cpp | ||
| DummyLibreOfficeKit.hpp | ||
| ForKit.cpp | ||
| Kit.cpp | ||
| Kit.hpp | ||
| KitHelper.hpp | ||
| TestStubs.cpp | ||
| Watermark.hpp | ||