No description
Find a file
Skyler Grey 1adece89d6 Make eslint in make check fail on eslint warnings
As discussed [on Matrix](https://col.la/suppresseslintindevelopment) the
set of things we want to pick up in CI and development are different.
Specifically, there are some things that only get in the way during
development but should not be allowed in merged code. Examples are
'debugger' statemens, dead code (e.g.  resulting from 'if (false)') and
unused variables.

After #7822 there are no more eslint warnings, so we can use it as a
separate state for these issues that should only block in CI.

This commit make make check run eslint and fail if it receives any
warnings, and changes those 3 errors so that they only emit warnings.

It's expected that there are more annoying warnings which I've missed,
if you have any please make a followup change!

This commit explicitly does not deal with formatting-related
issues (e.g. requiring single quotes for strings in eslint) as though
they can be annoying there's no reason why they should change between
development and master... another followup to improve linting experience
could be to use an autoformatter so the computer fixes the formatting
for you, however that's out-of-scope for this commit

Change-Id: I036afac5ef5056a9cc2effc21e31165aa1436ad2
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
2023-12-19 20:25:43 +00:00
.git-hooks
.github chart-releaser: fix 422 Validation Failed 2023-11-24 12:14:12 +01:00
.gitpod-files Gitpod: update defaults in coolwsd-gitpod.xml 2023-11-15 15:28:48 +01:00
android extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
browser Make eslint in make check fail on eslint warnings 2023-12-19 20:25:43 +00:00
common use isKitInProcess() instead of KIT_IN_PROCESS 2023-12-18 10:34:10 +00:00
cypress_test Fix several regressions from touch unification 2023-12-18 15:28:13 +01:00
debian Bump version to 23.05.6.3 2023-12-15 10:05:31 +01:00
docker docker: added a few labels 2023-11-16 11:13:57 +01:00
etc
fuzzer wsd: check for nullptr channel in AdminSocketHandler 2023-12-01 15:35:39 +00:00
gtk extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
indexing
ios extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
kit use isKitInProcess() instead of KIT_IN_PROCESS 2023-12-18 10:34:10 +00:00
kubernetes/helm Update Helm Chart with new release 23.05.6.3 2023-12-18 11:49:34 +05:30
man Add cli option to use settings from env variables 2023-09-23 12:44:50 +02:00
net spdx: improve machine and human readability of headers. 2023-11-14 19:36:31 +00:00
scripts wsd: test: better run_unit.sh 2023-10-24 09:20:32 +02:00
test cid#336285 Dereference null return value 2023-12-11 09:25:59 +01:00
tools spdx: improve machine and human readability of headers. 2023-11-20 14:30:02 +00:00
wasm extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
wsd use isKitInProcess() instead of KIT_IN_PROCESS 2023-12-18 10:34:10 +00:00
.cirrus.yml
.clang-format
.clang-tidy
.gitignore extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
.gitpod.dockerfile
.gitpod.yml
.mailmap
AUTHORS
autogen.sh autogen: conditionally invoke configure at the end 2023-12-19 15:00:34 +01:00
browsersync-config.js
ChangeLog
CODE_OF_CONDUCT.md
config.h.in configure: WASMAPP is now defined for WASM targets 2023-12-09 19:22:24 +00:00
config_version.h.in
configure.ac Bump version to 23.05.6.3 2023-12-15 10:05:31 +01:00
CONTRIBUTING.md
coolkitconfig-mobile.xcu
coolkitconfig.xcu.in
coolwsd-systemplate-setup copy CA certificates to jail 2023-11-14 17:01:49 +00:00
coolwsd-welcome.xml
coolwsd.init.rhel6
coolwsd.service
coolwsd.spec.in rpm: BuildRequires - those python packages have different names on differenct OS versions 2023-11-06 12:07:33 +01:00
coolwsd.xml.in Add list of allowed data sources 2023-12-01 15:25:47 +00:00
COPYING
discovery.xml
favicon.ico
g
jsstress.in
Makefile.am Make eslint in make check fail on eslint warnings 2023-12-19 20:25:43 +00:00
NEWS
PROBLEMS
README.CONTRIBUTING.md
README.FILENOTICES.md spdx: improve machine and human readability of headers. 2023-11-14 19:36:31 +00:00
README.md Readme: remove temporally the IRC in favor of matrix 2023-11-16 17:42:19 +01:00
SECURITY.md
trace-event.sample2.json

Open in Gitpod

Collabora Online

Master: Pull request policy

irc Telegram Forum Website L10n Gitpod Ready-to-Code

Your own private Office in the Cloud

Get in touch 💬

Key features

  • View and edit text documents, spreadsheets, presentations & more
  • Collaborative editing features
  • Works in any modern browser no plugin needed
  • Open Source primarily under the MPLv2 license. Some parts are under other open source licences, see e.g. browser/LICENSE.

Website

For many more details, build instructions, downloads and more please visit https://collaboraonline.github.io/

Developer assistance

Please ask your questions on any of the bridged Matrix/Telegram rooms

Join the conversation on our Discourse server at https://forum.collaboraonline.com/

Watch the tinderbox status (if it's green) at https://cpci.cbg.collabora.co.uk:8080/job/Tinderbox%20for%20online%20master%20against%20co-22.05/

Development bits

This project has several components:

  • wsd/
    • The Web Services Daemon - which accepts external connections
  • kit/
    • The client which lives in its own chroot and renders documents
  • common/
    • Shared code between these processes
  • browser/
    • The client side JavaScript component
  • test/
    • C++ based unit tests
  • cypress_test/
    • JavaScript based integration tests

Please consult the README files in the component's directory for more details:

iOS and Android apps

See the corresponding READMEs:

GitPod

Head over to https://collaboraonline.github.io/post/build-code/#build-code-on-gitpod and follow the steps.

Enjoy!