eb122ec0a0
URIs may or may not have authorization data specified
via access_header or access_token query parameters.
In the event that the host doesn't have such needs
(for example authrorization could be performed by
some other means), we should accept the request
and still go ahead and make the WOPI request
all the same.
This patch effectively reverts the changes from
a019c93d90
which threw
an exception when the authorization method was
undefined. Since there was an assertion to warn
programmers that something is amis, now we simply
log the fact in trace mode and move on.
A new unit-test is added and another one that
expected the now-removed exception has been modified.
Change-Id: I26cc2514d7465b344037a6e32b777c0fe0ba9a2c
111 lines
3.6 KiB
C++
111 lines
3.6 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "Authorization.hpp"
|
|
#include "Protocol.hpp"
|
|
#include "Log.hpp"
|
|
#include <Exceptions.hpp>
|
|
|
|
#include <cstdlib>
|
|
#include <cassert>
|
|
#include <regex>
|
|
|
|
void Authorization::authorizeURI(Poco::URI& uri) const
|
|
{
|
|
if (_type == Authorization::Type::Token)
|
|
{
|
|
static const std::string key("access_token");
|
|
|
|
Poco::URI::QueryParameters queryParams = uri.getQueryParameters();
|
|
for (auto& param: queryParams)
|
|
{
|
|
if (param.first == key)
|
|
{
|
|
param.second = _data;
|
|
uri.setQueryParameters(queryParams);
|
|
return;
|
|
}
|
|
}
|
|
|
|
// it did not exist yet
|
|
uri.addQueryParameter(key, _data);
|
|
}
|
|
}
|
|
|
|
void Authorization::authorizeRequest(Poco::Net::HTTPRequest& request) const
|
|
{
|
|
switch (_type)
|
|
{
|
|
case Type::Token:
|
|
request.set("Authorization", "Bearer " + _data);
|
|
break;
|
|
case Type::Header:
|
|
{
|
|
// there might be more headers in here; like
|
|
// Authorization: Basic ....
|
|
// X-Something-Custom: Huh
|
|
// Split based on \n's or \r's and trim, to avoid nonsense in the
|
|
// headers
|
|
StringVector tokens(Util::tokenizeAnyOf(_data, "\n\r"));
|
|
for (auto it = tokens.begin(); it != tokens.end(); ++it)
|
|
{
|
|
std::string token = tokens.getParam(*it);
|
|
|
|
size_t separator = token.find_first_of(':');
|
|
if (separator != std::string::npos)
|
|
{
|
|
size_t headerStart = token.find_first_not_of(' ', 0);
|
|
size_t headerEnd = token.find_last_not_of(' ', separator - 1);
|
|
|
|
size_t valueStart = token.find_first_not_of(' ', separator + 1);
|
|
size_t valueEnd = token.find_last_not_of(' ');
|
|
|
|
// set the header
|
|
if (headerStart != std::string::npos && headerEnd != std::string::npos &&
|
|
valueStart != std::string::npos && valueEnd != std::string::npos)
|
|
{
|
|
size_t headerLength = headerEnd - headerStart + 1;
|
|
size_t valueLength = valueEnd - valueStart + 1;
|
|
|
|
request.set(token.substr(headerStart, headerLength), token.substr(valueStart, valueLength));
|
|
}
|
|
}
|
|
}
|
|
break;
|
|
}
|
|
default:
|
|
LOG_TRC("No HTTP Authorization type detected. Assuming no authorization needed. "
|
|
"Specify access_token to set the Authorization Bearer header.");
|
|
break;
|
|
}
|
|
}
|
|
|
|
Authorization Authorization::create(const Poco::URI::QueryParameters& queryParams)
|
|
{
|
|
// prefer the access_token
|
|
std::string decoded;
|
|
for (const auto& param : queryParams)
|
|
{
|
|
if (param.first == "access_token")
|
|
{
|
|
Poco::URI::decode(param.second, decoded);
|
|
return Authorization(Authorization::Type::Token, decoded);
|
|
}
|
|
|
|
if (param.first == "access_header")
|
|
Poco::URI::decode(param.second, decoded);
|
|
}
|
|
|
|
if (!decoded.empty())
|
|
return Authorization(Authorization::Type::Header, decoded);
|
|
|
|
return Authorization();
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|