strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
libreoffice-online/common
History
Ashod Nakashian a56721f9cf wsd: remove default parameters in Session 
And make arguments explicit for a setReadOnly
and setAllowChangeComment.

Default parameters are useful for backward
compatibility, when changing an API. But
they provide no benefit when the function
in question is new and is called a couple
times anyway. Code is harder to read with
default parameters because one has to
either guess (bad) or check (wasteful).

Change-Id: I105df928f4fb73e7c341218af11903bf1ee33943
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-11-14 18:16:02 -05:00
..
Authorization.cpp wsd: move tokenizer helpers into StringVector 2022-04-12 07:39:07 -04:00
Authorization.hpp Fix typos in comments 2022-08-23 18:37:44 +02:00
Clipboard.hpp
CommandControl.cpp wsd: new config entry to add unlock_link for feature lock dialog per alias_group 2022-07-20 17:41:19 +05:30
CommandControl.hpp wsd: new config entry to add unlock_link for feature lock dialog per alias_group 2022-07-20 17:41:19 +05:30
Common.hpp wsd: support code-coverage report via --with-coverage 2022-08-02 14:45:12 -04:00
ConfigUtil.cpp introduce new options to customize featurelock dialog 2022-07-20 17:41:19 +05:30
ConfigUtil.hpp introduce new options to customize featurelock dialog 2022-07-20 17:41:19 +05:30
Crypto.cpp
Crypto.hpp
DummyTraceEventEmitter.cpp
FileUtil.cpp wsd: Cache result of disk space check, too 2022-09-08 05:48:28 +02:00
FileUtil.hpp make sure modifiedTimeUs calculates with enough precision 2022-01-26 10:23:36 +01:00
JailUtil.cpp wsd: re-create the jail directory when mounting fails 2022-09-23 16:39:56 +01:00
JailUtil.hpp wsd: re-create the jail directory when mounting fails 2022-09-23 16:39:56 +01:00
JsonUtil.hpp
Log.cpp wsd: sig: move signalLog helpers to SigUtil 2022-07-12 13:43:43 +01:00
Log.hpp wsd: fix multi-part logging 2022-09-13 09:45:43 +02:00
Message.hpp wsd: Message supports new find and contains operations 2022-06-27 14:07:08 +01:00
MessageQueue.cpp masterpage: get & set optional mode parameter for tiles (server side) 2022-09-19 15:18:23 +02:00
MessageQueue.hpp Fix typos in comments 2022-08-23 18:37:44 +02:00
MobileApp.cpp
MobileApp.hpp
Png.hpp deltas: track, transmit and cache deltas (disabled for now) 2022-05-24 22:16:58 +01:00
Protocol.cpp wsd: move tokenizer helpers into StringVector 2022-04-12 07:39:07 -04:00
Protocol.hpp wsd: track modifying user commands 2022-08-25 15:12:10 +01:00
Rectangle.hpp
RenderTiles.hpp delta: include canonical-view-id into the TileLocation. 2022-06-22 09:16:45 +01:00
Seccomp.cpp wsd: always use Util::forcedExit to properly cleanup 2022-08-02 07:51:52 -04:00
Seccomp.hpp
security.h
Session.cpp wsd: minor log cleanup 2022-09-13 09:45:43 +02:00
Session.hpp wsd: remove default parameters in Session 2022-11-14 18:16:02 -05:00
SigUtil.cpp mutex include cleanup. 2022-08-31 21:31:31 +01:00
SigUtil.hpp wsd: remove default arg from SigUtil::killChild 2022-08-02 07:51:52 -04:00
SpookyV2.cpp common: move "hashSubBuffer" function 2022-05-09 16:40:57 +01:00
SpookyV2.h common: move "hashSubBuffer" function 2022-05-09 16:40:57 +01:00
StateEnum.hpp Fix typos in comments 2022-08-23 18:37:44 +02:00
StringVector.cpp wsd: move tokenizer helpers into StringVector 2022-04-12 07:39:07 -04:00
StringVector.hpp Fix typos in comments 2022-08-23 18:37:44 +02:00
TraceEvent.cpp
TraceEvent.hpp Fix typos in comments 2022-08-23 18:37:44 +02:00
Unit.cpp wsd: test: log multiple exitTest cases with different results 2022-11-12 18:45:35 -05:00
Unit.hpp wsd: improved UnitWOPILock to avoid race-condition 2022-11-03 05:17:05 -04:00
Util.cpp wsd: extract URI encoding in a helper 2022-10-26 16:26:15 +02:00
Util.hpp wsd: extract URI encoding in a helper 2022-10-26 16:26:15 +02:00