libreoffice-online/tools
Caolán McNamara 5fbc4bbbdd use a smaller subset of flags for remounting readonly
a) In the linux namespace mount case an additional MS_NOATIME, etc. will result in
EPERM on remounting something hosted in a toplevel [rel]atime mount. man 2 mount
has 'An attempt was made to modify (MS_REMOUNT) the MS_RDONLY, MS_NOSUID, or
MS_NOEXEC flag, or one of the "atime" flags (MS_NOATIME, MS_NODIRATIME, MS_RELATIME)
of an existing mount, but the mount is locked'.

b) lxc has default apparmor rules of
https://github.com/lxc/lxc/blob/main/config/apparmor/abstractions/container-base
where the closest match is:  "mount options=(ro,remount,bind,nodev,nosuid)"
so additional 'MS_SILENT' or 'MS_REC' flags similarly also cause the remount to
be denied

So if we use a more recognized set of options we work out of the box in
the default lxc configuration.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5f8de2de998ae1a85fefc1c9537b79b2b3bdefec
2024-07-17 15:40:30 +02:00
..
Benchmark.cpp cid#360694 silence Division or modulo by float zero 2024-04-16 15:19:35 +02:00
Config.cpp cid#368707 Unchecked return value from library 2024-05-27 08:36:18 +02:00
ConfigMigrationAssistant.cpp cool#8328 - config header fixup. 2024-02-21 09:35:25 +00:00
Connect.cpp cid#318827 COPY_INSTEAD_OF_MOVE 2024-05-27 08:36:18 +02:00
COOLWebSocket.hpp wsd: test: unit-test validation in debug only 2024-06-12 09:15:40 +01:00
KitClient.cpp
map.cpp cid#360697 Ignoring number of bytes read 2024-04-23 08:53:55 +02:00
mount.cpp use a smaller subset of flags for remounting readonly 2024-07-17 15:40:30 +02:00
Replay.hpp coolstress: Rewrite removed commands 2024-07-05 10:23:26 -04:00
Stress.cpp
Tool.cpp
WebSocketDump.cpp wsd: remove sendWithDateAndAgent 2024-03-19 20:51:02 -04:00