strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
libreoffice-online/test
History
Ashod Nakashian 36c12dd49c wsd: always subscribe when proactively rendering tiles 
When issuing tile render requests proactively (upon
getting invalidatetile event), if the registered
request has no subscriber, TileCache::saveTileAndNotify
simply drops the tiles!

New call sequence:
ClientSession::handleTileInvalidation
    docBroker->handleTileCombinedRequest
	tileCache().subscribeToTileRendering //< fix

The end result was that we rendered tiles only
to discard them, potentially leaving the clients with
stale tiles (unless they requested new tiles themselves).
If they do request them, we still benefit from the cached
copies of the internal requests we had issued (and dropped).
The issue is that we are wasting an opportunity for efficiency
and relying on the client to request tiles when we normally
push on invalidation, adding latency and being inconsistent.

Change-Id: I4d3aa3739c5324ffca15c80b20dce29ac03eef73
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2021-11-15 11:40:05 +01:00
..
data New POST service to render a search result + unit and integ. tests 2021-09-13 10:36:15 +02:00
traces Trace: Writer and Impress: Generated loolstress traces 2021-11-04 13:02:04 +00:00
.gitignore
countloolkits.hpp
DeltaTests.cpp
fakesockettest.cpp
helpers.hpp test: fix sanitizers detection 2021-11-09 08:23:45 +01:00
httpcrashtest.cpp Move LOOLWebSocket into test/ - where it can be slowly removed. 2021-10-11 13:40:20 +01:00
HttpRequestTests.cpp wsd: chunked transfer and tests 2021-09-26 17:02:01 -04:00
HttpTestServer.hpp make Socket use Buffer for input buffer too 2021-10-26 12:11:58 +02:00
HttpWhiteBoxTests.cpp wsd: test: correct include order for operator resolution 2021-09-27 09:25:40 -04:00
httpwstest.cpp Move LOOLWebSocket into test/ - where it can be slowly removed. 2021-10-11 13:40:20 +01:00
integration-http-server.cpp test: rename loleaflet -> cool 2021-11-10 17:18:56 +01:00
lokassert.hpp test: visual marker for mismatched strings in failed tests 2021-09-26 17:02:01 -04:00
Makefile.am Move LOOLWebSocket into test/ - where it can be slowly removed. 2021-10-11 13:40:20 +01:00
run_unit.sh.in test: run test with capabilities disabled 2021-07-22 11:52:26 -04:00
test.cpp wsd: killpoco: cert verification 2021-07-18 21:14:48 -04:00
test.hpp
testlog.hpp
TileCacheTests.cpp wsd: always subscribe when proactively rendering tiles 2021-11-15 11:40:05 +01:00
TileQueueTests.cpp
UnitAdmin.cpp test: rename loleaflet -> browser 2021-11-10 17:18:56 +01:00
UnitBadDocLoad.cpp
UnitCalc.cpp
UnitClient.cpp wsd: test: set the test name for old-style tests 2021-04-27 08:09:49 -04:00
UnitClose.cpp
UnitConvert.cpp Move LOOLWebSocket into test/ - where it can be slowly removed. 2021-10-11 13:40:20 +01:00
UnitCopyPaste.cpp wsd: test: improve the stability of UnitCopyPaste 2021-04-27 08:09:49 -04:00
UnitCursor.cpp wsd: test: remove superfluous object 2021-04-27 08:09:49 -04:00
UnitEachView.cpp
UnitFuzz.cpp Move LOOLWebSocket into test/ - where it can be slowly removed. 2021-10-11 13:40:20 +01:00
UnitHosting.cpp wsd: test: log UnitHosting activity 2021-05-02 22:35:39 -04:00
UnitHTTP.cpp wsd: test: log more in UnitHTTP 2021-04-11 01:05:20 -04:00
UnitHTTP.hpp Move LOOLWebSocket into test/ - where it can be slowly removed. 2021-10-11 13:40:20 +01:00
UnitInsertDelete.cpp
UnitLargePaste.cpp
UnitLoad.cpp Fix Debian 8 / gcc-4.9 warnings 2021-04-30 10:38:09 +02:00
UnitLoadTorture.cpp wsd: improved WebSocketSession interface 2021-04-27 08:09:49 -04:00
UnitOAuth.cpp
UnitPasswordProtected.cpp
UnitPaste.cpp
UnitPrefork.cpp
UnitRenderingOptions.cpp RenderingOptions Test: Updated due to status message's update. 2021-07-25 11:58:34 +03:00
UnitRenderSearchResult.cpp New POST service to render a search result + unit and integ. tests 2021-09-13 10:36:15 +02:00
UnitRenderShape.cpp
UnitSession.cpp
UnitStorage.cpp
UnitTiffLoad.cpp
UnitTileCache.cpp
UnitTimeout.cpp
UnitTyping.cpp Test the merging semantics harder 2021-07-22 13:41:53 +03:00
UnitUNOCommand.cpp
UnitWOPI.cpp wsd: test: assertPutFileRequest returns the http response 2021-05-02 22:35:39 -04:00
UnitWOPIAsyncUpload_Close.cpp wsd: test: correct logging of phase change 2021-07-17 22:58:23 -04:00
UnitWOPIAsyncUpload_Modify.cpp wsd: test: improve modify test 2021-07-18 21:14:48 -04:00
UnitWOPIAsyncUpload_ModifyClose.cpp wsd: test close-after-modify to confirm no data loss 2021-07-17 22:58:23 -04:00
UnitWOPIDocumentConflict.cpp
UnitWOPIFileUrl.cpp
UnitWOPIHttpHeaders.cpp wsd: test: assertPutFileRequest returns the http response 2021-05-02 22:35:39 -04:00
UnitWOPIHttpRedirect.cpp HTTP 302 Found - redirrect support for downloadDocument 2021-07-12 08:44:39 +02:00
UnitWOPIHttpRedirectLoop.cpp Rename fileId to redirectionCount 2021-07-12 08:44:39 +02:00
UnitWOPILoadEncoded.cpp
UnitWopiOwnertermination.cpp wsd: test: assertPutFileRequest returns the http response 2021-05-02 22:35:39 -04:00
UnitWOPIRenameFile.cpp
UnitWOPISaveAs.cpp
UnitWOPITemplate.cpp wsd: test: log state transition in UnitWOPITemplate 2021-06-13 21:57:43 -04:00
UnitWOPIVersionRestore.cpp wsd: test: assertPutFileRequest returns the http response 2021-05-02 22:35:39 -04:00
UnitWOPIWatermark.cpp
WhiteBoxTests.cpp test: rename loleaflet -> cool 2021-11-10 17:18:56 +01:00
WopiProofTests.cpp
WopiTestServer.hpp Remove unused Poco/Timestamp include 2021-10-15 13:59:31 +02:00