strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
libreoffice-online/common
History
Caolán McNamara 5fbc4bbbdd use a smaller subset of flags for remounting readonly 
a) In the linux namespace mount case an additional MS_NOATIME, etc. will result in
EPERM on remounting something hosted in a toplevel [rel]atime mount. man 2 mount
has 'An attempt was made to modify (MS_REMOUNT) the MS_RDONLY, MS_NOSUID, or
MS_NOEXEC flag, or one of the "atime" flags (MS_NOATIME, MS_NODIRATIME, MS_RELATIME)
of an existing mount, but the mount is locked'.

b) lxc has default apparmor rules of
https://github.com/lxc/lxc/blob/main/config/apparmor/abstractions/container-base
where the closest match is:  "mount options=(ro,remount,bind,nodev,nosuid)"
so additional 'MS_SILENT' or 'MS_REC' flags similarly also cause the remount to
be denied

So if we use a more recognized set of options we work out of the box in
the default lxc configuration.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5f8de2de998ae1a85fefc1c9537b79b2b3bdefec
2024-07-17 15:40:30 +02:00
..
Authorization.cpp
Authorization.hpp wsd: include cleanup 2024-03-19 20:51:02 -04:00
Clipboard.hpp cool#9219 clipboard: only accept downloaded data in own format 2024-06-11 14:45:50 +01:00
CommandControl.cpp
CommandControl.hpp
Common.hpp unit-crash doesn't wait long enough when BindMount fails 2024-07-16 21:13:53 +01:00
ConfigUtil.cpp bgsave: lower priority of background thread. 2024-05-10 16:30:37 +01:00
ConfigUtil.hpp bgsave: lower priority of background thread. 2024-05-10 16:30:37 +01:00
CoolMount.cpp use a smaller subset of flags for remounting readonly 2024-07-17 15:40:30 +02:00
Crypto-stub.cpp wsd: Unconditionally compile support-key-enabled code paths 2024-04-14 01:23:00 +01:00
Crypto.cpp wsd: Unconditionally compile support-key-enabled code paths 2024-04-14 01:23:00 +01:00
Crypto.hpp wsd: Unconditionally compile support-key-enabled code paths 2024-04-14 01:23:00 +01:00
DummyTraceEventEmitter.cpp wsd: reduce directives for unused variable supression 2024-03-09 12:37:19 -05:00
FileUtil.cpp use buildLocalPathToJail instead of direct JAILED_DOCUMENT_ROOT concat 2024-07-12 16:23:09 +01:00
FileUtil.hpp use buildLocalPathToJail instead of direct JAILED_DOCUMENT_ROOT concat 2024-07-12 16:23:09 +01:00
JailUtil.cpp use a smaller subset of flags for remounting readonly 2024-07-17 15:40:30 +02:00
JailUtil.hpp do coolwsd setupRoot in a fork 2024-07-16 07:09:42 +02:00
JsonUtil.hpp killpoco: remove lots of redundant JSON includes. 2024-04-25 09:06:13 +02:00
LangUtil.hpp
Log.cpp do coolwsd setupRoot in a fork 2024-07-16 07:09:42 +02:00
Log.hpp delta: Disable pixel tracing in trace logging by default. 2024-06-20 15:55:01 +01:00
Message.hpp cool#9120 - use a simple hash to avoid most tile: comparisons. 2024-05-22 19:58:28 +01:00
MobileApp.cpp wsd: move wopi stub/dummy interface to MobileApp.hpp 2024-04-03 14:26:28 +01:00
MobileApp.hpp impress: restrict presentation in readonly mode 2024-05-07 13:21:04 +01:00
Png.hpp reduce uses of MOBILEAPP on some files 2024-03-20 09:13:00 +01:00
Protocol.cpp
Protocol.hpp
Rectangle.hpp common: avoid adding too large ints in the Rectangle ctor 2024-05-28 13:41:14 +02:00
RenderTiles.hpp Cleanup and shorten tilecombine descriptor lists. 2024-05-26 19:28:30 +01:00
Seccomp.cpp wsd: reduce directives for unused variable supression 2024-03-09 12:37:19 -05:00
Seccomp.hpp
security.h merge duplicate capability dropping code 2024-07-12 14:13:52 +01:00
Session.cpp honour online host verification exemption also in core 2024-06-24 18:53:34 +02:00
Session.hpp honour online host verification exemption also in core 2024-06-24 18:53:34 +02:00
SigUtil.cpp cool#9383: build error on FreeBSD 2024-07-10 15:33:30 +02:00
SigUtil.hpp bgsave: ensure kit processes die when their parents do. 2024-04-16 15:07:18 +01:00
Simd.cpp
Simd.hpp cool#8328 - config header fixup. 2024-02-21 09:35:25 +00:00
SpookyV2.cpp
SpookyV2.h
StateEnum.hpp Logging: add Area parameter and new LOGA_ macros to annotate areas. 2024-05-14 18:37:52 +02:00
StringVector.cpp cool#8328 - config header fixup. 2024-02-21 09:35:25 +00:00
StringVector.hpp Add SysStopwatch to use /proc/self/stat tick timings to measure time. 2024-06-04 09:11:52 +02:00
ThreadPool.hpp cool#9271 - re-start delta thread pool after bgsave. 2024-06-13 20:14:08 +01:00
TraceEvent.cpp wsd: streamline TraceEvent strings 2024-03-18 18:41:49 +00:00
TraceEvent.hpp wsd: avoid duplicate string copying for ProfileZone 2024-03-18 18:41:49 +00:00
Unit.cpp wsd: test: unit-test validation in debug only 2024-06-12 09:15:40 +01:00
Unit.hpp fix: coolwsd getting killed on kit segfault 2024-07-10 16:36:34 +01:00
Util-desktop.cpp UnitPerf: add a simple performance unit test. 2024-06-04 09:11:52 +02:00
Util-mobile.cpp add isMobileApp util function to reduce ifdefs 2024-03-20 09:13:00 +01:00
Util.cpp Trim URIs if necessary, and test that. 2024-07-11 12:52:30 +01:00
Util.hpp Trim URIs if necessary, and test that. 2024-07-11 12:52:30 +01:00
Watchdog.hpp bump watchdog pings from 20ms to 50ms 2024-04-30 17:55:13 +02:00