2017-05-19 10:20:05 -05:00
|
|
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
|
|
/*
|
|
|
|
* This file is part of the LibreOffice project.
|
|
|
|
*
|
|
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "check.hxx"
|
2017-05-19 16:51:46 -05:00
|
|
|
#include "compat.hxx"
|
2017-05-19 10:20:05 -05:00
|
|
|
#include "plugin.hxx"
|
2018-11-16 02:41:03 -06:00
|
|
|
#include <iostream>
|
|
|
|
#include <fstream>
|
2017-05-19 10:20:05 -05:00
|
|
|
|
2018-02-22 00:55:08 -06:00
|
|
|
namespace
|
|
|
|
{
|
2018-08-23 07:35:15 -05:00
|
|
|
class RedundantFCast final : public loplugin::FilteringPlugin<RedundantFCast>
|
2017-05-19 10:20:05 -05:00
|
|
|
{
|
|
|
|
public:
|
2018-02-22 00:55:08 -06:00
|
|
|
explicit RedundantFCast(loplugin::InstantiationData const& data)
|
2018-08-23 07:35:15 -05:00
|
|
|
: FilteringPlugin(data)
|
2018-02-22 00:55:08 -06:00
|
|
|
{
|
|
|
|
}
|
2017-05-19 10:20:05 -05:00
|
|
|
|
2018-03-09 05:59:52 -06:00
|
|
|
bool TraverseFunctionDecl(FunctionDecl* functionDecl)
|
|
|
|
{
|
|
|
|
auto prev = m_CurrentFunctionDecl;
|
|
|
|
m_CurrentFunctionDecl = functionDecl;
|
|
|
|
auto rv = RecursiveASTVisitor<RedundantFCast>::TraverseFunctionDecl(functionDecl);
|
|
|
|
m_CurrentFunctionDecl = prev;
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool VisitReturnStmt(ReturnStmt const* returnStmt)
|
|
|
|
{
|
|
|
|
if (ignoreLocation(returnStmt))
|
|
|
|
return true;
|
|
|
|
Expr const* expr = returnStmt->getRetValue();
|
|
|
|
if (!expr)
|
|
|
|
return true;
|
|
|
|
if (auto exprWithCleanups = dyn_cast<ExprWithCleanups>(expr))
|
|
|
|
expr = exprWithCleanups->getSubExpr();
|
|
|
|
if (auto cxxConstructExpr = dyn_cast<CXXConstructExpr>(expr))
|
|
|
|
{
|
|
|
|
if (cxxConstructExpr->getNumArgs() != 1)
|
|
|
|
return true;
|
|
|
|
expr = cxxConstructExpr->getArg(0);
|
|
|
|
}
|
|
|
|
if (auto materializeTemporaryExpr = dyn_cast<MaterializeTemporaryExpr>(expr))
|
|
|
|
expr = materializeTemporaryExpr->GetTemporaryExpr();
|
|
|
|
auto cxxFunctionalCastExpr = dyn_cast<CXXFunctionalCastExpr>(expr);
|
|
|
|
if (!cxxFunctionalCastExpr)
|
|
|
|
return true;
|
|
|
|
auto const t1 = cxxFunctionalCastExpr->getTypeAsWritten();
|
|
|
|
auto const t2 = compat::getSubExprAsWritten(cxxFunctionalCastExpr)->getType();
|
|
|
|
if (t1.getCanonicalType().getTypePtr() != t2.getCanonicalType().getTypePtr())
|
|
|
|
return true;
|
2018-03-23 07:18:34 -05:00
|
|
|
if (!loplugin::isOkToRemoveArithmeticCast(compiler.getASTContext(), t1, t2,
|
|
|
|
cxxFunctionalCastExpr->getSubExpr()))
|
|
|
|
{
|
|
|
|
return true;
|
|
|
|
}
|
2018-03-09 05:59:52 -06:00
|
|
|
report(DiagnosticsEngine::Warning, "redundant functional cast from %0 to %1",
|
|
|
|
cxxFunctionalCastExpr->getExprLoc())
|
|
|
|
<< t2 << t1 << cxxFunctionalCastExpr->getSourceRange();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-03-08 11:39:41 -06:00
|
|
|
/* Check for the creation of unnecessary temporaries when calling a method that takes a param by const & */
|
|
|
|
bool VisitCallExpr(CallExpr const* callExpr)
|
|
|
|
{
|
|
|
|
if (ignoreLocation(callExpr))
|
|
|
|
return true;
|
|
|
|
const FunctionDecl* functionDecl;
|
|
|
|
if (isa<CXXMemberCallExpr>(callExpr))
|
|
|
|
functionDecl = dyn_cast<CXXMemberCallExpr>(callExpr)->getMethodDecl();
|
|
|
|
else
|
|
|
|
functionDecl = callExpr->getDirectCallee();
|
|
|
|
if (!functionDecl)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
unsigned len = std::min(callExpr->getNumArgs(), functionDecl->getNumParams());
|
|
|
|
for (unsigned i = 0; i < len; ++i)
|
|
|
|
{
|
|
|
|
// check if param is const&
|
|
|
|
auto param = functionDecl->getParamDecl(i);
|
|
|
|
auto lvalueType = param->getType()->getAs<LValueReferenceType>();
|
|
|
|
if (!lvalueType)
|
|
|
|
continue;
|
|
|
|
if (!lvalueType->getPointeeType().isConstQualified())
|
|
|
|
continue;
|
|
|
|
auto paramClassOrStructType = lvalueType->getPointeeType()->getAs<RecordType>();
|
|
|
|
if (!paramClassOrStructType)
|
|
|
|
continue;
|
|
|
|
// check for temporary and functional cast in argument expression
|
|
|
|
auto arg = callExpr->getArg(i)->IgnoreImpCasts();
|
|
|
|
auto materializeTemporaryExpr = dyn_cast<MaterializeTemporaryExpr>(arg);
|
|
|
|
if (!materializeTemporaryExpr)
|
|
|
|
continue;
|
|
|
|
auto functionalCast = dyn_cast<CXXFunctionalCastExpr>(
|
|
|
|
materializeTemporaryExpr->GetTemporaryExpr()->IgnoreImpCasts());
|
|
|
|
if (!functionalCast)
|
|
|
|
continue;
|
|
|
|
auto const t1 = functionalCast->getTypeAsWritten();
|
|
|
|
auto const t2 = compat::getSubExprAsWritten(functionalCast)->getType();
|
|
|
|
if (t1.getCanonicalType().getTypePtr() != t2.getCanonicalType().getTypePtr())
|
|
|
|
continue;
|
|
|
|
// Check that the underlying expression is of the same class/struct type as the param i.e. that we are not instantiating
|
|
|
|
// something useful
|
|
|
|
if (t1.getCanonicalType().getTypePtr() != paramClassOrStructType)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
report(DiagnosticsEngine::Warning, "redundant functional cast from %0 to %1",
|
|
|
|
arg->getExprLoc())
|
|
|
|
<< t2 << t1 << arg->getSourceRange();
|
|
|
|
report(DiagnosticsEngine::Note, "in call to method here", param->getLocation())
|
|
|
|
<< param->getSourceRange();
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-11-16 02:41:03 -06:00
|
|
|
/* Check for the creation of unnecessary temporaries when calling a constructor that takes a param by const & */
|
|
|
|
bool VisitCXXConstructExpr(CXXConstructExpr const* callExpr)
|
|
|
|
{
|
|
|
|
if (ignoreLocation(callExpr))
|
|
|
|
return true;
|
|
|
|
const CXXConstructorDecl* functionDecl = callExpr->getConstructor();
|
|
|
|
|
|
|
|
unsigned len = std::min(callExpr->getNumArgs(), functionDecl->getNumParams());
|
|
|
|
for (unsigned i = 0; i < len; ++i)
|
|
|
|
{
|
|
|
|
// check if param is const&
|
|
|
|
auto param = functionDecl->getParamDecl(i);
|
|
|
|
auto lvalueType = param->getType()->getAs<LValueReferenceType>();
|
|
|
|
if (!lvalueType)
|
|
|
|
continue;
|
|
|
|
if (!lvalueType->getPointeeType().isConstQualified())
|
|
|
|
continue;
|
|
|
|
auto paramClassOrStructType = lvalueType->getPointeeType()->getAs<RecordType>();
|
|
|
|
if (!paramClassOrStructType)
|
|
|
|
continue;
|
|
|
|
// check for temporary and functional cast in argument expression
|
|
|
|
auto arg = callExpr->getArg(i)->IgnoreImplicit();
|
|
|
|
auto functionalCast = dyn_cast<CXXFunctionalCastExpr>(arg);
|
|
|
|
if (!functionalCast)
|
|
|
|
continue;
|
|
|
|
auto const t1 = functionalCast->getTypeAsWritten();
|
|
|
|
auto const t2 = compat::getSubExprAsWritten(functionalCast)->getType();
|
|
|
|
if (t1.getCanonicalType().getTypePtr() != t2.getCanonicalType().getTypePtr())
|
|
|
|
continue;
|
|
|
|
// Check that the underlying expression is of the same class/struct type as the param i.e. that we are not instantiating
|
|
|
|
// something useful
|
|
|
|
if (t1.getCanonicalType().getTypePtr() != paramClassOrStructType)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
report(DiagnosticsEngine::Warning, "redundant functional cast from %0 to %1",
|
|
|
|
arg->getExprLoc())
|
|
|
|
<< t2 << t1 << arg->getSourceRange();
|
|
|
|
report(DiagnosticsEngine::Note, "in call to method here", param->getLocation())
|
|
|
|
<< param->getSourceRange();
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-02-22 00:55:08 -06:00
|
|
|
bool VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr const* expr)
|
|
|
|
{
|
|
|
|
if (ignoreLocation(expr))
|
2017-05-19 10:20:05 -05:00
|
|
|
return true;
|
2018-11-16 02:41:03 -06:00
|
|
|
// specifying the name for an init-list is necessary sometimes
|
|
|
|
if (isa<InitListExpr>(expr->getSubExpr()->IgnoreImplicit()))
|
|
|
|
return true;
|
|
|
|
if (isa<CXXStdInitializerListExpr>(expr->getSubExpr()->IgnoreImplicit()))
|
|
|
|
return true;
|
2017-05-19 10:20:05 -05:00
|
|
|
auto const t1 = expr->getTypeAsWritten();
|
2017-05-19 16:51:46 -05:00
|
|
|
auto const t2 = compat::getSubExprAsWritten(expr)->getType();
|
2018-02-22 00:55:08 -06:00
|
|
|
if (t1.getCanonicalType().getTypePtr() != t2.getCanonicalType().getTypePtr())
|
2017-06-13 10:00:30 -05:00
|
|
|
{
|
|
|
|
return true;
|
|
|
|
}
|
2018-11-16 02:41:03 -06:00
|
|
|
// (a) we do a lot of int/sal_Int32 kind of casts which might be platform necessary?
|
|
|
|
// (b) we do bool/bool casts in unit tests to avoid one of the other plugins
|
|
|
|
// so just ignore this kind of thing for now
|
|
|
|
if (const auto* BT = dyn_cast<BuiltinType>(t1->getUnqualifiedDesugaredType()))
|
2017-05-19 10:20:05 -05:00
|
|
|
{
|
2018-11-16 02:41:03 -06:00
|
|
|
auto k = BT->getKind();
|
|
|
|
if (k == BuiltinType::Double || k == BuiltinType::Float
|
|
|
|
|| (k >= BuiltinType::Bool && k <= BuiltinType::Int128))
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
if (const auto* BT = dyn_cast<BuiltinType>(t2->getUnqualifiedDesugaredType()))
|
|
|
|
{
|
|
|
|
auto k = BT->getKind();
|
|
|
|
if (k == BuiltinType::Double || k == BuiltinType::Float
|
|
|
|
|| (k >= BuiltinType::Bool && k <= BuiltinType::Int128))
|
|
|
|
return true;
|
2017-05-19 10:20:05 -05:00
|
|
|
}
|
2018-11-16 02:41:03 -06:00
|
|
|
auto tc = loplugin::TypeCheck(t1);
|
|
|
|
if (tc.Typedef("sal_Int32").GlobalNamespace())
|
|
|
|
return true;
|
|
|
|
|
2018-02-22 00:55:08 -06:00
|
|
|
report(DiagnosticsEngine::Warning, "redundant functional cast from %0 to %1",
|
|
|
|
expr->getExprLoc())
|
2017-05-19 10:20:05 -05:00
|
|
|
<< t2 << t1 << expr->getSourceRange();
|
2018-11-16 02:41:03 -06:00
|
|
|
//getParentStmt(expr)->dump();
|
2017-05-19 10:20:05 -05:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
2018-02-22 00:55:08 -06:00
|
|
|
void run() override
|
|
|
|
{
|
2018-11-16 02:41:03 -06:00
|
|
|
if (!compiler.getLangOpts().CPlusPlus)
|
|
|
|
return;
|
|
|
|
std::string fn = handler.getMainFileName();
|
|
|
|
loplugin::normalizeDotDotInFilePath(fn);
|
|
|
|
// necessary on some other platforms
|
|
|
|
if (fn == SRCDIR "/sal/osl/unx/socket.cxx")
|
|
|
|
return;
|
|
|
|
// compile-time check of constant
|
|
|
|
if (fn == SRCDIR "/bridges/source/jni_uno/jni_bridge.cxx")
|
|
|
|
return;
|
|
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
2017-05-19 10:20:05 -05:00
|
|
|
}
|
2018-03-09 05:59:52 -06:00
|
|
|
FunctionDecl const* m_CurrentFunctionDecl;
|
2017-05-19 10:20:05 -05:00
|
|
|
};
|
|
|
|
|
2018-02-22 00:55:08 -06:00
|
|
|
static loplugin::Plugin::Registration<RedundantFCast> reg("redundantfcast");
|
2017-05-19 10:20:05 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|