From 0210aac7f9f52701a3b3b74d4de8eaf86a52e8b5 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 30 Sep 2024 14:03:14 +0200 Subject: [PATCH] loplugin:constantparam Change-Id: I114331d1cb7860087d5f5bee77af771e537b0616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174301 Tested-by: Jenkins Reviewed-by: Noel Grandin --- chart2/source/model/template/ChartTypeManager.cxx | 8 ++++---- .../source/model/template/HistogramChartTypeTemplate.cxx | 4 ++-- .../source/model/template/HistogramChartTypeTemplate.hxx | 2 +- chart2/source/model/template/PieChartTypeTemplate.cxx | 3 +-- chart2/source/model/template/PieChartTypeTemplate.hxx | 3 +-- 5 files changed, 9 insertions(+), 11 deletions(-) diff --git a/chart2/source/model/template/ChartTypeManager.cxx b/chart2/source/model/template/ChartTypeManager.cxx index 4ec856c822f0..b81e47ee3884 100644 --- a/chart2/source/model/template/ChartTypeManager.cxx +++ b/chart2/source/model/template/ChartTypeManager.cxx @@ -426,22 +426,22 @@ rtl::Reference< ::chart::ChartTypeTemplate > ChartTypeManager::createTemplate( case TEMPLATE_THREEDPIE: xTemplate.set( new PieChartTypeTemplate( m_xContext, aServiceSpecifier, chart2::PieChartOffsetMode_NONE, false, - chart2::PieChartSubType_NONE, 2, 3 )); + chart2::PieChartSubType_NONE, 3 )); break; case TEMPLATE_THREEDPIEALLEXPLODED: xTemplate.set( new PieChartTypeTemplate( m_xContext, aServiceSpecifier, chart2::PieChartOffsetMode_ALL_EXPLODED, false, - chart2::PieChartSubType_NONE, 2, 3 )); + chart2::PieChartSubType_NONE, 3 )); break; case TEMPLATE_THREEDDONUT: xTemplate.set( new PieChartTypeTemplate( m_xContext, aServiceSpecifier, chart2::PieChartOffsetMode_NONE, true, - chart2::PieChartSubType_NONE, 2, 3 )); + chart2::PieChartSubType_NONE, 3 )); break; case TEMPLATE_THREEDDONUTALLEXPLODED: xTemplate.set( new PieChartTypeTemplate( m_xContext, aServiceSpecifier, chart2::PieChartOffsetMode_ALL_EXPLODED, true, - chart2::PieChartSubType_NONE, 2, 3 )); + chart2::PieChartSubType_NONE, 3 )); break; case TEMPLATE_SCATTERLINESYMBOL: diff --git a/chart2/source/model/template/HistogramChartTypeTemplate.cxx b/chart2/source/model/template/HistogramChartTypeTemplate.cxx index 0bc41d56fc7b..97dc001d9550 100644 --- a/chart2/source/model/template/HistogramChartTypeTemplate.cxx +++ b/chart2/source/model/template/HistogramChartTypeTemplate.cxx @@ -61,10 +61,10 @@ namespace chart { HistogramChartTypeTemplate::HistogramChartTypeTemplate( Reference const& xContext, const OUString& rServiceName, - StackMode eStackMode, sal_Int32 nDim /* = 2 */) + StackMode eStackMode) : ChartTypeTemplate(xContext, rServiceName) , m_eStackMode(eStackMode) - , m_nDim(nDim) + , m_nDim(2) { } diff --git a/chart2/source/model/template/HistogramChartTypeTemplate.hxx b/chart2/source/model/template/HistogramChartTypeTemplate.hxx index 292cdce32f33..519292f6107f 100644 --- a/chart2/source/model/template/HistogramChartTypeTemplate.hxx +++ b/chart2/source/model/template/HistogramChartTypeTemplate.hxx @@ -21,7 +21,7 @@ class HistogramChartTypeTemplate : public ChartTypeTemplate, public ::property:: public: explicit HistogramChartTypeTemplate( css::uno::Reference const& xContext, - const OUString& rServiceName, StackMode eStackMode, sal_Int32 nDim = 2); + const OUString& rServiceName, StackMode eStackMode); /// merge XInterface implementations DECLARE_XINTERFACE() diff --git a/chart2/source/model/template/PieChartTypeTemplate.cxx b/chart2/source/model/template/PieChartTypeTemplate.cxx index 0ae474623f37..6bd4d3bb6efb 100644 --- a/chart2/source/model/template/PieChartTypeTemplate.cxx +++ b/chart2/source/model/template/PieChartTypeTemplate.cxx @@ -140,7 +140,6 @@ PieChartTypeTemplate::PieChartTypeTemplate( chart2::PieChartOffsetMode eMode, bool bRings, chart2::PieChartSubType eSubType, - sal_Int32 nCompositeSize, sal_Int32 nDim /* = 2 */ ) : ChartTypeTemplate( xContext, rServiceName ) { @@ -148,7 +147,7 @@ PieChartTypeTemplate::PieChartTypeTemplate( setFastPropertyValue_NoBroadcast( PROP_PIE_TEMPLATE_DIMENSION, uno::Any( nDim )); setFastPropertyValue_NoBroadcast( PROP_PIE_TEMPLATE_USE_RINGS, uno::Any( bRings )); setFastPropertyValue_NoBroadcast( PROP_PIE_TEMPLATE_SUB_PIE_TYPE, uno::Any( eSubType )); - setFastPropertyValue_NoBroadcast( PROP_PIE_TEMPLATE_COMPOSITE_SIZE, uno::Any( nCompositeSize )); + setFastPropertyValue_NoBroadcast( PROP_PIE_TEMPLATE_COMPOSITE_SIZE, uno::Any( sal_Int32(2) )); } PieChartTypeTemplate::~PieChartTypeTemplate() diff --git a/chart2/source/model/template/PieChartTypeTemplate.hxx b/chart2/source/model/template/PieChartTypeTemplate.hxx index 5e5d2539969d..c7b3b9b6951c 100644 --- a/chart2/source/model/template/PieChartTypeTemplate.hxx +++ b/chart2/source/model/template/PieChartTypeTemplate.hxx @@ -39,8 +39,7 @@ public: css::chart2::PieChartOffsetMode eMode, bool bRings, css::chart2::PieChartSubType eSubType, - sal_Int32 nCompositeSize, - sal_Int32 nDim = 2 ); + sal_Int32 nDim ); virtual ~PieChartTypeTemplate() override; /// merge XInterface implementations