strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clang-tidy performance-unnecessary-value-param in vcl

Browse source 
Change-Id: I403f148060891feec56d7d2ef173a9c4934baf9e
Reviewed-on: https://gerrit.libreoffice.org/23995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
This commit is contained in:
Noel Grandin 2016-04-11 15:29:25 +02:00 committed by Noel Grandin
parent 0a8abaadf3
commit 03fd8d24c2
22 changed files with 31 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/vcl/bitmap.hxx
View file

@ -718,7 +718,7 @@ public:
SAL_DLLPRIVATE void ImplMakeUnique();
std::shared_ptr<ImpBitmap> ImplGetImpBitmap() const { return mxImpBmp;}
SAL_DLLPRIVATE void ImplSetImpBitmap( std::shared_ptr<ImpBitmap> xImpBmp );
SAL_DLLPRIVATE void ImplSetImpBitmap( const std::shared_ptr<ImpBitmap>& xImpBmp );
SAL_DLLPRIVATE void ImplAssignWithSize( const Bitmap& rBitmap );
SAL_DLLPRIVATE void ImplAdaptBitCount(Bitmap& rNew) const;

2
include/vcl/embeddedfontshelper.hxx
View file

@ -46,7 +46,7 @@ public:
@param key key to xor the data with, from the start until the key's length (not repeated)
@param eot whether the data is compressed in Embedded OpenType format
*/
static bool addEmbeddedFont( css::uno::Reference< css::io::XInputStream > stream,
static bool addEmbeddedFont( const css::uno::Reference< css::io::XInputStream >& stream,
const OUString& fontName, const char* extra,
std::vector< unsigned char > key = std::vector< unsigned char >(), bool eot = false);

2
include/vcl/floatwin.hxx
View file

@ -131,7 +131,7 @@ public:
sal_uInt16& rArrangeIndex );
static Point ImplConvertToAbsPos(vcl::Window* pReference, const Point& rPos);
static Rectangle ImplConvertToAbsPos(vcl::Window* pReference, const Rectangle& rRect);
SAL_DLLPRIVATE void ImplEndPopupMode( FloatWinPopupEndFlags nFlags = FloatWinPopupEndFlags::NONE, VclPtr<vcl::Window> xFocusId = nullptr );
SAL_DLLPRIVATE void ImplEndPopupMode( FloatWinPopupEndFlags nFlags = FloatWinPopupEndFlags::NONE, const VclPtr<vcl::Window>& xFocusId = nullptr );
SAL_DLLPRIVATE Rectangle& ImplGetItemEdgeClipRect();
SAL_DLLPRIVATE bool ImplIsInPrivatePopupMode() const { return mbInPopupMode; }
virtual void doDeferredInit(WinBits nBits) override;

4
include/vcl/print.hxx
View file

@ -381,13 +381,13 @@ public:
static bool PreparePrintJob( std::shared_ptr<vcl::PrinterController> i_pController,
const JobSetup& i_rInitSetup );
static bool ExecutePrintJob( std::shared_ptr<vcl::PrinterController> i_pController );
static void FinishPrintJob( std::shared_ptr<vcl::PrinterController> i_pController );
static void FinishPrintJob( const std::shared_ptr<vcl::PrinterController>& i_pController );
/** Implementation detail of PrintJob being asynchronous
not exported, not usable outside vcl
*/
static void SAL_DLLPRIVATE ImplPrintJob( std::shared_ptr<vcl::PrinterController> i_pController,
static void SAL_DLLPRIVATE ImplPrintJob( const std::shared_ptr<vcl::PrinterController>& i_pController,
const JobSetup& i_rInitSetup );
};

4
include/vcl/window.hxx
View file

@ -1229,7 +1229,7 @@ public:
virtual css::uno::Reference< css::accessibility::XAccessible >
CreateAccessible();
void SetAccessible( css::uno::Reference< css::accessibility::XAccessible > );
void SetAccessible( const css::uno::Reference< css::accessibility::XAccessible >& );
vcl::Window* GetAccessibleParentWindow() const;
sal_uInt16 GetAccessibleChildWindowCount();
@ -1508,7 +1508,7 @@ public:
* Adds this widget to the xGroup VclSizeGroup
*
*/
void add_to_size_group(std::shared_ptr<VclSizeGroup> xGroup);
void add_to_size_group(const std::shared_ptr<VclSizeGroup>& xGroup);
void remove_from_all_size_groups();
/*

2
vcl/inc/unx/glyphcache.hxx
View file

@ -154,7 +154,7 @@ public:
bool TestFont() const { return mbFaceOk;}
FT_Face GetFtFace() const;
int GetLoadFlags() const { return (mnLoadFlags & ~FT_LOAD_IGNORE_TRANSFORM); }
void SetFontOptions(std::shared_ptr<FontConfigFontOptions>);
void SetFontOptions(const std::shared_ptr<FontConfigFontOptions>&);
std::shared_ptr<FontConfigFontOptions> GetFontOptions() const;
bool NeedsArtificialBold() const { return mbArtBold; }
bool NeedsArtificialItalic() const { return mbArtItalic; }

2
vcl/inc/unx/screensaverinhibitor.hxx
View file

@ -25,7 +25,7 @@ class VCL_PLUGIN_PUBLIC ScreenSaverInhibitor
{
public:
void inhibit( bool bInhibit, const rtl::OUString& sReason,
bool bIsX11, const boost::optional<unsigned int> xid, boost::optional<Display*> pDisplay );
bool bIsX11, const boost::optional<unsigned int>& xid, boost::optional<Display*> pDisplay );
private:
// These are all used as guint, however this header may be included

2
vcl/opengl/gdiimpl.cxx
View file

@ -671,7 +671,7 @@ inline void addVertex(std::vector<GLfloat>& rVertices, std::vector<GLfloat>& rEx
rExtrusionVectors.push_back(length);
}
inline void addVertexPair(std::vector<GLfloat>& rVertices, std::vector<GLfloat>& rExtrusionVectors, glm::vec2 point, glm::vec2 extrusionVector, float length)
inline void addVertexPair(std::vector<GLfloat>& rVertices, std::vector<GLfloat>& rExtrusionVectors, const glm::vec2& point, const glm::vec2& extrusionVector, float length)
{
addVertex(rVertices, rExtrusionVectors, point, -extrusionVector, -length);
addVertex(rVertices, rExtrusionVectors, point, extrusionVector, length);

2
vcl/source/gdi/bitmap.cxx
View file

@ -313,7 +313,7 @@ void Bitmap::ImplAssignWithSize( const Bitmap& rBitmap )
}
void Bitmap::ImplSetImpBitmap(std::shared_ptr<ImpBitmap> xImpBmp)
void Bitmap::ImplSetImpBitmap(const std::shared_ptr<ImpBitmap>& xImpBmp)
{
mxImpBmp = xImpBmp;
}

2
vcl/source/gdi/embeddedfontshelper.cxx
View file

@ -61,7 +61,7 @@ void EmbeddedFontsHelper::clearTemporaryFontFiles()
clearDir( path + "fromsystem/" );
}
bool EmbeddedFontsHelper::addEmbeddedFont( uno::Reference< io::XInputStream > stream, const OUString& fontName,
bool EmbeddedFontsHelper::addEmbeddedFont( const uno::Reference< io::XInputStream >& stream, const OUString& fontName,
const char* extra, std::vector< unsigned char > key, bool eot )
{
OUString fileUrl = EmbeddedFontsHelper::fileUrlForTemporaryFont( fontName, extra );

2
vcl/source/gdi/pdfwriter_impl.hxx
View file

@ -1008,7 +1008,7 @@ i12626
// helper for playMetafile
void implWriteGradient( const tools::PolyPolygon& rPolyPoly, const Gradient& rGradient,
VirtualDevice* pDummyVDev, const vcl::PDFWriter::PlayMetafileContext& );
void implWriteBitmapEx( const Point& rPoint, const Size& rSize, const BitmapEx& rBitmapEx, Graphic i_pGraphic,
void implWriteBitmapEx( const Point& rPoint, const Size& rSize, const BitmapEx& rBitmapEx, const Graphic& i_pGraphic,
VirtualDevice* pDummyVDev, const vcl::PDFWriter::PlayMetafileContext& );
// helpers for CCITT 1bit bitmap stream

2
vcl/source/gdi/pdfwriter_impl2.cxx
View file

@ -65,7 +65,7 @@ void PDFWriterImpl::implWriteGradient( const tools::PolyPolygon& i_rPolyPoly, co
m_rOuterFace.Pop();
}
void PDFWriterImpl::implWriteBitmapEx( const Point& i_rPoint, const Size& i_rSize, const BitmapEx& i_rBitmapEx, Graphic i_Graphic,
void PDFWriterImpl::implWriteBitmapEx( const Point& i_rPoint, const Size& i_rSize, const BitmapEx& i_rBitmapEx, const Graphic& i_Graphic,
VirtualDevice* i_pDummyVDev, const vcl::PDFWriter::PlayMetafileContext& i_rContext )
{
if ( !i_rBitmapEx.IsEmpty() && i_rSize.Width() && i_rSize.Height() )

4
vcl/source/gdi/print3.cxx
View file

@ -511,13 +511,13 @@ bool Printer::ExecutePrintJob(std::shared_ptr<PrinterController> xController)
return xController->getPrinter()->StartJob( aJobName, xController );
}
void Printer::FinishPrintJob(std::shared_ptr<PrinterController> xController)
void Printer::FinishPrintJob(const std::shared_ptr<PrinterController>& xController)
{
xController->resetPaperToLastConfigured();
xController->jobFinished( xController->getJobState() );
}
void Printer::ImplPrintJob(std::shared_ptr<PrinterController> xController,
void Printer::ImplPrintJob(const std::shared_ptr<PrinterController>& xController,
const JobSetup& i_rInitSetup)
{
if (PreparePrintJob(xController, i_rInitSetup))

2
vcl/source/window/accessibility.cxx
View file

@ -149,7 +149,7 @@ css::uno::Reference< css::accessibility::XAccessible > Window::CreateAccessible(
return xAcc;
}
void Window::SetAccessible( css::uno::Reference< css::accessibility::XAccessible > x )
void Window::SetAccessible( const css::uno::Reference< css::accessibility::XAccessible >& x )
{
mpWindowImpl->mxAccessible = x;
}

2
vcl/source/window/floatwin.cxx
View file

@ -766,7 +766,7 @@ void FloatingWindow::StartPopupMode( ToolBox* pBox, FloatWinPopupFlags nFlags )
StartPopupMode( aRect, nFlags );
}
void FloatingWindow::ImplEndPopupMode( FloatWinPopupEndFlags nFlags, VclPtr<vcl::Window> xFocusId )
void FloatingWindow::ImplEndPopupMode( FloatWinPopupEndFlags nFlags, const VclPtr<vcl::Window>& xFocusId )
{
if ( !mbInPopupMode )
return;

2
vcl/source/window/window2.cxx
View file

@ -1976,7 +1976,7 @@ void Window::set_non_homogeneous(bool bNonHomogeneous)
pWindowImpl->mbNonHomogeneous = bNonHomogeneous;
}
void Window::add_to_size_group(std::shared_ptr<VclSizeGroup> xGroup)
void Window::add_to_size_group(const std::shared_ptr<VclSizeGroup>& xGroup)
{
WindowImpl *pWindowImpl = mpWindowImpl->mpBorderWindow ? mpWindowImpl->mpBorderWindow->mpWindowImpl : mpWindowImpl;
//To-Do, multiple groups

2
vcl/unx/generic/glyphs/freetype_glyphcache.cxx
View file

@ -537,7 +537,7 @@ ServerFont::ServerFont( const FontSelectPattern& rFSD, FreetypeFontInfo* pFI )
mnLoadFlags |= FT_LOAD_NO_BITMAP;
}
void ServerFont::SetFontOptions(std::shared_ptr<FontConfigFontOptions> xFontOptions)
void ServerFont::SetFontOptions(const std::shared_ptr<FontConfigFontOptions>& xFontOptions)
{
mxFontOptions = xFontOptions;

6
vcl/unx/generic/window/screensaverinhibitor.cxx
View file

@ -40,7 +40,7 @@
#include <sal/log.hxx>
void ScreenSaverInhibitor::inhibit( bool bInhibit, const OUString& sReason,
bool bIsX11, const boost::optional<unsigned int> xid, boost::optional<Display*> pDisplay )
bool bIsX11, const boost::optional<unsigned int>& xid, boost::optional<Display*> pDisplay )
{
const char* appname = SalGenericSystem::getFrameClassName();
const OString aReason = OUStringToOString( sReason, RTL_TEXTENCODING_UTF8 );
@ -68,8 +68,8 @@ void ScreenSaverInhibitor::inhibit( bool bInhibit, const OUString& sReason,
#if ENABLE_DBUS
void dbusInhibit( bool bInhibit,
const gchar* service, const gchar* path, const gchar* interface,
std::function<bool( DBusGProxy*, guint&, GError*& )> fInhibit,
std::function<bool( DBusGProxy*, const guint, GError*& )> fUnInhibit,
const std::function<bool( DBusGProxy*, guint&, GError*& )>& fInhibit,
const std::function<bool( DBusGProxy*, const guint, GError*& )>& fUnInhibit,
boost::optional<guint>& rCookie )
{
if ( ( !bInhibit && ( rCookie == boost::none ) ) ||

2
vcl/unx/gtk/a11y/atkvalue.cxx
View file

@ -42,7 +42,7 @@ static css::uno::Reference<css::accessibility::XAccessibleValue>
return css::uno::Reference<css::accessibility::XAccessibleValue>();
}
static void anyToGValue( uno::Any aAny, GValue *pValue )
static void anyToGValue( const uno::Any& aAny, GValue *pValue )
{
// FIXME: expand to lots of types etc.
double aDouble=0;

6
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
View file

@ -303,19 +303,19 @@ void SAL_CALL SalGtkFilePicker::removeFilePickerListener( const uno::Reference<X
// FilePicker Event functions
void SalGtkFilePicker::impl_fileSelectionChanged( FilePickerEvent aEvent )
void SalGtkFilePicker::impl_fileSelectionChanged( const FilePickerEvent& aEvent )
{
OSL_TRACE( "file selection changed");
if (m_xListener.is()) m_xListener->fileSelectionChanged( aEvent );
}
void SalGtkFilePicker::impl_directoryChanged( FilePickerEvent aEvent )
void SalGtkFilePicker::impl_directoryChanged( const FilePickerEvent& aEvent )
{
OSL_TRACE("directory changed");
if (m_xListener.is()) m_xListener->directoryChanged( aEvent );
}
void SalGtkFilePicker::impl_controlStateChanged( FilePickerEvent aEvent )
void SalGtkFilePicker::impl_controlStateChanged( const FilePickerEvent& aEvent )
{
OSL_TRACE("control state changed");
if (m_xListener.is()) m_xListener->controlStateChanged( aEvent );

6
vcl/unx/gtk/fpicker/SalGtkFilePicker.hxx
View file

@ -172,9 +172,9 @@ class SalGtkFilePicker : public SalGtkPicker, public SalGtkFilePicker_Base
void ensureFilterList( const OUString& _rInitialCurrentFilter );
void impl_fileSelectionChanged( css::ui::dialogs::FilePickerEvent aEvent );
void impl_directoryChanged( css::ui::dialogs::FilePickerEvent aEvent );
void impl_controlStateChanged( css::ui::dialogs::FilePickerEvent aEvent );
void impl_fileSelectionChanged( const css::ui::dialogs::FilePickerEvent& aEvent );
void impl_directoryChanged( const css::ui::dialogs::FilePickerEvent& aEvent );
void impl_controlStateChanged( const css::ui::dialogs::FilePickerEvent& aEvent );
private:
css::uno::Reference< css::ui::dialogs::XFilePickerListener >

2
vcl/unx/gtk/gtksalframe.cxx
View file

@ -3833,7 +3833,7 @@ void GtkSalFrame::IMHandler::signalIMPreeditEnd( GtkIMContext*, gpointer im_hand
}
uno::Reference<accessibility::XAccessibleEditableText>
FindFocus(uno::Reference< accessibility::XAccessibleContext > xContext)
FindFocus(const uno::Reference< accessibility::XAccessibleContext >& xContext)
{
if (!xContext.is())
uno::Reference< accessibility::XAccessibleEditableText >();