tdf#42949 Fix new IWYU warnings in directories [ab]*

Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib0008b9bb095f27e5e436d6b507dc709ab7bf01a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105313 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-31 14:28:47 +01:00 · 2020-10-31 14:28:47 +01:00 · 0505a00a9b
commit 0505a00a9b
parent a129f3b20b
37 changed files with 28 additions and 38 deletions
--- a/accessibility/IwyuFilter_accessibility.yaml
+++ b/accessibility/IwyuFilter_accessibility.yaml
@ -4,3 +4,9 @@ excludelist:
    accessibility/source/standard/vclxaccessiblecombobox.cxx:
    # Needed for implicit dtor
    - vcl/window.hxx
+    accessibility/source/extended/accessibletabbar.cxx:
+    # Needed for implicit dtor
+    - com/sun/star/awt/XWindowPeer.hpp
+    accessibility/source/standard/accessiblemenucomponent.cxx:
+    # Needed for implicit dtor
+    - com/sun/star/awt/XWindowPeer.hpp
--- a/accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx
@ -21,7 +21,6 @@
 #include <extended/AccessibleBrowseBoxTableCell.hxx>
 #include <toolkit/helper/convert.hxx>
 #include <vcl/accessibletableprovider.hxx>
-#include <com/sun/star/accessibility/AccessibleEventId.hpp>
 #include <com/sun/star/accessibility/AccessibleStateType.hpp>
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>

--- a/accessibility/source/standard/vclxaccessiblebutton.cxx
+++ b/accessibility/source/standard/vclxaccessiblebutton.cxx
@ -29,7 +29,7 @@
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>
 #include <strings.hxx>

-#include <vcl/toolkit/button.hxx>
+#include <vcl/button.hxx>
 #include <vcl/event.hxx>
 #include <vcl/vclevent.hxx>

--- a/accessibility/source/standard/vclxaccessibleradiobutton.cxx
+++ b/accessibility/source/standard/vclxaccessibleradiobutton.cxx
@ -30,7 +30,7 @@
 #include <com/sun/star/accessibility/AccessibleEventId.hpp>
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>
 #include <vcl/window.hxx>
-#include <vcl/toolkit/button.hxx>
+#include <vcl/button.hxx>
 #include <vcl/event.hxx>
 #include <vcl/vclevent.hxx>
 #include <strings.hxx>
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@ -59,7 +59,6 @@
 #include <array>
 #include <vector>
 #include <algorithm>
-#include <string.h>

 namespace com::sun::star::uno { class XComponentContext; }
 namespace com::sun::star::beans { struct NamedValue; }
--- a/avmedia/source/framework/MediaControlBase.cxx
+++ b/avmedia/source/framework/MediaControlBase.cxx
@ -19,10 +19,8 @@
 #include <avmedia/MediaControlBase.hxx>
 #include <avmedia/mediaplayer.hxx>
 #include <avmedia/mediaitem.hxx>
-#include <svtools/miscopt.hxx>
 #include <tools/time.hxx>
 #include <unotools/localedatawrapper.hxx>
-#include <bitmaps.hlst>
 #include <strings.hrc>
 #include <helpids.h>
 #include <mediamisc.hxx>
--- a/avmedia/source/framework/mediacontrol.cxx
+++ b/avmedia/source/framework/mediacontrol.cxx
@ -22,13 +22,7 @@
 #include <mediamisc.hxx>
 #include <avmedia/mediawindow.hxx>
 #include <helpids.h>
-#include <vcl/svapp.hxx>
-#include <vcl/settings.hxx>
 #include <vcl/weld.hxx>
-#include <unotools/syslocale.hxx>
-#include <sfx2/viewfrm.hxx>
-#include <math.h>
-#include <algorithm>
 #include <avmedia/MediaControlBase.hxx>

 namespace avmedia
--- a/basctl/IwyuFilter_basctl.yaml
+++ b/basctl/IwyuFilter_basctl.yaml
@ -5,3 +5,6 @@ excludelist:
    # Needed for TypedWhichId defines is basslots.hxx
    - sfx2/dinfdlg.hxx
    - sfx2/minfitem.hxx
+    basctl/source/basicide/baside2b.cxx:
+    # Needed for implicit dtor
+    - com/sun/star/container/XHierarchicalNameAccess.hpp
--- a/basctl/source/basicide/ObjectCatalog.cxx
+++ b/basctl/source/basicide/ObjectCatalog.cxx
@ -24,7 +24,6 @@
 #include <helpids.h>

 #include <vcl/taskpanelist.hxx>
-#include <vcl/svapp.hxx>

 namespace basctl
 {
--- a/basctl/source/basicide/bastype2.cxx
+++ b/basctl/source/basicide/bastype2.cxx
@ -26,14 +26,12 @@
 #include <iderid.hxx>
 #include <tools/urlobj.hxx>
 #include <tools/diagnose_ex.h>
-#include <tools/debug.hxx>
 #include <svtools/imagemgr.hxx>
 #include <com/sun/star/script/XLibraryContainerPassword.hpp>
 #include <com/sun/star/frame/ModuleManager.hpp>
 #include <comphelper/processfactory.hxx>
 #include <sfx2/dispatch.hxx>
 #include <sfx2/sfxsids.hrc>
-#include <vcl/event.hxx>

 #include <initializer_list>
 #include <memory>
--- a/basctl/source/basicide/bastype3.cxx
+++ b/basctl/source/basicide/bastype3.cxx
@ -25,7 +25,6 @@
 #include <bastypes.hxx>
 #include <com/sun/star/script/XLibraryContainer.hpp>
 #include <com/sun/star/script/XLibraryContainerPassword.hpp>
-#include <deque>
 #include <string_view>
 #include <osl/diagnose.h>
 #include <tools/debug.hxx>
--- a/basctl/source/basicide/textwindowpeer.cxx
+++ b/basctl/source/basicide/textwindowpeer.cxx
@ -23,7 +23,6 @@
 #include <vcl/accessiblefactory.hxx>

 #include <com/sun/star/accessibility/XAccessibleContext.hpp>
-#include <com/sun/star/awt/XWindowPeer.hpp>
 #include <com/sun/star/uno/Reference.hxx>
 #include <toolkit/awt/vclxwindow.hxx>
 #include <vcl/texteng.hxx>
--- a/basctl/source/basicide/unomodel.hxx
+++ b/basctl/source/basicide/unomodel.hxx
@ -18,7 +18,6 @@
 */
 #pragma once

-#include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 #include <sfx2/sfxbasemodel.hxx>

--- a/basegfx/source/color/bcolormodifier.cxx
+++ b/basegfx/source/color/bcolormodifier.cxx
@ -17,7 +17,6 @@
 *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 */

-#include <config_options.h>
 #include <sal/config.h>

 #include <algorithm>
--- a/basegfx/source/numeric/ftools.cxx
+++ b/basegfx/source/numeric/ftools.cxx
@ -18,7 +18,6 @@
 */

 #include <basegfx/numeric/ftools.hxx>
-#include <algorithm>

 namespace basegfx
 {
--- a/basegfx/source/polygon/b2dpolygon.cxx
+++ b/basegfx/source/polygon/b2dpolygon.cxx
@ -25,7 +25,6 @@
 #include <basegfx/curve/b2dcubicbezier.hxx>
 #include <basegfx/polygon/b2dpolygontools.hxx>
 #include <basegfx/utils/systemdependentdata.hxx>
-#include <algorithm>
 #include <memory>
 #include <vector>

--- a/basegfx/source/polygon/b2dpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dpolypolygon.cxx
@ -22,7 +22,6 @@
 #include <basegfx/polygon/b2dpolygon.hxx>
 #include <basegfx/matrix/b2dhommatrix.hxx>
 #include <basegfx/utils/systemdependentdata.hxx>
-#include <algorithm>

 class ImplB2DPolyPolygon
 {
--- a/basegfx/source/polygon/b3dpolygon.cxx
+++ b/basegfx/source/polygon/b3dpolygon.cxx
@ -24,7 +24,7 @@
 #include <basegfx/point/b2dpoint.hxx>
 #include <basegfx/color/bcolor.hxx>
 #include <basegfx/matrix/b2dhommatrix.hxx>
-#include <rtl/math.hxx>
+#include <cassert>
 #include <vector>
 #include <algorithm>

--- a/basegfx/source/polygon/b3dpolygontools.cxx
+++ b/basegfx/source/polygon/b3dpolygontools.cxx
@ -25,7 +25,7 @@
 #include <basegfx/range/b3drange.hxx>
 #include <basegfx/point/b2dpoint.hxx>
 #include <basegfx/tuple/b3ituple.hxx>
-#include <rtl/math.hxx>
+#include <cassert>
 #include <numeric>

 namespace basegfx::utils
--- a/basegfx/source/polygon/b3dpolypolygontools.cxx
+++ b/basegfx/source/polygon/b3dpolypolygontools.cxx
@ -26,7 +26,6 @@
 #include <basegfx/numeric/ftools.hxx>
 #include <com/sun/star/drawing/DoubleSequence.hpp>
 #include <com/sun/star/drawing/PolyPolygonShape3D.hpp>
-#include <sal/log.hxx>

 // predefines
 #define nMinSegments sal_uInt32(1)
--- a/basegfx/source/range/b2drangeclipper.cxx
+++ b/basegfx/source/range/b2drangeclipper.cxx
@ -24,11 +24,11 @@
 #include <basegfx/range/b2drangeclipper.hxx>
 #include <basegfx/polygon/b2dpolypolygon.hxx>
 #include <basegfx/range/b2drectangle.hxx>
-#include <rtl/math.hxx>

 #include <o3tl/vector_pool.hxx>

 #include <algorithm>
+#include <cassert>
 #include <list>
 #include <iterator>

--- a/basic/IwyuFilter_basic.yaml
+++ b/basic/IwyuFilter_basic.yaml
@ -1,6 +1,12 @@
 ---
 assumeFilename: basic/source/classes/global.cxx
 excludelist:
+    basic/source/runtime/dllmgr.hxx:
+    # Needed on WIN
+    - memory
+    basic/qa/cppunit/test_compiler_checks.cxx:
+    # Keep for system-cppunit; see also commit 456d61ec526e250fd1af894e109d5914ac9c9e6e
+    - unotest/bootstrapfixturebase.hxx
    basic/source/runtime/methods.cxx:
    # Needed on WIN
    - o3tl/char16_t2wchar_t.hxx
--- a/basic/inc/sbobjmod.hxx
+++ b/basic/inc/sbobjmod.hxx
@ -24,7 +24,6 @@
 #include <com/sun/star/script/ModuleInfo.hpp>
 #include <com/sun/star/awt/XDialog.hpp>
 #include <com/sun/star/frame/XModel.hpp>
-#include <basic/basicdllapi.h>

 // Basic-Module for excel object.

--- a/basic/inc/sbstdobj.hxx
+++ b/basic/inc/sbstdobj.hxx
@ -22,7 +22,6 @@
 #include <basic/sbxobj.hxx>
 #include <vcl/graph.hxx>
 #include "sbxfac.hxx"
-#include <basic/basicdllapi.h>

 class SbStdFactory final : public SbxFactory
 {
--- a/basic/inc/sbxfac.hxx
+++ b/basic/inc/sbxfac.hxx
@ -20,7 +20,6 @@
 #pragma once

 #include <rtl/ustring.hxx>
-#include <basic/basicdllapi.h>

 class SbxBase;
 class SbxObject;
--- a/basic/qa/cppunit/test_language_conditionals.cxx
+++ b/basic/qa/cppunit/test_language_conditionals.cxx
@ -8,7 +8,6 @@
 */

 #include "basictest.hxx"
-#include <rtl/ustring.hxx>

 #include <cppunit/TestAssert.h>
 #include <cppunit/TestFixture.h>
--- a/basic/source/classes/sb.cxx
+++ b/basic/source/classes/sb.cxx
@ -18,6 +18,7 @@
 */

 #include <sb.hxx>
+#include <rtl/ustrbuf.hxx>
 #include <tools/stream.hxx>
 #include <tools/debug.hxx>
 #include <vcl/errinf.hxx>
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@ -33,6 +33,7 @@
 #include <cppuhelper/weakref.hxx>

 #include <rtl/instance.hxx>
+#include <rtl/math.hxx>
 #include <rtl/ustrbuf.hxx>

 #include <com/sun/star/script/ArrayWrapper.hpp>
--- a/basic/source/comp/exprnode.cxx
+++ b/basic/source/comp/exprnode.cxx
@ -18,10 +18,9 @@
 */


-#include <math.h>
+#include <cmath>

 #include <o3tl/temporary.hxx>
-#include <rtl/math.hxx>
 #include <parser.hxx>
 #include <expr.hxx>
 #include <tools/long.hxx>
--- a/basic/source/inc/runtime.hxx
+++ b/basic/source/inc/runtime.hxx
@ -27,9 +27,9 @@
 #include <rtl/ustring.hxx>
 #include <com/sun/star/uno/Sequence.hxx>
 #include <osl/file.hxx>
-#include <rtl/math.hxx>
 #include <i18nlangtag/lang.h>

+#include <cmath>
 #include <vector>
 #include <memory>
 #include <com/sun/star/lang/XComponent.hpp>
--- a/basic/source/inc/sbintern.hxx
+++ b/basic/source/inc/sbintern.hxx
@ -19,7 +19,6 @@

 #pragma once

-#include <basic/basicdllapi.h>
 #include <basic/sbstar.hxx>
 #include <sbxfac.hxx>
 #include <unotools/transliterationwrapper.hxx>
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@ -25,6 +25,7 @@
 #include <cstddef>

 #include <stdlib.h>
+#include <rtl/math.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/mapmod.hxx>
 #include <vcl/outdev.hxx>
--- a/basic/source/runtime/stdobj1.cxx
+++ b/basic/source/runtime/stdobj1.cxx
@ -20,7 +20,6 @@
 #include <basic/sberrors.hxx>
 #include <basic/sbstar.hxx>
 #include <vcl/outdev.hxx>
-#include <vcl/svapp.hxx>
 #include <sbstdobj.hxx>

 #define ATTR_IMP_TYPE           1
--- a/basic/source/sbx/sbxdate.cxx
+++ b/basic/source/sbx/sbxdate.cxx
@ -17,6 +17,7 @@
 *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 */

+#include <rtl/math.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/settings.hxx>
 #include <svl/zforlist.hxx>
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@ -44,7 +44,7 @@
 #include <strings.hrc>

 #include <rtl/character.hxx>
-#include <sal/log.hxx>
+#include <rtl/math.hxx>
 #include <svl/zforlist.hxx>


--- a/basic/source/sbx/sbxvar.cxx
+++ b/basic/source/sbx/sbxvar.cxx
@ -28,6 +28,7 @@
 #include "sbxconv.hxx"
 #include <sbunoobj.hxx>
 #include <rtl/character.hxx>
+#include <rtl/ustrbuf.hxx>
 #include <sal/log.hxx>

 #include <com/sun/star/uno/XInterface.hpp>
--- a/binaryurp/source/bridgefactory.cxx
+++ b/binaryurp/source/bridgefactory.cxx
@ -30,8 +30,6 @@
 #include <com/sun/star/uno/RuntimeException.hpp>
 #include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/uno/XInterface.hpp>
-#include <cppuhelper/factory.hxx>
-#include <cppuhelper/implementationentry.hxx>
 #include <cppuhelper/supportsservice.hxx>
 #include <o3tl/safeint.hxx>
 #include <rtl/ref.hxx>