strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

loplugin:datamembershadow in XFCellStyle

Browse source 
looks like the subclass member is never written to, so I'm going to
assume this was a bug

Change-Id: Ic56c4a30cd139415eb08c4d572273dad2411b514
Reviewed-on: https://gerrit.libreoffice.org/49001
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2018-01-31 16:13:48 +02:00
parent a0c2d1be6a
commit 0913b2af7d
3 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
compilerplugins/clang/datamembershadow.cxx
View file

@ -63,8 +63,6 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl)
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/framework/source/uielement/popuptoolbarcontroller.cxx"))
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/lotuswordpro/inc/xfilter/xfcellstyle.hxx"))
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/sc/source/ui/vba/vbastyles.hxx"))
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/sd/inc/Outliner.hxx"))

1
lotuswordpro/inc/xfilter/xfcellstyle.hxx
View file

@ -134,7 +134,6 @@ public:
private:
OUString m_strDataStyle;
OUString m_strParentStyleName;
enumXFAlignType m_eHoriAlign;
enumXFAlignType m_eVertAlign;

2
lotuswordpro/source/filter/xfilter/xfparastyle.cxx
View file

@ -103,8 +103,6 @@ XFParaStyle::XFParaStyle(const XFParaStyle& other)
, m_nFlag(other.m_nFlag)
, m_bNumberRight(other.m_bNumberRight)
{
m_strParentStyleName = other.m_strParentStyleName;
if( other.m_pBorders )
m_pBorders = new XFBorders(*other.m_pBorders);
else