tdf#163486: PVS: The 'eAggFunc' variable was assigned the same value

V1048 The 'eAggFunc' variable was assigned the same value. Will be assigned after the switch.

Change-Id: I21d4cb4b0e7427bea56598476ca176cc0a4f7124
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175902
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
This commit is contained in:
Bogdan Buzea 2024-10-31 21:22:46 +02:00 committed by Eike Rathke
parent 26b24e181c
commit 0a7b9ba8a4

View file

@ -608,7 +608,7 @@ void PivotTableField::convertDataField( const PTDataFieldModel& rDataField )
means 'count all', and 'countNum' means 'count numbers'. On the
other hand, for subtotals, 'countA' means 'count all', and 'count'
means 'count numbers' (see above). */
GeneralFunction eAggFunc = GeneralFunction_SUM;
GeneralFunction eAggFunc;
switch( rDataField.mnSubtotal )
{
case XML_sum: eAggFunc = GeneralFunction_SUM; break;
@ -622,7 +622,10 @@ void PivotTableField::convertDataField( const PTDataFieldModel& rDataField )
case XML_stdDevp: eAggFunc = GeneralFunction_STDEVP; break;
case XML_var: eAggFunc = GeneralFunction_VAR; break;
case XML_varp: eAggFunc = GeneralFunction_VARP; break;
default: OSL_FAIL( "PivotTableField::convertDataField - unknown aggregation function" );
default:
OSL_FAIL( "PivotTableField::convertDataField - unknown aggregation function" );
eAggFunc = GeneralFunction_SUM;
break;
}
aPropSet.setProperty( PROP_Function, eAggFunc );