strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clang-tidy modernize-pass-by-value in libreofficekit

Browse source 
Change-Id: I1a6b4eb804a8cc4eb5e67ae4bbf8f31863f323d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136273
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2022-06-22 09:11:15 +02:00
parent 07295115f5
commit 154cffd87e
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx
View file

@ -16,6 +16,7 @@
#include <boost/property_tree/ptree.hpp>
#include <o3tl/unreachable.hxx>
#include <utility>
namespace {
@ -26,9 +27,9 @@ struct GtvCalcHeaderBarPrivateImpl
{
int m_nSize;
std::string m_aText;
Header(int nSize, const std::string& rText)
Header(int nSize, std::string aText)
: m_nSize(nSize),
m_aText(rText)
m_aText(std::move(aText))
{ }
};

5
libreofficekit/source/gtk/lokdocview.cxx
View file

@ -11,6 +11,7 @@
#include <math.h>
#include <string.h>
#include <memory>
#include <utility>
#include <vector>
#include <string>
#include <sstream>
@ -358,9 +359,9 @@ struct CallbackData
std::string m_aPayload;
LOKDocView* m_pDocView;
CallbackData(int nType, const std::string& rPayload, LOKDocView* pDocView)
CallbackData(int nType, std::string aPayload, LOKDocView* pDocView)
: m_nType(nType),
m_aPayload(rPayload),
m_aPayload(std::move(aPayload)),
m_pDocView(pDocView) {}
};