strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xmloff: ODF export: if there's no checksum, don't generate chaff

Browse source 
Change-Id: I2e1bb6ed33df327ebd797edeca7ee82b75c524b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161800
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
This commit is contained in:
Michael Stahl 2024-01-08 19:44:50 +01:00
parent e1abdcef44
commit 2184692bbe
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
xmloff/source/core/xmlexp.cxx
View file

@ -95,7 +95,7 @@
#include <com/sun/star/document/XDocumentProperties.hpp>
#include <com/sun/star/document/XDocumentPropertiesSupplier.hpp>
#include <com/sun/star/document/XMLOasisBasicExporter.hpp>
#include <com/sun/star/embed/XEncryptionProtectedSource2.hpp>
#include <com/sun/star/embed/XEncryptionProtectedStorage.hpp>
#include <com/sun/star/document/XGraphicStorageHandler.hpp>
#include <com/sun/star/rdf/XMetadatable.hpp>
#include <RDFaExportHelper.hxx>
@ -1188,10 +1188,22 @@ lcl_AddGrddl(SvXMLExport const & rExport, const SvXMLExportFlags /*nExportMode*/
// note: the point of this is presumably to mitigate SHA/1k info leak of plain text
void SvXMLExport::addChaffWhenEncryptedStorage()
{
uno::Reference< embed::XEncryptionProtectedSource2 > xEncr(mpImpl->mxTargetStorage, uno::UNO_QUERY);
uno::Reference<embed::XEncryptionProtectedStorage> const xEncr(mpImpl->mxTargetStorage, uno::UNO_QUERY);
if (xEncr.is() && xEncr->hasEncryptionData() && mxExtHandler.is())
{
uno::Sequence<beans::NamedValue> const algo(xEncr->getEncryptionAlgorithms());
for (auto const& it : algo)
{
if (it.Name == "ChecksumAlgorithm")
{
if (!it.Value.hasValue())
{
return; // no checksum => no chaff
}
break;
}
}
mxExtHandler->comment(OStringToOUString(comphelper::xml::makeXMLChaff(), RTL_TEXTENCODING_ASCII_US));
}
}