strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

run CppunitTest_chart2_xshape without ENABLE_CHART_TESTS

Browse source 
This was added in d8ae59e097
"add concept for chart xshape tests" and it's only run
when using --enable-chart-tests
OTOH, SdImportTest::testDocumentLayout in sd/qa/unit/import-tests.cxx
also uses doXMLDiff to compare shapes and it's run without any
special flag.
Let's remove the ENABLE_CHART_TESTS check to see if jenkins or any
tinderbox fails. If it does, we can always revert this commit.
If it works fine, I'll remove the --enable-chart-tests machinery
in a follow-up commit in some days

Change-Id: I5d462df09303701826e5849e9e3bacca465da814
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136796
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This commit is contained in:
Xisco Fauli 2022-07-04 11:42:22 +02:00
parent 0203485a7f
commit 268f0f3f0d
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
chart2/Module_chart2.mk
View file

@ -38,13 +38,11 @@ $(eval $(call gb_Module_add_slowcheck_targets,chart2,\
CppunitTest_chart2_geometry \
))
ifeq ($(ENABLE_CHART_TESTS),TRUE)
ifeq ($(WITH_FONTS), TRUE)
$(eval $(call gb_Module_add_slowcheck_targets,chart2,\
CppunitTest_chart2_xshape \
))
endif
endif
$(eval $(call gb_Module_add_subsequentcheck_targets,chart2,\
JunitTest_chart2_unoapi \