strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#163486: PVS: Identical branches

Browse source 
V1037 Two or more case-branches perform the same actions. Check lines: 544, 552
V1037 Two or more case-branches perform the same actions. Check lines: 923, 929
V1037 Two or more case-branches perform the same actions. Check lines: 993, 1001

Change-Id: I373ccdb56bee8d446e2aec3295ba9c0fb23ff82a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175229
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
This commit is contained in:
Bogdan Buzea 2024-10-19 19:40:52 +02:00 committed by David Gilbert
parent fa1902c464
commit 27805424cc
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
oox/source/ppt/timenodelistcontext.cxx
View file

@ -540,12 +540,10 @@ namespace oox::ppt {
sal_Int16 nEnum = 0; sal_Int16 nEnum = 0;
switch(nCalcMode) switch(nCalcMode)
{ {
case XML_discrete:
nEnum = AnimationCalcMode::DISCRETE;
break;
case XML_lin: case XML_lin:
nEnum = AnimationCalcMode::LINEAR; nEnum = AnimationCalcMode::LINEAR;
break; break;
case XML_discrete:
case XML_fmla: case XML_fmla:
default: default:
// TODO what value is good ? // TODO what value is good ?
@ -919,12 +917,10 @@ namespace oox::ppt {
case PPT_TOKEN( animClr ): case PPT_TOKEN( animClr ):
pCtx = new AnimColorContext( rParent, aElement, xAttribs, pNode ); pCtx = new AnimColorContext( rParent, aElement, xAttribs, pNode );
break; break;
case PPT_TOKEN( par ):
pCtx = new ParallelExclTimeNodeContext( rParent, aElement, pNode );
break;
case PPT_TOKEN( seq ): case PPT_TOKEN( seq ):
pCtx = new SequenceTimeNodeContext( rParent, aElement, xAttribs, pNode ); pCtx = new SequenceTimeNodeContext( rParent, aElement, xAttribs, pNode );
break; break;
case PPT_TOKEN( par ):
case PPT_TOKEN( excl ): case PPT_TOKEN( excl ):
pCtx = new ParallelExclTimeNodeContext( rParent, aElement, pNode ); pCtx = new ParallelExclTimeNodeContext( rParent, aElement, pNode );
break; break;
@ -989,12 +985,10 @@ namespace oox::ppt {
switch( aElementToken ) switch( aElementToken )
{ {
case PPT_TOKEN( par ):
nNodeType = AnimationNodeType::PAR;
break;
case PPT_TOKEN( seq ): case PPT_TOKEN( seq ):
nNodeType = AnimationNodeType::SEQ; nNodeType = AnimationNodeType::SEQ;
break; break;
case PPT_TOKEN( par ):
case PPT_TOKEN( excl ): case PPT_TOKEN( excl ):
// TODO pick the right type. We choose parallel for now as // TODO pick the right type. We choose parallel for now as
// there does not seem to be an "Exclusive" // there does not seem to be an "Exclusive"