clang-tidy: performance-unnecessary-copy-initialization in various
Change-Id: Ib7d75d4d8207261898568402e7983e0f11da14bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
parent
61d7bd4cd2
commit
2cb43c6b88
4 changed files with 5 additions and 6 deletions
|
@ -89,7 +89,7 @@ javaFrameworkError jfw_findAllJREs(std::vector<std::unique_ptr<JavaInfo>> *pparI
|
|||
//get the list of paths to jre locations which have been
|
||||
//added manually
|
||||
const jfw::MergedSettings settings;
|
||||
const std::vector<OUString> vecJRELocations =
|
||||
const std::vector<OUString>& vecJRELocations =
|
||||
settings.getJRELocations();
|
||||
//Check if any plugin can detect JREs at the location
|
||||
// of the paths added by jfw_addJRELocation
|
||||
|
@ -230,7 +230,7 @@ javaFrameworkError jfw_startVM(
|
|||
|
||||
vmParams = settings.getVmParametersUtf8();
|
||||
// Expand user classpath (might contain bootstrap vars)
|
||||
OUString sUserPath(settings.getUserClassPath());
|
||||
const OUString& sUserPath(settings.getUserClassPath());
|
||||
std::vector paths = jfw_convertUserPathList(sUserPath);
|
||||
OUString sUserPathExpanded;
|
||||
for (auto& path : paths)
|
||||
|
|
|
@ -1138,8 +1138,7 @@ void GrammarCheckingIterator::GetConfiguredGCSvcs_Impl()
|
|||
if (aImplNames.hasElements())
|
||||
{
|
||||
// only the first entry is used, there should be only one grammar checker per language
|
||||
const OUString aImplName( aImplNames[0] );
|
||||
aTmpGCImplNamesByLang[rElementName] = aImplName;
|
||||
aTmpGCImplNamesByLang[rElementName] = aImplNames[0];
|
||||
}
|
||||
}
|
||||
else
|
||||
|
|
|
@ -363,7 +363,7 @@ void LwpFribField::RegisterStyle(LwpFoundry* pFoundry)
|
|||
|
||||
void LwpFribField::RegisterTimeField(const LwpFieldMark* pFieldMark)
|
||||
{
|
||||
OUString sFormula
|
||||
const OUString& sFormula
|
||||
= pFieldMark->GetFormula(); //now bookmark maybe not all register to bookmarkmgr,
|
||||
if (sFormula == "TotalEditingTime") //so check field type now is not correct.
|
||||
RegisterTotalTimeStyle();
|
||||
|
|
|
@ -238,7 +238,7 @@ static PyObject* getComponentContext(
|
|||
Reference<XComponentContext> ctx;
|
||||
|
||||
// getLibDir() must be called in order to set bootstrap variables correctly !
|
||||
OUString path( getLibDir());
|
||||
const OUString& path( getLibDir());
|
||||
if( Runtime::isInitialized() )
|
||||
{
|
||||
Runtime runtime;
|
||||
|
|
Loading…
Reference in a new issue