strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WaE: use of logical '&&' with constant operand

Browse source 
Surely it's the bitwise operator & that is wanted here. The code makes
no sense otherwise. We apparently have been generating UUIDs where
every second hex digit is always a '1', like
{x1x1x1x1-x1x1-x1x1-x1x1-x1x1x1x1x1x1} (where each x is a random hex
digit).
This commit is contained in:
Tor Lillqvist 2012-03-03 00:05:55 +02:00
parent b43bdd47fe
commit 30313007a8
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
oox/source/export/drawingml.cxx
View file

@ -906,27 +906,27 @@ void DrawingML::GetUUID( OStringBuffer& rBuffer )
rBuffer.append( '{' ); rBuffer.append( '{' );
for( i = 0; i < 4; i++ ) { for( i = 0; i < 4; i++ ) {
rBuffer.append( cDigits[ aSeq[i] >> 4 ] ); rBuffer.append( cDigits[ aSeq[i] >> 4 ] );
rBuffer.append( cDigits[ aSeq[i] && 0xf ] ); rBuffer.append( cDigits[ aSeq[i] & 0xf ] );
} }
rBuffer.append( '-' ); rBuffer.append( '-' );
for( ; i < 6; i++ ) { for( ; i < 6; i++ ) {
rBuffer.append( cDigits[ aSeq[i] >> 4 ] ); rBuffer.append( cDigits[ aSeq[i] >> 4 ] );
rBuffer.append( cDigits[ aSeq[i] && 0xf ] ); rBuffer.append( cDigits[ aSeq[i] & 0xf ] );
} }
rBuffer.append( '-' ); rBuffer.append( '-' );
for( ; i < 8; i++ ) { for( ; i < 8; i++ ) {
rBuffer.append( cDigits[ aSeq[i] >> 4 ] ); rBuffer.append( cDigits[ aSeq[i] >> 4 ] );
rBuffer.append( cDigits[ aSeq[i] && 0xf ] ); rBuffer.append( cDigits[ aSeq[i] & 0xf ] );
} }
rBuffer.append( '-' ); rBuffer.append( '-' );
for( ; i < 10; i++ ) { for( ; i < 10; i++ ) {
rBuffer.append( cDigits[ aSeq[i] >> 4 ] ); rBuffer.append( cDigits[ aSeq[i] >> 4 ] );
rBuffer.append( cDigits[ aSeq[i] && 0xf ] ); rBuffer.append( cDigits[ aSeq[i] & 0xf ] );
} }
rBuffer.append( '-' ); rBuffer.append( '-' );
for( ; i < 16; i++ ) { for( ; i < 16; i++ ) {
rBuffer.append( cDigits[ aSeq[i] >> 4 ] ); rBuffer.append( cDigits[ aSeq[i] >> 4 ] );
rBuffer.append( cDigits[ aSeq[i] && 0xf ] ); rBuffer.append( cDigits[ aSeq[i] & 0xf ] );
} }
rBuffer.append( '}' ); rBuffer.append( '}' );
} }