strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

don't bother passing const std::[u16]string_view by reference

Browse source 
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara 2024-12-03 11:07:23 +00:00
parent 63594c6202
commit 3e6ad944ac
17 changed files with 30 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cui/source/options/optcolor.cxx
View file

@ -278,9 +278,9 @@ private:
void SetLinks(Link<weld::Toggleable&,void> const&,
Link<ColorListBox&,void> const&,
Link<weld::Widget&,void> const&);
void Update (ColorConfigValue const&, const std::u16string_view&,
void Update (ColorConfigValue const&, std::u16string_view,
css::uno::Reference<css::configuration::XReadWriteAccess> const&);
void Update (ExtendedColorConfigValue const&, const std::u16string_view&,
void Update (ExtendedColorConfigValue const&, std::u16string_view,
css::uno::Reference<css::configuration::XReadWriteAccess> const&);
void ColorChanged (ColorConfigValue&);
void ColorChanged (ExtendedColorConfigValue&);
@ -387,7 +387,7 @@ void ColorConfigWindow_Impl::Entry::SetLinks(Link<weld::Toggleable&,void> const&
}
// updates a default color config entry
void ColorConfigWindow_Impl::Entry::Update(ColorConfigValue const& rValue, const std::u16string_view& rConfigPath,
void ColorConfigWindow_Impl::Entry::Update(ColorConfigValue const& rValue, std::u16string_view rConfigPath,
css::uno::Reference<css::configuration::XReadWriteAccess> const& xReadWriteAccess)
{
Color aColor(rValue.nColor);
@ -418,7 +418,7 @@ void ColorConfigWindow_Impl::Entry::Update(ColorConfigValue const& rValue, const
}
// updates an extended color config entry
void ColorConfigWindow_Impl::Entry::Update(ExtendedColorConfigValue const& rValue, const std::u16string_view& rConfigPath,
void ColorConfigWindow_Impl::Entry::Update(ExtendedColorConfigValue const& rValue, std::u16string_view rConfigPath,
css::uno::Reference<css::configuration::XReadWriteAccess> const& xReadWriteAccess)
{
Color aColor(rValue.getColor());

4
desktop/source/app/updater.cxx
View file

@ -403,9 +403,9 @@ public:
}
};
OUString toOUString(const std::string_view& rStr)
OUString toOUString(std::string_view str)
{
return OUString::fromUtf8(rStr);
return OUString::fromUtf8(str);
}
update_file parse_update_file(orcus::json::node& rNode)

2
filter/source/pdf/pdfexport.cxx
View file

@ -361,7 +361,7 @@ static OUString getMimetypeForDocument( const Reference< XComponentContext >& xC
}
uno::Reference<security::XCertificate>
PDFExport::GetCertificateFromSubjectName(const std::u16string_view& rSubjectName) const
PDFExport::GetCertificateFromSubjectName(std::u16string_view rSubjectName) const
{
uno::Reference<xml::crypto::XSEInitializer> xSEInitializer
= xml::crypto::SEInitializer::create(mxContext);

2
filter/source/pdf/pdfexport.hxx
View file

@ -66,7 +66,7 @@ private:
void ImplWriteWatermark( vcl::PDFWriter& rWriter, const Size& rPageSize );
void ImplWriteTiledWatermark( vcl::PDFWriter& rWriter, const Size& rPageSize );
css::uno::Reference<css::security::XCertificate> GetCertificateFromSubjectName(const std::u16string_view& rSubjectName) const;
css::uno::Reference<css::security::XCertificate> GetCertificateFromSubjectName(std::u16string_view rSubjectName) const;
public:

2
include/vbahelper/vbahelper.hxx
View file

@ -131,7 +131,7 @@ namespace ooo::vba
VBAHELPER_DLLPUBLIC bool setPropertyValue( css::uno::Sequence< css::beans::PropertyValue >& aProp, const OUString& aName, const css::uno::Any& aValue );
VBAHELPER_DLLPUBLIC void setOrAppendPropertyValue( css::uno::Sequence< css::beans::PropertyValue >& aProp, const OUString& aName, const css::uno::Any& aValue );
VBAHELPER_DLLPUBLIC bool executeRunTimeLibrary(const std::u16string_view& rSbRtl_command,
VBAHELPER_DLLPUBLIC bool executeRunTimeLibrary(std::u16string_view rSbRtl_command,
SbxArray* pParameters);
class VBAHELPER_DLLPUBLIC Millimeter

2
include/vcl/themecolors.hxx
View file

@ -23,7 +23,7 @@ public:
static bool IsThemeLoaded() { return m_bIsThemeLoaded; }
static void SetThemeLoaded(bool bLoaded) { m_bIsThemeLoaded = bLoaded; }
static bool IsAutomaticTheme(const std::u16string_view& rThemeName)
static bool IsAutomaticTheme(std::u16string_view rThemeName)
{
return rThemeName == svtools::AUTOMATIC_COLOR_SCHEME;
}

2
sc/inc/compiler.hxx
View file

@ -331,7 +331,7 @@ private:
bool NextNewToken(bool bInArray);
bool ToUpperAsciiOrI18nIsAscii( OUString& rUpper, const OUString& rOrg ) const;
short GetPossibleParaCount( const std::u16string_view& rLambdaFormula ) const;
short GetPossibleParaCount( std::u16string_view rLambdaFormula ) const;
virtual void SetError(FormulaError nError) override;

6
sc/qa/unit/helper/qahelper.cxx
View file

@ -290,7 +290,7 @@ void ScModelTestBase::goToCell(const OUString& rCell)
dispatchCommand(mxComponent, u".uno:GoToCell"_ustr, aArgs);
}
void ScModelTestBase::typeString(const std::u16string_view& rStr)
void ScModelTestBase::typeString(std::u16string_view rStr)
{
ScModelObj* pModelObj = comphelper::getFromUnoTunnel<ScModelObj>(mxComponent);
for (const char16_t c : rStr)
@ -301,7 +301,7 @@ void ScModelTestBase::typeString(const std::u16string_view& rStr)
}
}
void ScModelTestBase::insertStringToCell(const OUString& rCell, const std::u16string_view& rStr)
void ScModelTestBase::insertStringToCell(const OUString& rCell, std::u16string_view rStr)
{
goToCell(rCell);
@ -313,7 +313,7 @@ void ScModelTestBase::insertStringToCell(const OUString& rCell, const std::u16st
Scheduler::ProcessEventsToIdle();
}
void ScModelTestBase::insertArrayToCell(const OUString& rCell, const std::u16string_view& rStr)
void ScModelTestBase::insertArrayToCell(const OUString& rCell, std::u16string_view rStr)
{
goToCell(rCell);

6
sc/qa/unit/helper/qahelper.hxx
View file

@ -179,9 +179,9 @@ public:
void testFormats(ScDocument* pDoc,std::u16string_view sFormat);
void goToCell(const OUString& rCell);
void typeString(const std::u16string_view& rStr);
void insertStringToCell(const OUString& rCell, const std::u16string_view& rStr);
void insertArrayToCell(const OUString& rCell, const std::u16string_view& rStr);
void typeString(std::u16string_view rStr);
void insertStringToCell(const OUString& rCell, std::u16string_view rStr);
void insertArrayToCell(const OUString& rCell, std::u16string_view rStr);
void insertNewSheet(ScDocument& rDoc);
void executeAutoSum();

2
sc/source/core/tool/compiler.cxx
View file

@ -4412,7 +4412,7 @@ bool ScCompiler::ToUpperAsciiOrI18nIsAscii( OUString& rUpper, const OUString& rO
}
}
short ScCompiler::GetPossibleParaCount( const std::u16string_view& rLambdaFormula ) const
short ScCompiler::GetPossibleParaCount( std::u16string_view rLambdaFormula ) const
{
sal_Unicode cSep = mxSymbols->getSymbolChar(ocSep);
sal_Unicode cOpen = mxSymbols->getSymbolChar(ocOpen);

9
sd/qa/unit/uiimpress.cxx
View file

@ -72,9 +72,9 @@ public:
}
void checkCurrentPageNumber(sal_uInt16 nNum);
void typeString(SdXImpressDocument* rImpressDocument, const std::u16string_view& rStr);
void typeString(SdXImpressDocument* rImpressDocument, std::u16string_view rStr);
void typeKey(SdXImpressDocument* rImpressDocument, const sal_uInt16 nKey);
void insertStringToObject(sal_uInt16 nObj, const std::u16string_view& rStr, bool bUseEscape);
void insertStringToObject(sal_uInt16 nObj, std::u16string_view rStr, bool bUseEscape);
sd::slidesorter::SlideSorterViewShell* getSlideSorterViewShell();
void lcl_search(const OUString& rKey, bool bFindAll = false, bool bBackwards = false);
};
@ -98,8 +98,7 @@ void SdUiImpressTest::typeKey(SdXImpressDocument* rImpressDocument, const sal_uI
Scheduler::ProcessEventsToIdle();
}
void SdUiImpressTest::typeString(SdXImpressDocument* rImpressDocument,
const std::u16string_view& rStr)
void SdUiImpressTest::typeString(SdXImpressDocument* rImpressDocument, std::u16string_view rStr)
{
for (const char16_t c : rStr)
{
@ -109,7 +108,7 @@ void SdUiImpressTest::typeString(SdXImpressDocument* rImpressDocument,
}
}
void SdUiImpressTest::insertStringToObject(sal_uInt16 nObj, const std::u16string_view& rStr,
void SdUiImpressTest::insertStringToObject(sal_uInt16 nObj, std::u16string_view rStr,
bool bUseEscape)
{
auto pImpressDocument = dynamic_cast<SdXImpressDocument*>(mxComponent.get());

2
sw/qa/inc/swmodeltestbase.hxx
View file

@ -251,7 +251,7 @@ protected:
*/
xmlDocUniquePtr WrapReqifFromTempFile();
void emulateTyping(const std::u16string_view& rStr);
void emulateTyping(std::u16string_view rStr);
private:
void loadURL(OUString const& rURL, const char* pPassword = nullptr);

2
sw/qa/unit/swmodeltestbase.cxx
View file

@ -488,7 +488,7 @@ xmlDocUniquePtr SwModelTestBase::WrapReqifFromTempFile()
return pXmlDoc;
}
void SwModelTestBase::emulateTyping(const std::u16string_view& rStr)
void SwModelTestBase::emulateTyping(std::u16string_view rStr)
{
SwXTextDocument* pTextDoc = getSwTextDoc();
for (const char16_t c : rStr)

2
test/source/a11y/accessibletestbase.cxx
View file

@ -530,7 +530,7 @@ test::AccessibleTestBase::awaitDialog(const std::u16string_view name,
maIdleHandler.Stop();
}
ListenerHelper(const std::u16string_view& name, std::function<void(Dialog&)> callback,
ListenerHelper(std::u16string_view name, std::function<void(Dialog&)> callback,
bool bAutoClose)
: mbWaitingForDialog(true)
, msName(name)

2
vbahelper/source/vbahelper/vbahelper.cxx
View file

@ -747,7 +747,7 @@ void setOrAppendPropertyValue( uno::Sequence< beans::PropertyValue >& aProp, con
pProp[ nLength ].Value = aValue;
}
bool executeRunTimeLibrary(const std::u16string_view& rSbRtl_command, SbxArray* pParameters)
bool executeRunTimeLibrary(std::u16string_view rSbRtl_command, SbxArray* pParameters)
{
StarBASIC* pBasic = dynamic_cast< StarBASIC* >(StarBASIC::GetActiveModule()->GetParent());
if (!pBasic)

2
xmloff/source/draw/shapeexport.cxx
View file

@ -3411,7 +3411,7 @@ lcl_StoreMediaAndGetURL(SvXMLExport & rExport,
namespace
{
void ExportGraphicPreview(const uno::Reference<graphic::XGraphic>& xGraphic, SvXMLExport& rExport, const std::u16string_view& rPrefix, const std::u16string_view& rExtension, const OUString& rMimeType)
void ExportGraphicPreview(const uno::Reference<graphic::XGraphic>& xGraphic, SvXMLExport& rExport, std::u16string_view rPrefix, std::u16string_view rExtension, const OUString& rMimeType)
{
const bool bExportEmbedded(rExport.getExportFlags() & SvXMLExportFlags::EMBEDDED);

7
xmlsecurity/source/helper/ooxmlsecexporter.cxx
View file

@ -94,10 +94,9 @@ bool OOXMLSecExporter::Impl::isOOXMLDenylist(std::u16string_view rStreamName)
// Don't attempt to sign other signatures for now.
u"/_xmlsignatures" };
// Just check the prefix, as we don't care about the content type part of the stream name.
return std::any_of(vDenylist.begin(), vDenylist.end(),
[&](const std::u16string_view& rLiteral) {
return o3tl::starts_with(rStreamName, rLiteral);
});
return std::any_of(vDenylist.begin(), vDenylist.end(), [&](std::u16string_view rLiteral) {
return o3tl::starts_with(rStreamName, rLiteral);
});
}
bool OOXMLSecExporter::Impl::isOOXMLRelationDenylist(const OUString& rRelationName)