From 412a775d0ab90cd963216c40e9ae1189179809ba Mon Sep 17 00:00:00 2001 From: Aditya Sahu Date: Fri, 1 Nov 2024 11:32:53 -0400 Subject: [PATCH] tdf#145161: Change pdf and image compression dialog string Since image/pdf compression does not always reduce image or pdf resolution, change the misleading label from "reduce" to "change" wherever possible. Keep identifiers having "reduce" in their name as is as of now, only change the string values containing "reduce" to "change". Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas --- filter/source/pdf/impdialog.cxx | 2 +- filter/uiconfig/ui/pdfgeneralpage.ui | 12 ++++++------ sc/qa/uitest/calc_tests4/exportToPDF.py | 2 +- sd/qa/uitest/impress_tests/exportToPDF.py | 2 +- svx/source/dialog/compressgraphicdialog.cxx | 2 +- svx/uiconfig/ui/compressgraphicdialog.ui | 4 ++-- sw/qa/uitest/writer_tests4/exportToPDF.py | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx index 547f9526338e..3d86c3acabb4 100644 --- a/filter/source/pdf/impdialog.cxx +++ b/filter/source/pdf/impdialog.cxx @@ -550,7 +550,7 @@ ImpPDFTabGeneralPage::ImpPDFTabGeneralPage(weld::Container* pPage, weld::DialogC , mxRbJPEGCompression(m_xBuilder->weld_radio_button(u"jpegcompress"_ustr)) , mxQualityFrame(m_xBuilder->weld_widget(u"qualityframe"_ustr)) , mxNfQuality(m_xBuilder->weld_metric_spin_button(u"quality"_ustr, FieldUnit::PERCENT)) - , mxCbReduceImageResolution(m_xBuilder->weld_check_button(u"reduceresolution"_ustr)) + , mxCbReduceImageResolution(m_xBuilder->weld_check_button(u"changeresolution"_ustr)) , mxCoReduceImageResolution(m_xBuilder->weld_combo_box(u"resolution"_ustr)) , mxCbPDFA(m_xBuilder->weld_check_button(u"pdfa"_ustr)) , mxCbPDFUA(m_xBuilder->weld_check_button(u"pdfua"_ustr)) diff --git a/filter/uiconfig/ui/pdfgeneralpage.ui b/filter/uiconfig/ui/pdfgeneralpage.ui index f09113793d07..ef6d9767b06b 100644 --- a/filter/uiconfig/ui/pdfgeneralpage.ui +++ b/filter/uiconfig/ui/pdfgeneralpage.ui @@ -275,8 +275,8 @@ - - Reduce ima_ge resolution to: + + Change ima_ge resolution to: True True False @@ -287,8 +287,8 @@ - - Select to resample or down-size the images to a lower number of pixels per inch. + + Select to resample or down-size the images to a lower number of pixels per inch. @@ -318,7 +318,7 @@ - + @@ -1091,7 +1091,7 @@ - + diff --git a/sc/qa/uitest/calc_tests4/exportToPDF.py b/sc/qa/uitest/calc_tests4/exportToPDF.py index a2cd0e55a451..35e96a044df6 100644 --- a/sc/qa/uitest/calc_tests4/exportToPDF.py +++ b/sc/qa/uitest/calc_tests4/exportToPDF.py @@ -35,7 +35,7 @@ class exportToPDF(UITestCase): with self.ui_test.execute_dialog_through_command('.uno:ExportToPDF', close_button="") as xDialog: selectedChildren = ['bookmarks', 'display', 'effects', 'enablea11y', - 'enablecopy', 'exporturl', 'reduceresolution', 'tagged'] + 'enablecopy', 'exporturl', 'changeresolution', 'tagged'] for child in selectedChildren: self.assertEqual("true", get_state_as_dict(xDialog.getChild(child))['Selected']) diff --git a/sd/qa/uitest/impress_tests/exportToPDF.py b/sd/qa/uitest/impress_tests/exportToPDF.py index 6cf6a63e1da0..b9cdc9934faf 100644 --- a/sd/qa/uitest/impress_tests/exportToPDF.py +++ b/sd/qa/uitest/impress_tests/exportToPDF.py @@ -37,7 +37,7 @@ class exportToPDF(UITestCase): with self.ui_test.execute_dialog_through_command('.uno:ExportToPDF', close_button="") as xDialog: selectedChildren = ['bookmarks', 'display', 'effects', 'enablea11y', - 'enablecopy', 'exporturl', 'reduceresolution', 'tagged'] + 'enablecopy', 'exporturl', 'changeresolution', 'tagged'] for child in selectedChildren: self.assertEqual("true", get_state_as_dict(xDialog.getChild(child))['Selected']) diff --git a/svx/source/dialog/compressgraphicdialog.cxx b/svx/source/dialog/compressgraphicdialog.cxx index 7fd293dae9d6..90f3b21892c5 100644 --- a/svx/source/dialog/compressgraphicdialog.cxx +++ b/svx/source/dialog/compressgraphicdialog.cxx @@ -125,7 +125,7 @@ void CompressGraphicsDialog::Initialize() m_xLosslessRB = m_xBuilder->weld_radio_button(u"radio-lossless"_ustr); m_xQualityMF = m_xBuilder->weld_spin_button(u"spin-quality"_ustr); m_xQualitySlider = m_xBuilder->weld_scale(u"scale-quality"_ustr); - m_xReduceResolutionCB = m_xBuilder->weld_check_button(u"checkbox-reduce-resolution"_ustr); + m_xReduceResolutionCB = m_xBuilder->weld_check_button(u"checkbox-change-resolution"_ustr); m_xMFNewWidth = m_xBuilder->weld_spin_button(u"spin-new-width"_ustr); m_xMFNewHeight = m_xBuilder->weld_spin_button(u"spin-new-height"_ustr); m_xResolutionLB = m_xBuilder->weld_combo_box(u"combo-resolution"_ustr); diff --git a/svx/uiconfig/ui/compressgraphicdialog.ui b/svx/uiconfig/ui/compressgraphicdialog.ui index 69c92ba4ebc7..511b3355041f 100644 --- a/svx/uiconfig/ui/compressgraphicdialog.ui +++ b/svx/uiconfig/ui/compressgraphicdialog.ui @@ -313,8 +313,8 @@ 12 6 - - Change image resolution to: + + Change image resolution to: True True False diff --git a/sw/qa/uitest/writer_tests4/exportToPDF.py b/sw/qa/uitest/writer_tests4/exportToPDF.py index e2ca9d72bd34..76e2e0420700 100644 --- a/sw/qa/uitest/writer_tests4/exportToPDF.py +++ b/sw/qa/uitest/writer_tests4/exportToPDF.py @@ -33,7 +33,7 @@ class exportToPDF(UITestCase): with self.ui_test.execute_dialog_through_command('.uno:ExportToPDF', close_button="") as xDialog: selectedChildren = ['bookmarks', 'display', 'effects', 'enablea11y', - 'enablecopy', 'exporturl', 'reduceresolution', 'tagged'] + 'enablecopy', 'exporturl', 'changeresolution', 'tagged'] for child in selectedChildren: self.assertEqual("true", get_state_as_dict(xDialog.getChild(child))['Selected'])