Revert "tdf#104017 DOC export: be less aggressive with merging page styles"
This reverts LO 6.3.4 commit 5d1709a7c4
,
which tdf#133334 shows is wrong. How this made it past QA
is a mystery to me. There should be lots of examples.
Change-Id: I17be6e4bab44057f4535d4728825e12d068b65d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94782
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This commit is contained in:
parent
39df467cd6
commit
42a37f8ce2
8 changed files with 55 additions and 10 deletions
|
@ -14197,6 +14197,7 @@ sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
|
|||
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
|
||||
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
|
||||
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
|
||||
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
|
||||
sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
|
||||
sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
|
||||
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
|
||||
|
|
14
sw/CppunitTest_sw_ooxmlexport15.mk
Normal file
14
sw/CppunitTest_sw_ooxmlexport15.mk
Normal file
|
@ -0,0 +1,14 @@
|
|||
# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
|
||||
#*************************************************************************
|
||||
#
|
||||
# This file is part of the LibreOffice project.
|
||||
#
|
||||
# This Source Code Form is subject to the terms of the Mozilla Public
|
||||
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
||||
#
|
||||
#*************************************************************************
|
||||
|
||||
$(eval $(call sw_ooxmlexport_test,15))
|
||||
|
||||
# vim: set noet sw=4 ts=4:
|
|
@ -80,6 +80,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\
|
|||
CppunitTest_sw_ooxmlexport12 \
|
||||
CppunitTest_sw_ooxmlexport13 \
|
||||
CppunitTest_sw_ooxmlexport14 \
|
||||
CppunitTest_sw_ooxmlexport15 \
|
||||
CppunitTest_sw_ooxmlexport_template \
|
||||
CppunitTest_sw_ooxmlfieldexport \
|
||||
CppunitTest_sw_ooxmllinks \
|
||||
|
|
BIN
sw/qa/extras/ooxmlexport/data/tdf133334_followPgStyle.odt
Normal file
BIN
sw/qa/extras/ooxmlexport/data/tdf133334_followPgStyle.odt
Normal file
Binary file not shown.
38
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
Normal file
38
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
Normal file
|
@ -0,0 +1,38 @@
|
|||
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
||||
/*
|
||||
* This file is part of the LibreOffice project.
|
||||
*
|
||||
* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
||||
*/
|
||||
|
||||
#include <swmodeltestbase.hxx>
|
||||
|
||||
#include <com/sun/star/beans/XPropertySet.hpp>
|
||||
|
||||
char const DATA_DIRECTORY[] = "/sw/qa/extras/ooxmlexport/data/";
|
||||
|
||||
class Test : public SwModelTestBase
|
||||
{
|
||||
public:
|
||||
Test() : SwModelTestBase(DATA_DIRECTORY, "Office Open XML Text") {}
|
||||
|
||||
protected:
|
||||
/**
|
||||
* Blacklist handling
|
||||
*/
|
||||
bool mustTestImportOf(const char* filename) const override {
|
||||
// If the testcase is stored in some other format, it's pointless to test.
|
||||
return OString(filename).endsWith(".docx");
|
||||
}
|
||||
};
|
||||
|
||||
DECLARE_OOXMLEXPORT_TEST(testTdf133334_followPgStyle, "tdf133334_followPgStyle.odt")
|
||||
{
|
||||
CPPUNIT_ASSERT_EQUAL(2, getPages());
|
||||
}
|
||||
|
||||
CPPUNIT_PLUGIN_IMPLEMENT();
|
||||
|
||||
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
Binary file not shown.
|
@ -556,15 +556,6 @@ DECLARE_WW8EXPORT_TEST(testPresetDash, "tdf127166_prstDash_Word97.doc")
|
|||
}
|
||||
}
|
||||
|
||||
DECLARE_WW8EXPORT_TEST(testTdf104017, "tdf104017.doc")
|
||||
{
|
||||
// Without the accompanying fix in place, this test would have failed with:
|
||||
// - Expected: 2
|
||||
// - Actual : 1
|
||||
// i.e. the tables on the two pages were merged together to a single one on export.
|
||||
CPPUNIT_ASSERT_EQUAL(2, getPages());
|
||||
}
|
||||
|
||||
CPPUNIT_PLUGIN_IMPLEMENT();
|
||||
|
||||
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
||||
|
|
|
@ -500,7 +500,7 @@ void MSWordExportBase::OutputSectionBreaks( const SfxItemSet *pSet, const SwNode
|
|||
}
|
||||
}
|
||||
}
|
||||
else if (m_pCurrentPageDesc->GetPoolFormatId() != RES_POOLPAGE_FIRST || !sw::util::IsPlausableSingleWordSection(m_pCurrentPageDesc->GetFirstMaster(), pPageDesc->GetMaster()))
|
||||
else if (!sw::util::IsPlausableSingleWordSection(m_pCurrentPageDesc->GetFirstMaster(), pPageDesc->GetMaster()))
|
||||
{
|
||||
bBreakSet = true;
|
||||
bNewPageDesc = true;
|
||||
|
|
Loading…
Reference in a new issue