From 437aaf54c6076c19aad80fdede7202b8083c07f0 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 22 Nov 2024 14:38:02 +0200 Subject: [PATCH] loplugin:unusedmethods Change-Id: I24666a7746f8920ddf84731f204f3e1a5b9b0c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177024 Tested-by: Jenkins Reviewed-by: Noel Grandin --- package/inc/ByteGrabber.hxx | 1 - package/source/zipapi/ByteGrabber.cxx | 7 ------- sc/inc/cellform.hxx | 5 ----- sc/inc/document.hxx | 7 ------- sc/inc/scabstdlg.hxx | 2 -- sc/source/core/tool/cellform.cxx | 12 ------------ sc/source/ui/attrdlg/scdlgfact.cxx | 5 ----- sc/source/ui/attrdlg/scdlgfact.hxx | 1 - sd/inc/Annotation.hxx | 1 - sd/source/core/annotations/Annotation.cxx | 8 -------- vcl/inc/qt5/QtFrame.hxx | 1 - vcl/inc/qt5/QtTools.hxx | 1 - vcl/inc/salframe.hxx | 5 ----- vcl/inc/unx/gtk/gtkframe.hxx | 1 - vcl/qt5/QtFrame.cxx | 2 -- vcl/unx/gtk3/gtkframe.cxx | 7 ------- 16 files changed, 66 deletions(-) diff --git a/package/inc/ByteGrabber.hxx b/package/inc/ByteGrabber.hxx index 8a695338563e..ea7e6867a4bc 100644 --- a/package/inc/ByteGrabber.hxx +++ b/package/inc/ByteGrabber.hxx @@ -44,7 +44,6 @@ public: /// @throws css::io::BufferSizeExceededException /// @throws css::io::IOException /// @throws css::uno::RuntimeException - sal_Int32 readBytes( css::uno::Sequence< sal_Int8 >& aData, sal_Int32 nBytesToRead ); sal_Int32 readBytes( sal_Int8* aData, sal_Int32 nBytesToRead ); // XSeekable /// @throws css::lang::IllegalArgumentException diff --git a/package/source/zipapi/ByteGrabber.cxx b/package/source/zipapi/ByteGrabber.cxx index cd9e201dba0b..7d7c77a0228f 100644 --- a/package/source/zipapi/ByteGrabber.cxx +++ b/package/source/zipapi/ByteGrabber.cxx @@ -56,13 +56,6 @@ void ByteGrabber::setInputStream (const uno::Reference < io::XInputStream >& xNe assert(mpByteReader); } -// XInputStream chained -sal_Int32 ByteGrabber::readBytes( uno::Sequence< sal_Int8 >& aData, - sal_Int32 nBytesToRead ) -{ - return xStream->readBytes(aData, nBytesToRead ); -} - sal_Int32 ByteGrabber::readBytes( sal_Int8* aData, sal_Int32 nBytesToRead ) { diff --git a/sc/inc/cellform.hxx b/sc/inc/cellform.hxx index 5227001a76e3..f5585a87da86 100644 --- a/sc/inc/cellform.hxx +++ b/sc/inc/cellform.hxx @@ -44,11 +44,6 @@ public: const Color** ppColor, ScInterpreterContext* pContext, bool bNullVals = true, bool bFormula = false ); - static svl::SharedString GetInputSharedString( - const ScRefCellValue& rCell, sal_uInt32 nFormat, ScInterpreterContext* pContext, - const ScDocument& rDoc, svl::SharedStringPool& rStrPool, - bool bFiltering = false, bool bForceSystemLocale = false ); - // Similar to GetInputSharedString, but can be used to visit the source of the // svl::SharedString to avoid reference counting overhead template diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 9f9a79eb024f..bf3d15092e68 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -233,13 +233,6 @@ struct ScConditionEasyDialogData sal_Int32 EntryIndex = -1; OUString Formula; - ScConditionEasyDialogData(ScConditionMode* mode, bool isManaged, const OUString& formula = "") - : Mode(mode) - , IsManaged(isManaged) - , Formula(formula) - { - } - ScConditionEasyDialogData(ScConditionMode* mode, bool isManaged, sal_Int32 formatKey, sal_Int32 entryIndex, const OUString& formula = "") : Mode(mode) diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx index 957c9605a116..1d297a58f22b 100644 --- a/sc/inc/scabstdlg.hxx +++ b/sc/inc/scabstdlg.hxx @@ -96,8 +96,6 @@ public: virtual void ShowEasyConditionalDialog(bool isEdit = false) = 0; virtual void SetModified() = 0; - - virtual ScConditionalFormat* GetCondFormatSelected() = 0; }; class AbstractScDataPilotDatabaseDlg :public VclAbstractDialog diff --git a/sc/source/core/tool/cellform.cxx b/sc/source/core/tool/cellform.cxx index 4b3349053fd0..d2933814ce8d 100644 --- a/sc/source/core/tool/cellform.cxx +++ b/sc/source/core/tool/cellform.cxx @@ -168,18 +168,6 @@ OUString ScCellFormat::GetInputString( } } -svl::SharedString ScCellFormat::GetInputSharedString( - const ScRefCellValue& rCell, sal_uInt32 nFormat, ScInterpreterContext* pContext, const ScDocument& rDoc, - svl::SharedStringPool& rStrPool, - bool bFiltering, bool bForceSystemLocale ) -{ - return visitInputSharedString(rCell, nFormat, pContext, rDoc, rStrPool, - bFiltering, bForceSystemLocale, - [](const svl::SharedString& arg) { - return arg; - }); -} - OUString ScCellFormat::GetOutputString( ScDocument& rDoc, const ScAddress& rPos, const ScRefCellValue& rCell ) { if (rCell.isEmpty()) diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx b/sc/source/ui/attrdlg/scdlgfact.cxx index af95b1e025fa..9f8c1a32bae2 100644 --- a/sc/source/ui/attrdlg/scdlgfact.cxx +++ b/sc/source/ui/attrdlg/scdlgfact.cxx @@ -734,11 +734,6 @@ void AbstractScCondFormatManagerDlg_Impl::SetModified() return m_xDlg->SetModified(); } -ScConditionalFormat* AbstractScCondFormatManagerDlg_Impl::GetCondFormatSelected() -{ - return m_xDlg->GetCondFormatSelected(); -} - void AbstractScCondFormatManagerDlg_Impl::ShowEasyConditionalDialog(bool isEdit) { m_xDlg->ShowEasyConditionalDialog(isEdit); diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx b/sc/source/ui/attrdlg/scdlgfact.hxx index d7dab5e4c4b8..77cd3e217cf7 100644 --- a/sc/source/ui/attrdlg/scdlgfact.hxx +++ b/sc/source/ui/attrdlg/scdlgfact.hxx @@ -115,7 +115,6 @@ public: virtual std::unique_ptr GetConditionalFormatList() override; virtual bool CondFormatsChanged() const override; virtual void SetModified() override; - virtual ScConditionalFormat* GetCondFormatSelected() override; virtual void ShowEasyConditionalDialog(bool isEdit = false) override; }; diff --git a/sd/inc/Annotation.hxx b/sd/inc/Annotation.hxx index 616888357894..64380ba7f033 100644 --- a/sd/inc/Annotation.hxx +++ b/sd/inc/Annotation.hxx @@ -46,7 +46,6 @@ namespace sd { rtl::Reference createAnnotation(SdPage* pPage); -rtl::Reference createAnnotationAndAddToPage(SdPage* pPage); std::unique_ptr CreateUndoInsertOrRemoveAnnotation(rtl::Reference& xAnnotation, bool bInsert); diff --git a/sd/source/core/annotations/Annotation.cxx b/sd/source/core/annotations/Annotation.cxx index 3036ded07e8c..a376b804bd97 100644 --- a/sd/source/core/annotations/Annotation.cxx +++ b/sd/source/core/annotations/Annotation.cxx @@ -70,14 +70,6 @@ rtl::Reference createAnnotation(SdPage* pPage) return rtl::Reference(new Annotation(comphelper::getProcessComponentContext(), pPage)); } -/** Creates an annotation and adds it to the page */ -rtl::Reference createAnnotationAndAddToPage(SdPage* pPage) -{ - rtl::Reference xAnnotation = createAnnotation(pPage); - pPage->addAnnotation(xAnnotation, -1); - return xAnnotation; -} - Annotation::Annotation(const uno::Reference& context, SdrPage* pPage) : sdr::annotation::Annotation(context, pPage) { diff --git a/vcl/inc/qt5/QtFrame.hxx b/vcl/inc/qt5/QtFrame.hxx index 7867467b7bcf..efb534825e29 100644 --- a/vcl/inc/qt5/QtFrame.hxx +++ b/vcl/inc/qt5/QtFrame.hxx @@ -184,7 +184,6 @@ public: virtual void GetWorkArea(AbsoluteScreenPixelRectangle& rRect) override; virtual SalFrame* GetParent() const override; virtual void SetModal(bool bModal) override; - virtual bool GetModal() const override; virtual void SetWindowState(const vcl::WindowData*) override; virtual bool GetWindowState(vcl::WindowData*) override; virtual void ShowFullScreen(bool bFullScreen, sal_Int32 nDisplay) override; diff --git a/vcl/inc/qt5/QtTools.hxx b/vcl/inc/qt5/QtTools.hxx index 6877b7b5d985..c1b2b75fff5f 100644 --- a/vcl/inc/qt5/QtTools.hxx +++ b/vcl/inc/qt5/QtTools.hxx @@ -155,7 +155,6 @@ QImage toQImage(const Image& rImage); QMessageBox::Icon vclMessageTypeToQtIcon(VclMessageType eType); QString vclMessageTypeToQtTitle(VclMessageType eType); -int qtResponseTypeToVclResponseType(int ret); /** Converts a string potentially containing a '~' character to indicate an accelerator * to the Qt variant using '&' for the accelerator. diff --git a/vcl/inc/salframe.hxx b/vcl/inc/salframe.hxx index 0ea3fce1565b..8b239491d469 100644 --- a/vcl/inc/salframe.hxx +++ b/vcl/inc/salframe.hxx @@ -265,11 +265,6 @@ public: { } - virtual bool GetModal() const - { - return false; - } - // return true to indicate tooltips are shown natively, false otherwise virtual bool ShowTooltip(const OUString& /*rHelpText*/, const tools::Rectangle& /*rHelpArea*/) { diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx index 5fbf4413105c..b8b10691843b 100644 --- a/vcl/inc/unx/gtk/gtkframe.hxx +++ b/vcl/inc/unx/gtk/gtkframe.hxx @@ -606,7 +606,6 @@ public: virtual void PositionByToolkit(const tools::Rectangle& rRect, FloatWinPopupFlags nFlags) override; virtual void SetModal(bool bModal) override; - virtual bool GetModal() const override; void HideTooltip(); void BlockTooltip(); void UnblockTooltip(); diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx index 9bbed032c334..d993c63e7762 100644 --- a/vcl/qt5/QtFrame.cxx +++ b/vcl/qt5/QtFrame.cxx @@ -626,8 +626,6 @@ void QtFrame::SetModal(bool bModal) }); } -bool QtFrame::GetModal() const { return isWindow() && windowHandle()->isModal(); } - void QtFrame::SetWindowState(const vcl::WindowData* pState) { QtInstance& rQtInstance = GetQtInstance(); diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx index 42243c60e965..f101834627c5 100644 --- a/vcl/unx/gtk3/gtkframe.cxx +++ b/vcl/unx/gtk3/gtkframe.cxx @@ -3132,13 +3132,6 @@ void GtkSalFrame::SetModal(bool bModal) gtk_window_set_modal(GTK_WINDOW(m_pWindow), bModal); } -bool GtkSalFrame::GetModal() const -{ - if (!m_pWindow) - return false; - return gtk_window_get_modal(GTK_WINDOW(m_pWindow)); -} - gboolean GtkSalFrame::signalTooltipQuery(GtkWidget*, gint /*x*/, gint /*y*/, gboolean /*keyboard_mode*/, GtkTooltip *tooltip, gpointer frame)