strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#163486: PVS: redundant nullptr check

Browse source 
V668 	There is no sense in testing the 'm_pRelStorElement->m_xStorage' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.

Change-Id: Ie195de78b48c3766ef08a2d3666f778f75d2ca6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176596
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This commit is contained in:
Xisco Fauli 2024-11-14 13:28:13 +01:00
parent 19e1cf2d1c
commit 45bb8d9ddc
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
package/source/xstor/xstorage.cxx
View file

@ -1582,8 +1582,7 @@ void OStorage_Impl::CreateRelStorage()
{
m_pRelStorElement = new SotElement_Impl( u"_rels"_ustr, true, true );
m_pRelStorElement->m_xStorage = CreateNewStorageImpl(embed::ElementModes::WRITE);
if (m_pRelStorElement->m_xStorage)
m_pRelStorElement->m_xStorage->m_pParent = nullptr; // the relation storage is completely controlled by parent
m_pRelStorElement->m_xStorage->m_pParent = nullptr; // the relation storage is completely controlled by parent
}
if (!m_pRelStorElement->m_xStorage)