From 473d4f84ae7e2ad39342e099c9219d1ee99539c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Wed, 9 Jan 2019 13:43:21 +0000 Subject: [PATCH] Related: tdf#122598 macro dialog from record macro has no parent MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I4ef2bca2ada4accefcf9a5314ad60c6177d1ae19 Reviewed-on: https://gerrit.libreoffice.org/66030 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- sfx2/source/view/viewfrm.cxx | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index f8ffff462c51..1c47240100b8 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -2483,7 +2483,17 @@ void SfxViewFrame::AddDispatchMacroToBasic_Impl( const OUString& sMacro ) return; SfxApplication* pSfxApp = SfxGetpApp(); - SfxRequest aReq( SID_BASICCHOOSER, SfxCallMode::SYNCHRON, pSfxApp->GetPool() ); + SfxItemPool& rPool = pSfxApp->GetPool(); + SfxRequest aReq(SID_BASICCHOOSER, SfxCallMode::SYNCHRON, rPool); + + //seen in tdf#122598, no parent for subsequent dialog + SfxAllItemSet aSet(rPool); + css::uno::Reference< css::frame::XFrame > xFrame( + GetFrame().GetFrameInterface(), + css::uno::UNO_QUERY); + aSet.Put(SfxUnoFrameItem(SID_FILLFRAME, xFrame)); + aReq.SetInternalArgs_Impl(aSet); + aReq.AppendItem( SfxBoolItem(SID_RECORDMACRO,true) ); const SfxPoolItem* pRet = SfxGetpApp()->ExecuteSlot( aReq ); OUString aScriptURL;