From 4faafea4f24316e75b80e6ef97c1a4d39551a0b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
Date: Tue, 29 Jan 2019 15:29:15 +0000
Subject: [PATCH] give better warning explanation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: If76e1acdcb601d70c956bcaf0392046430f4853e
Reviewed-on: https://gerrit.libreoffice.org/67086
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
---
 bin/verify-custom-widgets-libs | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/bin/verify-custom-widgets-libs b/bin/verify-custom-widgets-libs
index b0ea0a5e5a51..7fad02f178c2 100755
--- a/bin/verify-custom-widgets-libs
+++ b/bin/verify-custom-widgets-libs
@@ -15,15 +15,16 @@
 # its easy to put the wrong lib name in if developing
 # under Linux
 
-FOO=`grep -h -r lo- */uiconfig | sed -e "s/<object class=\"//g" | sed -e "s/\".*$//"| sed 's/^[ \t]*//;s/[ \t]*$//'|sort|uniq`
+ret=0
+FOO=`git grep -h -r lo- */uiconfig | sed -e "s/<object class=\"//g" | sed -e "s/\".*$//"| sed 's/^[ \t]*//;s/[ \t]*$//'|sort|uniq`
 for foo in $FOO; do
     lib=$(echo $foo | cut -f1 -d-)
     symbol=$(echo $foo | cut -f2 -d-)
-    echo testing if lib$lib.so contains make$symbol
     nm -D instdir/program/lib$lib.so | grep make$symbol > /dev/null
     if [ $? != 0 ]; then
-        echo "MISSING. Windows will crash"
-    else
-        echo "OK";
+        echo "$foo exists in a .ui file, but make$symbol is missing from lib$lib.so, Windows will fail to find the symbol and crash"
+	echo "  typically make$symbol is in a different library and $foo should have the prefix of that library instead"
+        ret=1
     fi
 done
+exit $ret