strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove nonsensical loop

Browse source 
The comphelper::ContainerUniquePtrEquals loops through containers itself

Change-Id: I78181d9b4b951bebcd31f40abedcda0cd3e91973
Reviewed-on: https://gerrit.libreoffice.org/45634
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This commit is contained in:
Mike Kaganski 2017-12-01 10:12:02 +02:00
parent 54d73c33eb
commit 50acacae13
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sc/source/core/data/conditio.cxx
View file

@ -1750,9 +1750,8 @@ bool ScConditionalFormat::EqualEntries( const ScConditionalFormat& r ) const
return false;
//TODO: Test for same entries in reverse order?
for (size_t i=0; i<size(); i++)
if ( ! ::comphelper::ContainerUniquePtrEquals(maEntries, r.maEntries) )
return false;
if ( ! ::comphelper::ContainerUniquePtrEquals(maEntries, r.maEntries) )
return false;
// right now don't check for same range
// we only use this method to merge same conditional formats from