remove outdated Skia todo comments

Change-Id: Ib2a9e4c25421c20e52ee65b2ec8fb3a190bcb75b
This commit is contained in:
Luboš Luňák 2020-06-17 13:01:45 +02:00
parent f24e64e8b5
commit 52a8892413
4 changed files with 3 additions and 18 deletions

View file

@ -25,7 +25,6 @@ are the same.
#define SKIA_USE_BITMAP32 0
/* TODO SKIA check all these */
#define SK_SUPPORT_GPU 1

View file

@ -881,20 +881,17 @@ bool SkiaSalGraphicsImpl::drawPolyLine(const basegfx::B2DHomMatrix& rObjectToDev
bool SkiaSalGraphicsImpl::drawPolyLineBezier(sal_uInt32, const SalPoint*, const PolyFlags*)
{
// TODO?
return false;
}
bool SkiaSalGraphicsImpl::drawPolygonBezier(sal_uInt32, const SalPoint*, const PolyFlags*)
{
// TODO?
return false;
}
bool SkiaSalGraphicsImpl::drawPolyPolygonBezier(sal_uInt32, const sal_uInt32*,
const SalPoint* const*, const PolyFlags* const*)
{
// TODO?
return false;
}
@ -1250,11 +1247,7 @@ void SkiaSalGraphicsImpl::invert(sal_uInt32 nPoints, const SalPoint* pPointArray
invert(aPolygon, eFlags);
}
bool SkiaSalGraphicsImpl::drawEPS(long, long, long, long, void*, sal_uInt32)
{
// TODO?
return false;
}
bool SkiaSalGraphicsImpl::drawEPS(long, long, long, long, void*, sal_uInt32) { return false; }
// Create SkImage from a bitmap and possibly an alpha mask (the usual VCL one-minus-alpha),
// with the given target size. Result will be possibly cached, unless disabled.
@ -1440,11 +1433,7 @@ bool SkiaSalGraphicsImpl::drawAlphaRect(long nX, long nY, long nWidth, long nHei
return true;
}
bool SkiaSalGraphicsImpl::drawGradient(const tools::PolyPolygon&, const Gradient&)
{
// TODO?
return false;
}
bool SkiaSalGraphicsImpl::drawGradient(const tools::PolyPolygon&, const Gradient&) { return false; }
static double toRadian(int degree10th) { return (3600 - degree10th) * M_PI / 1800.0; }
static double toCos(int degree10th) { return SkScalarCos(toRadian(degree10th)); }

View file

@ -164,7 +164,6 @@ bool SkiaSalBitmap::Create(const SalBitmap& rSalBmp, sal_uInt16 nNewBitCount)
bool SkiaSalBitmap::Create(const css::uno::Reference<css::rendering::XBitmapCanvas>&, Size&, bool)
{
// TODO?
return false;
}
@ -276,7 +275,6 @@ bool SkiaSalBitmap::GetSystemData(BitmapSystemData&)
#ifdef DBG_UTIL
assert(mWriteAccessCount == 0);
#endif
// TODO?
return false;
}
@ -336,7 +334,6 @@ bool SkiaSalBitmap::Replace(const Color&, const Color&, sal_uInt8)
#ifdef DBG_UTIL
assert(mWriteAccessCount == 0);
#endif
// TODO?
return false;
}

View file

@ -324,7 +324,7 @@ sk_sp<SkImage> SkiaCompatibleDC::getAsImageDiff(const SkiaCompatibleDC& white) c
// keep the alpha channel as transparent. Therefore the alpha is actually computed
// from the difference in the premultiplied red channels when drawn one black and on white.
// Alpha is computed as "alpha = 1.0 - abs(black.red - white.red)".
// TODO I doubt this can be done using Skia, so do it manually here. Fortunately
// I doubt this can be done using Skia, so do it manually here. Fortunately
// the bitmaps should be fairly small and are cached.
uint32_t* dest = tmpBitmap.getAddr32(0, 0);
assert(dest == tmpBitmap.getPixels());