Revert "loplugin:unodispose in binaryurp"

This reverts commit 3d9f9b1b29.

Reason for revert: comment from sberg:

I'm not convinced that a general rule of "clear all references in dispose()" is a good idea.  For example, in this class, access to connection_ and provider_ is not guarded against MT-races, on the basis that those two are never modified post construction.  That is broken now.  Also, e.g. Bridge::getDescription dereferences connection_, and benignly used to work fine even when called on a disposed instance.  Now, it causes UB.

Change-Id: I6039d5b1488146f09439312800ceb1de3cfcf0ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156878
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2023-09-13 11:01:17 +02:00
parent 5127b1961b
commit 5f3031b33a

View file

@ -920,8 +920,6 @@ void Bridge::dispose() {
// from within an incoming or outgoing remote call, as passive_.wait() would
// otherwise deadlock:
passive_.wait();
connection_.clear();
provider_.clear();
}
void Bridge::addEventListener(