strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ReleaseHbFont is unused

Browse source 
LogicalFontInstance dtor does call hb_font_destroy though

Change-Id: I59d9711f1934966cddd73c5e62c8929f08b1359a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94335
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara 2020-05-15 20:16:39 +01:00
parent 9ad875a5e4
commit 649593b523
2 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
compilerplugins/clang/unusedmethods.results
View file

@ -1696,8 +1696,6 @@ vcl/inc/fontinstance.hxx:69
void LogicalFontInstance::SetAverageWidthFactor(double) void LogicalFontInstance::SetAverageWidthFactor(double)
vcl/inc/fontinstance.hxx:70 vcl/inc/fontinstance.hxx:70
double LogicalFontInstance::GetAverageWidthFactor() const double LogicalFontInstance::GetAverageWidthFactor() const
vcl/inc/fontinstance.hxx:93
void LogicalFontInstance::ReleaseHbFont()
vcl/inc/fontselect.hxx:48 vcl/inc/fontselect.hxx:48
_Bool FontSelectPattern::operator!=(const class FontSelectPattern &) const _Bool FontSelectPattern::operator!=(const class FontSelectPattern &) const
vcl/inc/graphic/GraphicID.hxx:39 vcl/inc/graphic/GraphicID.hxx:39

9
vcl/inc/fontinstance.hxx
View file

@ -90,7 +90,6 @@ protected:
// Takes ownership of pHbFace. // Takes ownership of pHbFace.
static hb_font_t* InitHbFont(hb_face_t* pHbFace); static hb_font_t* InitHbFont(hb_face_t* pHbFace);
virtual hb_font_t* ImplInitHbFont() { assert(false); return hb_font_get_empty(); } virtual hb_font_t* ImplInitHbFont() { assert(false); return hb_font_get_empty(); }
inline void ReleaseHbFont();
private: private:
// cache of Unicode characters and replacement font names // cache of Unicode characters and replacement font names
@ -113,14 +112,6 @@ inline hb_font_t* LogicalFontInstance::GetHbFont()
return m_pHbFont; return m_pHbFont;
} }
inline void LogicalFontInstance::ReleaseHbFont()
{
if (!m_pHbFont)
return;
hb_font_destroy(m_pHbFont);
m_pHbFont = nullptr;
}
inline void LogicalFontInstance::DecodeOpenTypeTag(const uint32_t nTableTag, char* pTagName) inline void LogicalFontInstance::DecodeOpenTypeTag(const uint32_t nTableTag, char* pTagName)
{ {
pTagName[0] = static_cast<char>(nTableTag >> 24); pTagName[0] = static_cast<char>(nTableTag >> 24);