strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#163486: PVS: variable is used after being declared

Browse source 
Since
commit 400d5d8a90
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date:   Wed Nov 13 10:35:36 2013 +0100

    oox: initial import of wps:wsp

V614 	The 'pMasterShape' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it. Consider checking the third actual argument of the 'WpsContext' function.

Change-Id: I1e14be0a528e01acbfa2d3e79d5a4d03e4b3e268
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176552
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
This commit is contained in:
Xisco Fauli 2024-11-13 16:29:05 +01:00
parent c382c5202c
commit 6570d56009
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
oox/source/shape/ShapeContextHandler.cxx
View file

@ -113,7 +113,6 @@ uno::Reference<xml::sax::XFastContextHandler> ShapeContextHandler::getWpsContext
if (!mxWpsContext.is())
{
FragmentHandler2Ref rFragmentHandler(new ShapeFragmentHandler(*mxShapeFilterBase, msRelationFragmentPath));
ShapePtr pMasterShape;
uno::Reference<drawing::XShape> xShape;
// No element happens in case of pretty-printed XML, bodyPr is the case when we are called again after <wps:txbx>.
@ -127,7 +126,7 @@ uno::Reference<xml::sax::XFastContextHandler> ShapeContextHandler::getWpsContext
mxWpsContext.set(new WpsContext(
*rFragmentHandler,
xShape,
pMasterShape,
nullptr,
std::make_shared<oox::drawingml::Shape>(
"com.sun.star.drawing.CustomShape")));
break;