strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clang-tidy: performance-unnecessary-copy-initialization in fpicker

Browse source 
Change-Id: I9ba5dd3d13390db5d2c6d03caf087c453ee09ba6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176415
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2024-11-11 19:32:41 +02:00
parent d0f5d10652
commit 66c3126960
3 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
forms/source/component/imgprod.cxx
View file

@ -241,7 +241,7 @@ void ImageProducer::ImplInitConsumer( const Graphic& rGraphic )
void ImageProducer::ImplUpdateConsumer( const Graphic& rGraphic )
{
BitmapEx aBmpEx( rGraphic.GetBitmapEx() );
Bitmap aBmp( aBmpEx.GetBitmap() );
const Bitmap& aBmp( aBmpEx.GetBitmap() );
BitmapScopedReadAccess pBmpAcc(aBmp);
if( !pBmpAcc )

4
fpicker/source/office/RemoteFilesDialog.cxx
View file

@ -323,13 +323,11 @@ int RemoteFilesDialog::GetSelectedServicePos()
void RemoteFilesDialog::AddFilter( const OUString& rFilter, const OUString& rType )
{
OUString sName = rFilter;
m_aFilters.emplace_back( rFilter, rType );
if (rType.isEmpty())
m_xFilter_lb->append_separator(u""_ustr);
else
m_xFilter_lb->append_text(sName);
m_xFilter_lb->append_text(rFilter);
if (m_xFilter_lb->get_active() == -1)
m_xFilter_lb->set_active(0);

2
fpicker/source/office/iodlgimp.cxx
View file

@ -161,7 +161,7 @@ void SvtExpFileDlg_Impl::InsertFilterListEntry(const SvtFileDialogFilter_Impl* p
{
// insert and set user data
OUString sId(weld::toId(pFilterDesc));
OUString sName = pFilterDesc->GetName();
const OUString& sName = pFilterDesc->GetName();
if (pFilterDesc->isGroupSeparator())
m_xLbFilter->append_separator(sId);
else