strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

coverity#1209550 Unchecked dynamic_cast

Browse source 
Dynamic cast can be dangerous - if the cast fails then it returns NULL.
Coverity picked this up - it could effect
Window::IsNativeWidgetEndabled(). Hopefully I'll get rid of this when I
remove meOutDevType during work on fdo#74702.

Change-Id: Id6df1eeff716a6acd1b108b5e1e4674e819afe3d
This commit is contained in:
Chris Sherlock 2014-05-01 22:56:17 +10:00
parent 0d0f80900d
commit 68bfb2a082
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
vcl/source/outdev/nativecontrols.cxx
View file

@ -32,7 +32,19 @@ static bool EnableNativeWidget( const OutputDevice& i_rDevice )
{
case OUTDEV_WINDOW:
return dynamic_cast< const Window* >( &i_rDevice )->IsNativeWidgetEnabled();
{
const Window* pWindow = dynamic_cast< const Window* >( &i_rDevice );
if (pWindow)
{
return pWindow->IsNativeWidgetEnabled();
}
else
{
SAL_WARN ("vcl.gdi", "Could not cast i_rDevice to Window");
assert (pWindow);
return false;
}
}
case OUTDEV_VIRDEV:
{