From 69625a9191ec005a7f1885aa289a75251f7ccfb4 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 30 Jul 2019 17:58:41 +0200 Subject: [PATCH] Improved loplugin:stringconstant (now that GCC 7 supports it): basctl Change-Id: Ide954bc4ebffef93c71a3ca5fbde51ea38b6cb28 Reviewed-on: https://gerrit.libreoffice.org/76697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- basctl/source/accessibility/accessibledialogcontrolshape.cxx | 2 +- basctl/source/accessibility/accessibledialogwindow.cxx | 2 +- basctl/source/basicide/bastype2.cxx | 4 ++-- basctl/source/basicide/unomodel.cxx | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/basctl/source/accessibility/accessibledialogcontrolshape.cxx b/basctl/source/accessibility/accessibledialogcontrolshape.cxx index 11b9610375b7..1d725842fdf0 100644 --- a/basctl/source/accessibility/accessibledialogcontrolshape.cxx +++ b/basctl/source/accessibility/accessibledialogcontrolshape.cxx @@ -285,7 +285,7 @@ void AccessibleDialogControlShape::propertyChange( const beans::PropertyChangeEv // XServiceInfo OUString AccessibleDialogControlShape::getImplementationName() { - return OUString( "com.sun.star.comp.basctl.AccessibleShape" ); + return "com.sun.star.comp.basctl.AccessibleShape"; } sal_Bool AccessibleDialogControlShape::supportsService( const OUString& rServiceName ) diff --git a/basctl/source/accessibility/accessibledialogwindow.cxx b/basctl/source/accessibility/accessibledialogwindow.cxx index 357ea872b932..6cd52c2a3132 100644 --- a/basctl/source/accessibility/accessibledialogwindow.cxx +++ b/basctl/source/accessibility/accessibledialogwindow.cxx @@ -536,7 +536,7 @@ void AccessibleDialogWindow::disposing() // XServiceInfo OUString AccessibleDialogWindow::getImplementationName() { - return OUString( "com.sun.star.comp.basctl.AccessibleWindow" ); + return "com.sun.star.comp.basctl.AccessibleWindow"; } sal_Bool AccessibleDialogWindow::supportsService( const OUString& rServiceName ) diff --git a/basctl/source/basicide/bastype2.cxx b/basctl/source/basicide/bastype2.cxx index b63a2f889daf..5d510411aef4 100644 --- a/basctl/source/basicide/bastype2.cxx +++ b/basctl/source/basicide/bastype2.cxx @@ -1413,10 +1413,10 @@ OUString SbTreeListBox::GetRootEntryBitmaps(const ScriptDocument& rDocument) else { // default icon - return OUString(RID_BMP_DOCUMENT); + return RID_BMP_DOCUMENT; } } - return OUString(RID_BMP_INSTALLATION); + return RID_BMP_INSTALLATION; } void SbTreeListBox::SetCurrentEntry (EntryDescriptor const & rDesc) diff --git a/basctl/source/basicide/unomodel.cxx b/basctl/source/basicide/unomodel.cxx index 8647cbd399ff..8c559cccb5b2 100644 --- a/basctl/source/basicide/unomodel.cxx +++ b/basctl/source/basicide/unomodel.cxx @@ -85,7 +85,7 @@ OUString SIDEModel::getImplementationName() OUString SIDEModel::getImplementationName_Static() { - return OUString( "com.sun.star.comp.basic.BasicIDE" ); + return "com.sun.star.comp.basic.BasicIDE"; } sal_Bool SIDEModel::supportsService(const OUString& rServiceName)