From 7c548bf66af69a308ab891bc396cc192c9bf30c9 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 27 Nov 2017 15:40:27 +0200 Subject: [PATCH] loplugin:countusersofdefaultparams in svx Change-Id: I2c9ea6c38b75dcafeb36931b6c2e94489819144f Reviewed-on: https://gerrit.libreoffice.org/45336 Tested-by: Jenkins Reviewed-by: Noel Grandin --- include/svx/ClassificationField.hxx | 4 ++-- include/svx/framelink.hxx | 2 +- include/svx/gallery.hxx | 2 +- include/svx/hlnkitem.hxx | 2 +- include/svx/imapdlg.hxx | 4 ++-- include/svx/passwd.hxx | 2 +- include/svx/rotmodit.hxx | 2 +- include/svx/ruler.hxx | 2 +- include/svx/sdrhittesthelper.hxx | 2 +- include/svx/svdhdl.hxx | 2 +- include/svx/svditer.hxx | 2 +- include/svx/svdmodel.hxx | 2 +- include/svx/svdmrkv.hxx | 2 +- include/svx/svdotable.hxx | 2 +- include/svx/xoutbmp.hxx | 2 +- sd/inc/drawdoc.hxx | 2 +- svx/inc/dragmt3d.hxx | 8 ++++---- svx/inc/sdr/contact/objectcontactofpageview.hxx | 2 +- svx/source/dialog/framelink.cxx | 2 +- svx/source/inc/filtnav.hxx | 2 +- svx/source/inc/gridcell.hxx | 2 +- 21 files changed, 26 insertions(+), 26 deletions(-) diff --git a/include/svx/ClassificationField.hxx b/include/svx/ClassificationField.hxx index 32f783eb1896..53989f868fc8 100644 --- a/include/svx/ClassificationField.hxx +++ b/include/svx/ClassificationField.hxx @@ -35,7 +35,7 @@ public: OUString msIdentifier; //< The identifier of this entry (from example.xml). ClassificationResult(ClassificationType eType, const OUString& sName, - const OUString& sAbbreviatedName = "", const OUString& sIdentifier = "") + const OUString& sAbbreviatedName, const OUString& sIdentifier = "") : meType(eType) , msName(sName) , msAbbreviatedName(sAbbreviatedName) @@ -66,7 +66,7 @@ public: OUString msFullClassName; OUString msIdentifier; - ClassificationField(ClassificationType eType, OUString const & sDescription, OUString const & sFullClassName, OUString const & sIdentifier = "") + ClassificationField(ClassificationType eType, OUString const & sDescription, OUString const & sFullClassName, OUString const & sIdentifier) : SvxFieldData() , meType(eType) , msDescription(sDescription) diff --git a/include/svx/framelink.hxx b/include/svx/framelink.hxx index 887c512e5433..be442e4103da 100644 --- a/include/svx/framelink.hxx +++ b/include/svx/framelink.hxx @@ -240,7 +240,7 @@ public: const basegfx::B2DVector& rB2DVector, const double fAngle, bool bMirrored, - const Color* pForceColor = nullptr); + const Color* pForceColor); double getRefModeOffset() const { return mfRefModeOffset; } const basegfx::B2DVector& getB2DVector() const { return maB2DVector; } diff --git a/include/svx/gallery.hxx b/include/svx/gallery.hxx index ab351e1f1e2e..cb2da0a856ba 100644 --- a/include/svx/gallery.hxx +++ b/include/svx/gallery.hxx @@ -118,7 +118,7 @@ public: static bool InsertURL( sal_uInt32 nThemeId, const OUString& rURL ); static bool GetGraphicObj( const OUString& rThemeName, sal_uInt32 nPos, - Graphic* pGraphic, BitmapEx* pThumb = nullptr, + Graphic* pGraphic, BitmapEx* pThumb, bool bProgress = false ); static bool GetGraphicObj( sal_uInt32 nThemeId, sal_uInt32 nPos, Graphic* pGraphic ); diff --git a/include/svx/hlnkitem.hxx b/include/svx/hlnkitem.hxx index f4cc177aaa14..daa3da50aabb 100644 --- a/include/svx/hlnkitem.hxx +++ b/include/svx/hlnkitem.hxx @@ -66,7 +66,7 @@ public: SvxHyperlinkItem( sal_uInt16 nWhich, const OUString& rName, const OUString& rURL, const OUString& rTarget, const OUString& rIntName, SvxLinkInsertMode eTyp, - HyperDialogEvent nEvents = HyperDialogEvent::NONE, + HyperDialogEvent nEvents, SvxMacroTableDtor const *pMacroTbl =nullptr ); inline SvxHyperlinkItem& operator=( const SvxHyperlinkItem &rItem ); diff --git a/include/svx/imapdlg.hxx b/include/svx/imapdlg.hxx index 4c337ec59411..836d357b1eee 100644 --- a/include/svx/imapdlg.hxx +++ b/include/svx/imapdlg.hxx @@ -52,7 +52,7 @@ class SVX_DLLPUBLIC SvxIMapDlgChildWindow : public SfxChildWindow SFX_DECL_CHILDWINDOW_WITHID( SvxIMapDlgChildWindow ); static void UpdateIMapDlg( const Graphic& rGraphic, const ImageMap* pImageMap, - const TargetList* pTargetList, void* pEditingObj = nullptr ); + const TargetList* pTargetList, void* pEditingObj ); }; @@ -150,7 +150,7 @@ public: void SetTargetList( const TargetList& rTargetList ); void UpdateLink( const Graphic& rGraphic, const ImageMap* pImageMap, - const TargetList* pTargetList, void* pEditingObj = nullptr ); + const TargetList* pTargetList, void* pEditingObj ); }; SVX_DLLPUBLIC SvxIMapDlg* GetIMapDlg(); diff --git a/include/svx/passwd.hxx b/include/svx/passwd.hxx index c61ddafdc918..2ddbb6373f56 100644 --- a/include/svx/passwd.hxx +++ b/include/svx/passwd.hxx @@ -51,7 +51,7 @@ private: DECL_LINK(EditModifyHdl, Edit&, void); public: - SvxPasswordDialog( vcl::Window* pParent, bool bAllowEmptyPasswords, bool bDisableOldPassword = false ); + SvxPasswordDialog( vcl::Window* pParent, bool bAllowEmptyPasswords, bool bDisableOldPassword ); virtual ~SvxPasswordDialog() override; virtual void dispose() override; diff --git a/include/svx/rotmodit.hxx b/include/svx/rotmodit.hxx index 69c09a09925c..7327880e0cd9 100644 --- a/include/svx/rotmodit.hxx +++ b/include/svx/rotmodit.hxx @@ -39,7 +39,7 @@ class SVX_DLLPUBLIC SvxRotateModeItem: public SfxEnumItem public: static SfxPoolItem* CreateDefault(); - SvxRotateModeItem( SvxRotateMode eMode, sal_uInt16 nWhich=0); + SvxRotateModeItem( SvxRotateMode eMode, sal_uInt16 nWhich); SvxRotateModeItem( const SvxRotateModeItem& rItem ); virtual ~SvxRotateModeItem() override; diff --git a/include/svx/ruler.hxx b/include/svx/ruler.hxx index 02baa710d2c8..2a2594826890 100644 --- a/include/svx/ruler.hxx +++ b/include/svx/ruler.hxx @@ -260,7 +260,7 @@ protected: public: SvxRuler(vcl::Window* pParent, vcl::Window *pEditWin, SvxRulerSupportFlags nRulerFlags, - SfxBindings &rBindings, WinBits nWinStyle = WB_STDRULER); + SfxBindings &rBindings, WinBits nWinStyle); virtual ~SvxRuler() override; virtual void dispose() override; diff --git a/include/svx/sdrhittesthelper.hxx b/include/svx/sdrhittesthelper.hxx index 17a36c4b1477..fd2f23c51a4b 100644 --- a/include/svx/sdrhittesthelper.hxx +++ b/include/svx/sdrhittesthelper.hxx @@ -64,7 +64,7 @@ SVX_DLLPUBLIC bool ViewObjectContactPrimitiveHit( double fLogicHitTolerance, bool bTextOnly, /// allow to get back the stack of primitives that lead to the hit - drawinglayer::primitive2d::Primitive2DContainer* pHitContainer = nullptr); + drawinglayer::primitive2d::Primitive2DContainer* pHitContainer); #endif // INCLUDED_SVX_SDRHITTESTHELPER_HXX diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx index bec106d71635..c1e1452c7b85 100644 --- a/include/svx/svdhdl.hxx +++ b/include/svx/svdhdl.hxx @@ -259,7 +259,7 @@ class SVX_DLLPUBLIC SdrHdlColor : public SdrHdl SVX_DLLPRIVATE static Color GetLuminance(const Color& rCol); public: - explicit SdrHdlColor(const Point& rRef, Color aCol, const Size& rSize = Size(11, 11), bool bLum = false); + explicit SdrHdlColor(const Point& rRef, Color aCol, const Size& rSize, bool bLum = false); virtual ~SdrHdlColor() override; bool IsUseLuminance() const { return bUseLuminance; } diff --git a/include/svx/svditer.hxx b/include/svx/svditer.hxx index f4d935989ead..6f87776401ce 100644 --- a/include/svx/svditer.hxx +++ b/include/svx/svditer.hxx @@ -54,7 +54,7 @@ public: Otherwise the navigation position as returned by SdrObject::GetNavigationPosition() is used. */ - SdrObjListIter(const SdrObjList& rObjList, bool bUseZOrder, SdrIterMode eMode = SdrIterMode::DeepNoGroups); + SdrObjListIter(const SdrObjList& rObjList, bool bUseZOrder, SdrIterMode eMode); /* SJ: the following function can now be used with every SdrObject and is no longer limited to group objects */ diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx index 4a38209b561d..6808db46cc3f 100644 --- a/include/svx/svdmodel.hxx +++ b/include/svx/svdmodel.hxx @@ -432,7 +432,7 @@ public: virtual void Merge(SdrModel& rSourceModel, sal_uInt16 nFirstPageNum, sal_uInt16 nLastPageNum, sal_uInt16 nDestPos, - bool bMergeMasterPages = false, bool bAllMasterPages = false, + bool bMergeMasterPages, bool bAllMasterPages = false, bool bUndo = true, bool bTreadSourceAsConst = false); // Behaves like Merge(SourceModel=DestModel,nFirst,nLast,nDest,sal_False,sal_False,bUndo,!bMoveNoCopy); diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx index e9b19d7b2789..acea4c514145 100644 --- a/include/svx/svdmrkv.hxx +++ b/include/svx/svdmrkv.hxx @@ -359,7 +359,7 @@ public: // Attention: With each change of the glue point status the handle list is re-calculated. // All previously saved SdrHdl* became invalid by this, the same with the point IDs! bool PickGluePoint(const Point& rPnt, SdrObject*& rpObj, sal_uInt16& rnId, SdrPageView*& rpPV) const; - bool MarkGluePoint(const SdrObject* pObj, sal_uInt16 nId, bool bUnmark=false); + bool MarkGluePoint(const SdrObject* pObj, sal_uInt16 nId, bool bUnmark); void UnmarkGluePoint(const SdrObject* pObj, sal_uInt16 nId) { MarkGluePoint(pObj,nId,true); } bool IsGluePointMarked(const SdrObject* pObj, sal_uInt16 nId) const; diff --git a/include/svx/svdotable.hxx b/include/svx/svdotable.hxx index 7537e2184d00..c33551cccac7 100644 --- a/include/svx/svdotable.hxx +++ b/include/svx/svdotable.hxx @@ -174,7 +174,7 @@ public: /** At the same time, we set the text in the outliner (if applicable the EditOutliners') * as well as the PaperSize */ - void TakeTextRect( const sdr::table::CellPos& rPos, SdrOutliner& rOutliner, ::tools::Rectangle& rTextRect, bool bNoEditText, ::tools::Rectangle* pAnchorRect=nullptr ) const; + void TakeTextRect( const sdr::table::CellPos& rPos, SdrOutliner& rOutliner, ::tools::Rectangle& rTextRect, bool bNoEditText, ::tools::Rectangle* pAnchorRect ) const; virtual void TakeTextRect( SdrOutliner& rOutliner, tools::Rectangle& rTextRect, bool bNoEditText, tools::Rectangle* pAnchorRect, bool bLineWidth = true ) const override; void TakeTextAnchorRect(const sdr::table::CellPos& rPos, ::tools::Rectangle& rAnchorRect ) const; virtual void TakeTextAnchorRect(::tools::Rectangle& rAnchorRect) const override; diff --git a/include/svx/xoutbmp.hxx b/include/svx/xoutbmp.hxx index 7a2962c18ec2..23249ffb94a1 100644 --- a/include/svx/xoutbmp.hxx +++ b/include/svx/xoutbmp.hxx @@ -66,7 +66,7 @@ public: static ErrCode ExportGraphic( const Graphic& rGraphic, const INetURLObject& rURL, GraphicFilter& rFilter, const sal_uInt16 nFormat, - const css::uno::Sequence< css::beans::PropertyValue >* pFilterData = nullptr ); + const css::uno::Sequence< css::beans::PropertyValue >* pFilterData ); static Bitmap DetectEdges( const Bitmap& rBmp, const sal_uInt8 cThreshold ); diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx index 8a0af1398287..1b6425dc795c 100644 --- a/sd/inc/drawdoc.hxx +++ b/sd/inc/drawdoc.hxx @@ -459,7 +459,7 @@ public: SAL_DLLPRIVATE void Merge(SdrModel& rSourceModel, sal_uInt16 nFirstPageNum, sal_uInt16 nLastPageNum, sal_uInt16 nDestPos, - bool bMergeMasterPages = false, bool bAllMasterPages = false, + bool bMergeMasterPages, bool bAllMasterPages = false, bool bUndo = true, bool bTreadSourceAsConst = false) override; css::text::WritingMode GetDefaultWritingMode() const; diff --git a/svx/inc/dragmt3d.hxx b/svx/inc/dragmt3d.hxx index 0966fbf91981..d8eba435c667 100644 --- a/svx/inc/dragmt3d.hxx +++ b/svx/inc/dragmt3d.hxx @@ -67,7 +67,7 @@ public: SdrDragView &rView, const SdrMarkList& rMark, E3dDragConstraint eConstr, - bool bFull = false); + bool bFull); virtual void TakeSdrDragComment(OUString& rStr) const override; virtual bool BeginSdrDrag() override; @@ -89,7 +89,7 @@ public: SdrDragView &rView, const SdrMarkList& rMark, E3dDragConstraint eConstr, - bool bFull = false); + bool bFull); virtual void MoveSdrDrag(const Point& rPnt) override; virtual Pointer GetSdrDragPointer() const override; @@ -106,8 +106,8 @@ public: SdrDragView &rView, const SdrMarkList& rMark, SdrHdlKind eDrgHdl, - E3dDragConstraint eConstr = E3dDragConstraint::XYZ, - bool bFull = false); + E3dDragConstraint eConstr, + bool bFull); virtual void MoveSdrDrag(const Point& rPnt) override; virtual Pointer GetSdrDragPointer() const override; diff --git a/svx/inc/sdr/contact/objectcontactofpageview.hxx b/svx/inc/sdr/contact/objectcontactofpageview.hxx index 3f081299e926..28c54434c9ad 100644 --- a/svx/inc/sdr/contact/objectcontactofpageview.hxx +++ b/svx/inc/sdr/contact/objectcontactofpageview.hxx @@ -48,7 +48,7 @@ namespace sdr // basic constructor, used from SdrPageView. explicit ObjectContactOfPageView(SdrPageWindow& rPageWindow, - const sal_Char *pDebugName = nullptr); + const sal_Char *pDebugName); virtual ~ObjectContactOfPageView() override; // LazyInvalidate request. This is used from the VOCs to mark that they diff --git a/svx/source/dialog/framelink.cxx b/svx/source/dialog/framelink.cxx index e86e6f1b3e34..448504994a69 100644 --- a/svx/source/dialog/framelink.cxx +++ b/svx/source/dialog/framelink.cxx @@ -689,7 +689,7 @@ void StyleVectorTable::add( // create angle between both. angle() needs vectors pointing away from the same point, // so take the mirrored one. Add F_PI to get from -pi..+pi to [0..F_PI2] for sorting const double fAngle(basegfx::B2DVector(-rMyVector.getX(), -rMyVector.getY()).angle(rOtherVector) + F_PI); - maEntries.emplace_back(rStyle, rOtherVector, fAngle, bMirrored); + maEntries.emplace_back(rStyle, rOtherVector, fAngle, bMirrored, nullptr); } } diff --git a/svx/source/inc/filtnav.hxx b/svx/source/inc/filtnav.hxx index c5b71cdab159..60f5095adf4d 100644 --- a/svx/source/inc/filtnav.hxx +++ b/svx/source/inc/filtnav.hxx @@ -62,7 +62,7 @@ class FmFilterData OUString m_aText; public: - FmFilterData(FmParentData* pParent, const OUString& rText = OUString()) + FmFilterData(FmParentData* pParent, const OUString& rText) :m_pParent( pParent ) ,m_aText( rText ) {} diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx index 3852c8b8fc65..6a7744b48025 100644 --- a/svx/source/inc/gridcell.hxx +++ b/svx/source/inc/gridcell.hxx @@ -1052,7 +1052,7 @@ class FmXFilterCell final : public FmXGridCell ,public FmXFilterCell_Base { public: - FmXFilterCell(DbGridColumn* pColumn, DbCellControl* pControl = nullptr); + FmXFilterCell(DbGridColumn* pColumn, DbCellControl* pControl); DECLARE_UNO3_AGG_DEFAULTS(FmXFilterCell, FmXGridCell)