strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not hardcode --with-locales=en for Emscripten build

Browse source 
...which had been done in 7a9e4c4ba8 "WASM add
strip flags to configure.ac", but without giving a rationale.  For
--enable-assert-always-abort builds, it could have caused the

>                     assert(pUpperMonthText[0] == "JANUAR");

in ImpSvNumberInputScan::GetMonth (svl/source/numbers/zforfind.cxx) to fire when
running in a German-locale browser, because the rule to generate the
DISABLE_DYNLOADING-specific localedata_static.hxx in
i18npool/Library_i18npool.mk then only included English-locale fallback
locale data, so pUpperMonthText[0] was always the English "JANUARY", regardless
of locale used.

With with_locales left uninitialized here, the generated localedata_static.hxx
now includes the full set of locale data.  Which comes with a small increase in
size, though:  For one non-debug build scenario, sofice.data stayed at ca. 68M
but soffice.wasm grew from ca. 138M to ca. 143M.

Change-Id: I46dae3f5c795ae30fc44d3ac4cb8dd162cd72966
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173619
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This commit is contained in:
Stephan Bergmann 2024-09-18 13:53:08 +02:00
parent b97b725312
commit 80d4e666dd
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
configure.ac
View file

@ -3265,7 +3265,6 @@ if test "$enable_wasm_strip" = "yes"; then
with_x=no
test "${with_fonts+set}" = set || with_fonts=yes
test "${with_locales+set}" = set || with_locales=en
AC_DEFINE(ENABLE_WASM_STRIP_ACCESSIBILITY)
AC_DEFINE(ENABLE_WASM_STRIP_WRITER)