strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clang-tidy modernize-pass-by-value in bridges

Browse source 
Change-Id: I6c52316e46117aacb22a2adcb75841aed834041f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134705
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2022-05-21 13:09:58 +02:00
parent 685eff8c9e
commit 80fab1529a
7 changed files with 18 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bridges/inc/cppinterfaceproxy.hxx
View file

@ -72,7 +72,7 @@ private:
CppInterfaceProxy(
Bridge * pBridge_, uno_Interface * pUnoI_,
typelib_InterfaceTypeDescription * pTypeDescr_,
OUString const & rOId_);
OUString aOId_);
~CppInterfaceProxy();

2
bridges/inc/unointerfaceproxy.hxx
View file

@ -76,7 +76,7 @@ private:
UnoInterfaceProxy(
Bridge * pBridge_, com::sun::star::uno::XInterface * pCppI_,
typelib_InterfaceTypeDescription * pTypeDescr_,
OUString const & rOId_);
OUString aOId_);
~UnoInterfaceProxy();

5
bridges/source/cpp_uno/shared/cppinterfaceproxy.cxx
View file

@ -20,6 +20,7 @@
#include <cppinterfaceproxy.hxx>
#include <bridge.hxx>
#include <utility>
#include <vtablefactory.hxx>
#include <com/sun/star/uno/XInterface.hpp>
@ -102,12 +103,12 @@ void CppInterfaceProxy::releaseProxy()
CppInterfaceProxy::CppInterfaceProxy(
bridges::cpp_uno::shared::Bridge * pBridge_, uno_Interface * pUnoI_,
typelib_InterfaceTypeDescription * pTypeDescr_, OUString const & rOId_)
typelib_InterfaceTypeDescription * pTypeDescr_, OUString aOId_)
: nRef( 1 )
, pBridge( pBridge_ )
, pUnoI( pUnoI_ )
, pTypeDescr( pTypeDescr_ )
, oid( rOId_ )
, oid(std::move( aOId_ ))
{
pBridge->acquire();
::typelib_typedescription_acquire( &pTypeDescr->aBase );

5
bridges/source/cpp_uno/shared/unointerfaceproxy.cxx
View file

@ -22,6 +22,7 @@
#include <bridge.hxx>
#include <com/sun/star/uno/XInterface.hpp>
#include <utility>
#include <typelib/typedescription.h>
#include <uno/dispatcher.h>
@ -93,12 +94,12 @@ UnoInterfaceProxy * UnoInterfaceProxy::create(
UnoInterfaceProxy::UnoInterfaceProxy(
bridges::cpp_uno::shared::Bridge * pBridge_,
com::sun::star::uno::XInterface * pCppI_,
typelib_InterfaceTypeDescription * pTypeDescr_, OUString const & rOId_)
typelib_InterfaceTypeDescription * pTypeDescr_, OUString aOId_)
: nRef( 1 )
, pBridge( pBridge_ )
, pCppI( pCppI_ )
, pTypeDescr( pTypeDescr_ )
, oid( rOId_ )
, oid(std::move( aOId_ ))
{
pBridge->acquire();
::typelib_typedescription_acquire(&pTypeDescr->aBase);

5
bridges/source/jni_uno/jni_base.h
View file

@ -31,6 +31,7 @@
#include <rtl/alloc.h>
#include <rtl/ustring.hxx>
#include <sal/log.hxx>
#include <utility>
#include <uno/environment.h>
#include <typelib/typedescription.h>
@ -45,8 +46,8 @@ struct BridgeRuntimeError
{
OUString m_message;
explicit BridgeRuntimeError( OUString const & message )
: m_message( message )
explicit BridgeRuntimeError( OUString message )
: m_message(std::move( message ))
{}
};

7
bridges/source/jni_uno/jni_uno2java.cxx
View file

@ -30,6 +30,7 @@
#include <com/sun/star/uno/RuntimeException.hpp>
#include <rtl/ustrbuf.hxx>
#include <utility>
#include "jni_bridge.h"
#include "jniunoenvironmentdata.hxx"
@ -401,7 +402,7 @@ struct UNO_proxy : public uno_Interface
// ctor
inline UNO_proxy(
JNI_context const & jni, Bridge const * bridge,
jobject javaI, jstring jo_oid, OUString const & oid,
jobject javaI, jstring jo_oid, OUString oid,
JNI_interface_type_info const * info );
};
@ -409,10 +410,10 @@ struct UNO_proxy : public uno_Interface
inline UNO_proxy::UNO_proxy(
JNI_context const & jni, Bridge const * bridge,
jobject javaI, jstring jo_oid, OUString const & oid,
jobject javaI, jstring jo_oid, OUString oid,
JNI_interface_type_info const * info )
: m_ref( 1 ),
m_oid( oid ),
m_oid(std::move( oid )),
m_type_info( info )
{
JNI_info const * jni_info = bridge->getJniInfo();

5
bridges/source/jni_uno/nativethreadpool.cxx
View file

@ -29,6 +29,7 @@
#include <jni.h>
#include <new>
#include <utility>
/* The native implementation part of
* jurt/com/sun/star/lib/uno/environments/remote/NativeThreadPool.java.
@ -37,9 +38,9 @@
namespace {
struct Pool {
Pool(rtl::Reference< jvmaccess::VirtualMachine > const & theVirtualMachine,
Pool(rtl::Reference< jvmaccess::VirtualMachine > theVirtualMachine,
jmethodID theExecute, uno_ThreadPool thePool):
virtualMachine(theVirtualMachine), execute(theExecute), pool(thePool) {}
virtualMachine(std::move(theVirtualMachine)), execute(theExecute), pool(thePool) {}
rtl::Reference< jvmaccess::VirtualMachine > virtualMachine;
jmethodID execute;