From 82b7823cd83be3c31720c8a3b8eea33c22b312bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Mon, 22 Jul 2024 21:47:33 +0100 Subject: [PATCH] cid#1555070 COPY_INSTEAD_OF_MOVE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit and cid#1555069 COPY_INSTEAD_OF_MOVE cid#1555128 COPY_INSTEAD_OF_MOVE cid#1555131 COPY_INSTEAD_OF_MOVE cid#1555137 COPY_INSTEAD_OF_MOVE cid#1555142 COPY_INSTEAD_OF_MOVE cid#1555152 COPY_INSTEAD_OF_MOVE cid#1555154 COPY_INSTEAD_OF_MOVE cid#1555161 COPY_INSTEAD_OF_MOVE cid#1555163 COPY_INSTEAD_OF_MOVE Change-Id: I86a5b7049ac8f31ca703add11381f5293233d9d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170863 Tested-by: Jenkins Reviewed-by: Caolán McNamara --- oox/source/drawingml/customshapepresetdata.cxx | 2 +- sc/source/core/data/table6.cxx | 2 +- sc/source/core/tool/interpr1.cxx | 2 +- sc/source/filter/oox/stylesbuffer.cxx | 2 +- sc/source/ui/Accessibility/AccessibleDocument.cxx | 2 +- svgio/source/svgreader/svgstyleattributes.cxx | 2 +- sw/source/core/access/accpara.cxx | 2 +- vcl/source/bitmap/BitmapEx.cxx | 2 +- vcl/source/gdi/print.cxx | 2 +- writerperfect/source/impress/KeynoteImportFilter.cxx | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/oox/source/drawingml/customshapepresetdata.cxx b/oox/source/drawingml/customshapepresetdata.cxx index b03d583a8cdf..c2872cf1adcc 100644 --- a/oox/source/drawingml/customshapepresetdata.cxx +++ b/oox/source/drawingml/customshapepresetdata.cxx @@ -1048,7 +1048,7 @@ void CustomShapeProperties::initializePresetDataMap() } bNotDone = aStream.ReadLine(aLine); } - maPresetDataMap[TokenMap::getTokenFromUnicode(aName)] = aPropertyMap; + maPresetDataMap[TokenMap::getTokenFromUnicode(aName)] = std::move(aPropertyMap); } } diff --git a/sc/source/core/data/table6.cxx b/sc/source/core/data/table6.cxx index 243783c55d2e..e6919485f0f4 100644 --- a/sc/source/core/data/table6.cxx +++ b/sc/source/core/data/table6.cxx @@ -899,7 +899,7 @@ bool ScTable::SearchAndReplaceEmptyCells( aNewRanges.push_back(rRange); } - aRanges = aNewRanges; + aRanges = std::move(aNewRanges); } SvxSearchCmd nCommand = rSearchItem.GetCommand(); diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index 64fc44b382fb..e2f74c19925a 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -484,7 +484,7 @@ void ScInterpreter::ScChooseJump() } } } - xNew = new ScJumpMatrixToken( pJumpMat ); + xNew = new ScJumpMatrixToken(std::move(pJumpMat)); GetTokenMatrixMap().emplace(pCur, xNew); } if (xNew) diff --git a/sc/source/filter/oox/stylesbuffer.cxx b/sc/source/filter/oox/stylesbuffer.cxx index 5f64cf61addb..f19425c9d9dd 100644 --- a/sc/source/filter/oox/stylesbuffer.cxx +++ b/sc/source/filter/oox/stylesbuffer.cxx @@ -1718,7 +1718,7 @@ void GradientFillModel::readGradientStop( SequenceInputStream& rStrm, bool bDxf fPosition = rStrm.readDouble(); } if( !rStrm.isEof() && (fPosition >= 0.0) ) - maColors[ fPosition ] = aColor; + maColors[ fPosition ] = std::move(aColor); } ApiSolidFillData::ApiSolidFillData() : diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx b/sc/source/ui/Accessibility/AccessibleDocument.cxx index 3380d9c7fa41..4ab426a2c36a 100644 --- a/sc/source/ui/Accessibility/AccessibleDocument.cxx +++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx @@ -1162,7 +1162,7 @@ void ScChildrenShapes::SetAnchor(const uno::Reference& xShape, if ((xAddress && pData->xRelationCell && (*xAddress != *(pData->xRelationCell))) || (!xAddress && pData->xRelationCell) || (xAddress && !pData->xRelationCell)) { - pData->xRelationCell = xAddress; + pData->xRelationCell = std::move(xAddress); if (pData->pAccShape.is()) pData->pAccShape->SetRelationSet(GetRelationSet(pData)); } diff --git a/svgio/source/svgreader/svgstyleattributes.cxx b/svgio/source/svgreader/svgstyleattributes.cxx index b5579448492d..95229ddd93bf 100644 --- a/svgio/source/svgreader/svgstyleattributes.cxx +++ b/svgio/source/svgreader/svgstyleattributes.cxx @@ -1450,7 +1450,7 @@ namespace svgio::svgreader } else if(readSvgNumberVector(aContent, aVector)) { - maStrokeDasharray = aVector; + maStrokeDasharray = std::move(aVector); } } break; diff --git a/sw/source/core/access/accpara.cxx b/sw/source/core/access/accpara.cxx index 8ba66ce80a11..d1b9e4932f3a 100644 --- a/sw/source/core/access/accpara.cxx +++ b/sw/source/core/access/accpara.cxx @@ -1583,7 +1583,7 @@ void SwAccessibleParagraph::_getDefaultAttributesImpl( if ( !aRequestedAttributes.hasElements() ) { - rDefAttrSeq = aDefAttrSeq; + rDefAttrSeq = std::move(aDefAttrSeq); } else { diff --git a/vcl/source/bitmap/BitmapEx.cxx b/vcl/source/bitmap/BitmapEx.cxx index 9f4bd7f47b2f..9725ef2ba7c0 100644 --- a/vcl/source/bitmap/BitmapEx.cxx +++ b/vcl/source/bitmap/BitmapEx.cxx @@ -1495,7 +1495,7 @@ void BitmapEx::CombineMaskOr(Color maskColor, sal_uInt8 nTol) AlphaMask aNewMask = maBitmap.CreateAlphaMask( maskColor, nTol ); if ( IsAlpha() ) aNewMask.AlphaCombineOr( maAlphaMask ); - maAlphaMask = aNewMask; + maAlphaMask = std::move(aNewMask); } /** diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx index 907094e33d0d..b9192aa6d854 100644 --- a/vcl/source/gdi/print.cxx +++ b/vcl/source/gdi/print.cxx @@ -1205,7 +1205,7 @@ void Printer::SetPrinterSettingsPreferred( bool bPaperSizeFromSetup) rData.SetPapersizeFromSetup(bPaperSizeFromSetup); mbNewJobSetup = true; - maJobSetup = aJobSetup; + maJobSetup = std::move(aJobSetup); } } diff --git a/writerperfect/source/impress/KeynoteImportFilter.cxx b/writerperfect/source/impress/KeynoteImportFilter.cxx index 6e63cec53482..434c23e61f83 100644 --- a/writerperfect/source/impress/KeynoteImportFilter.cxx +++ b/writerperfect/source/impress/KeynoteImportFilter.cxx @@ -207,7 +207,7 @@ KeynoteImportFilter::detect(css::uno::Sequence& Descr aProp.Value <<= true; aProp.Handle = -1; aProp.State = beans::PropertyState_DIRECT_VALUE; - lComponentDataPV.getArray()[nCDSize] = aProp; + lComponentDataPV.getArray()[nCDSize] = std::move(aProp); pDescriptor[nComponentDataLocation].Value <<= lComponentDataPV; } }