strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replace a suspicious Guard on a solar mutex.

Browse source 
This site use a OClearableGuard that is being converted to a SolarMutexGuard
Guard will do... What is suspicious is the point where it is cleared.
It seems that it is way to early to serve its declared purpose.
This commit is contained in:
Norbert Thiebaud 2010-10-14 22:20:56 -05:00
parent 2622a45740
commit 86c595452b
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
chart2/source/controller/main/ChartController.cxx
View file

@ -532,10 +532,14 @@ void SAL_CALL ChartController::modeChanged( const util::ModeChangeEvent& rEvent
//is called to attach the controller to a new model. //is called to attach the controller to a new model.
//return true if attach was successfully, false otherwise (e.g. if you do not work with a model) //return true if attach was successfully, false otherwise (e.g. if you do not work with a model)
::vos::OClearableGuard aGuard( Application::GetSolarMutex()); {
if( impl_isDisposedOrSuspended() ) //@todo? allow attaching a new model while suspended? // FIXME: ths is suspicious: why just proctect the call to isDisposedOrSuspened
return sal_False; //behave passive if already disposed or suspended // and not all the way until he new model is attached ?
aGuard.clear(); // seems racy to me
SolarMutexGuard aGuard;
if( impl_isDisposedOrSuspended() ) //@todo? allow attaching a new model while suspended?
return sal_False; //behave passive if already disposed or suspended
}
TheModelRef aNewModelRef( new TheModel( xModel), m_aModelMutex); TheModelRef aNewModelRef( new TheModel( xModel), m_aModelMutex);