From 8a20f85dfabdf83a81d229e581c3fcc0fcbdb573 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
Date: Tue, 18 Jan 2011 10:55:43 +0000
Subject: [PATCH] cppcheck: pass by reference

---
 basic/source/app/dialogs.cxx | 6 +++---
 basic/source/app/dialogs.hxx | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/basic/source/app/dialogs.cxx b/basic/source/app/dialogs.cxx
index 5e3802924f4a..ba2a523944aa 100644
--- a/basic/source/app/dialogs.cxx
+++ b/basic/source/app/dialogs.cxx
@@ -817,12 +817,12 @@ void GenericOptions::LoadData()
     LINK( this, GenericOptions, LoadGroup ).Call( NULL );
 }
 
-void GenericOptions::ShowSelectPath( const String aType )
+void GenericOptions::ShowSelectPath( const String &rType )
 {
     Point aNPos = aPbNewValue.GetPosPixel();
     Point aDPos = aPbDelValue.GetPosPixel();
     long nDelta = aDPos.Y() - aNPos.Y();
-    if ( aType.EqualsIgnoreCaseAscii( "PATH" ) && !bShowSelectPath )
+    if ( rType.EqualsIgnoreCaseAscii( "PATH" ) && !bShowSelectPath )
     {   // Show Path button
         nMoveButtons += nDelta;
         aMoveTimer.Start();
@@ -830,7 +830,7 @@ void GenericOptions::ShowSelectPath( const String aType )
         aPbSelectPath.Show( TRUE );
         aPbSelectPath.Enable( TRUE );
     }
-    else if ( !aType.EqualsIgnoreCaseAscii( "PATH" ) && bShowSelectPath )
+    else if ( !rType.EqualsIgnoreCaseAscii( "PATH" ) && bShowSelectPath )
     {   // Hide Path button
         nMoveButtons -= nDelta;
         aMoveTimer.Start();
diff --git a/basic/source/app/dialogs.hxx b/basic/source/app/dialogs.hxx
index 6c547efa8747..743949b64898 100644
--- a/basic/source/app/dialogs.hxx
+++ b/basic/source/app/dialogs.hxx
@@ -273,7 +273,7 @@ class GenericOptions : public TabPage
     StringList* GetAllGroups();
     void LoadData();
 
-    void ShowSelectPath( const String aType );
+    void ShowSelectPath( const String& rType );
 
     DECL_LINK( LoadGroup, ComboBox* );
     DECL_LINK( DelGroup, Button* );