strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

loplugin:moveparam in framework

Browse source 
Change-Id: I423fa6a4f4fea5a27ec69f65dac952eff42d3d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123418
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2021-10-11 16:10:08 +02:00
parent 0eb51b92e0
commit 8a499b4364
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
framework/inc/helper/ocomponentenumeration.hxx
View file

@ -62,7 +62,7 @@ class OComponentEnumeration final : public ::cppu::WeakImplHelper< css::containe
@onerror Do nothing and reset this object to default with an empty list.
*//*-*****************************************************************************************************/
OComponentEnumeration( const std::vector< css::uno::Reference< css::lang::XComponent > >& seqComponents );
OComponentEnumeration( std::vector< css::uno::Reference< css::lang::XComponent > >&& seqComponents );
// XEventListener

2
framework/inc/jobs/jobdata.hxx
View file

@ -186,7 +186,7 @@ class JobData final
void setService ( const OUString& sService );
void setEvent ( const OUString& sEvent ,
const OUString& sAlias );
void setJobConfig ( const std::vector< css::beans::NamedValue >& lArguments );
void setJobConfig ( std::vector< css::beans::NamedValue >&& lArguments );
void disableJob ( );
static std::vector< OUString > getEnabledJobsForEvent( const css::uno::Reference< css::uno::XComponentContext >& rxContext,

2
framework/source/helper/ocomponentaccess.cxx
View file

@ -68,7 +68,7 @@ css::uno::Reference< XEnumeration > SAL_CALL OComponentAccess::createEnumeration
std::vector< css::uno::Reference< XComponent > > seqComponents;
impl_collectAllChildComponents( css::uno::Reference< XFramesSupplier >( xLock, UNO_QUERY ), seqComponents );
xReturn = new OComponentEnumeration( seqComponents );
xReturn = new OComponentEnumeration( std::move(seqComponents) );
}
// Return result of this operation.

4
framework/source/helper/ocomponentenumeration.cxx
View file

@ -32,9 +32,9 @@ using namespace ::osl;
// constructor
OComponentEnumeration::OComponentEnumeration( const std::vector< css::uno::Reference< XComponent > >& seqComponents )
OComponentEnumeration::OComponentEnumeration( std::vector< css::uno::Reference< XComponent > >&& seqComponents )
: m_nPosition ( 0 ) // 0 is the first position for a valid list and the right value for an invalid list to!
, m_seqComponents ( seqComponents )
, m_seqComponents ( std::move(seqComponents) )
{}
// destructor

4
framework/source/jobs/jobdata.cxx
View file

@ -225,12 +225,12 @@ void JobData::setEvent( const OUString& sEvent ,
@param lArguments
list of arguments, which should be set for this job
*/
void JobData::setJobConfig( const std::vector< css::beans::NamedValue >& lArguments )
void JobData::setJobConfig( std::vector< css::beans::NamedValue >&& lArguments )
{
SolarMutexGuard g;
// update member
m_lArguments = lArguments;
m_lArguments = std::move(lArguments);
// update the configuration ... if possible!
if (m_eMode!=E_ALIAS)