From 8a762c35ea517c1ac24d7ca20e190144d5413e71 Mon Sep 17 00:00:00 2001 From: Michael Weghorn Date: Thu, 5 Dec 2024 10:28:17 +0100 Subject: [PATCH] a11y: Update comment wrt reference being (not) weak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was using a weak reference when the comment was added in commit 9b34eb7c8512ebc2a7788692a0c826d4e384d460 Author: Frank Schönheit Date: Thu Apr 25 10:24:33 2002 +0000 #98750# be an XEventListener at the AccessibleContext , but later changed to be a hard reference in commit 23d689d4e43986c10372da0dd756dbcecd82beb8 Author: Thomas Benisch Date: Thu Nov 7 16:19:24 2002 +0000 #103674# change the reference to the accessible context from weak to hard . Unfortunately that commit only references a StarDivision internal ticket, so the exact reason remains unclear, but at least update the comment. Change-Id: Icdc9aec97647ae05ae7fb3f2bdc1be43c3a62619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177848 Tested-by: Jenkins Reviewed-by: Michael Weghorn --- toolkit/source/awt/vclxwindow.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/toolkit/source/awt/vclxwindow.cxx b/toolkit/source/awt/vclxwindow.cxx index 7dff40ed4763..ed9e80e506fe 100644 --- a/toolkit/source/awt/vclxwindow.cxx +++ b/toolkit/source/awt/vclxwindow.cxx @@ -2418,8 +2418,7 @@ css::uno::Reference< css::accessibility::XAccessibleContext > VCLXWindow::getAcc mpImpl->mxAccessibleContext = CreateAccessibleContext(); // add as event listener to this component - // in case somebody disposes it, we do not want to have a (though weak) reference to a dead - // object + // in case somebody disposes it, we do not want to have a reference to a dead object uno::Reference< lang::XComponent > xComp( mpImpl->mxAccessibleContext, uno::UNO_QUERY ); if ( xComp.is() ) xComp->addEventListener( this );