loplugin:passstuffbyref in avmedia..canvas

Change-Id: I916a6431eb0720af16dcb5aa46b758f92dbe4ec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176179
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2024-11-07 08:16:35 +02:00
parent e5570ce8e9
commit 91106b5b61
6 changed files with 7 additions and 7 deletions

View file

@ -285,7 +285,7 @@ bool MediaItem::setMimeType(const OUString& rMimeType)
return bChanged;
}
OUString MediaItem::getMimeType() const
const OUString & MediaItem::getMimeType() const
{
return !m_pImpl->m_sMimeType.isEmpty() ? m_pImpl->m_sMimeType : AVMEDIA_MIMETYPE_COMMON;
}

View file

@ -402,7 +402,7 @@ public:
virtual bool HasActiveEditor () const override;
void UpdateModule ();
OUString GetEditorColorScheme() { return m_sWinColorScheme; }
const OUString & GetEditorColorScheme() { return m_sWinColorScheme; }
void SetEditorColorScheme(const OUString& rColorScheme);
};
@ -428,7 +428,7 @@ public:
Color const & GetSyntaxBackgroundColor () const { return aSyntaxColors.GetBackgroundColor(); }
Color const & GetFontColor () const { return aSyntaxColors.GetFontColor(); }
Color const & GetSyntaxColor (TokenType eType) const { return aSyntaxColors.GetColor(eType); }
OUString GetActiveColorSchemeId() { return m_sColorSchemeId; }
const OUString & GetActiveColorSchemeId() { return m_sColorSchemeId; }
void ApplyColorSchemeToCurrentWindow(const OUString& rSchemeId);
protected:

View file

@ -73,7 +73,7 @@ public:
virtual void Notify(const css::uno::Sequence<OUString>& aPropertyNames) override;
ColorScheme GetColorScheme(const OUString& rScheme);
css::uno::Sequence<OUString> GetColorSchemeNames() { return m_aSchemeNames; }
const css::uno::Sequence<OUString>& GetColorSchemeNames() { return m_aSchemeNames; }
// Returns the color scheme defined by the current Application Colors
ColorScheme GetAutomaticColorScheme();

View file

@ -105,7 +105,7 @@ namespace canvas
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames( ) override;
/// Query all defining values of this object atomically
Values getValues() const;
const Values & getValues() const;
private:
virtual ~ParametricPolyPolygon() override; // we're a ref-counted UNO class. _We_ destroy ourselves.

View file

@ -226,7 +226,7 @@ namespace canvas
{
}
ParametricPolyPolygon::Values ParametricPolyPolygon::getValues() const
const ParametricPolyPolygon::Values & ParametricPolyPolygon::getValues() const
{
return maValues;
}

View file

@ -121,7 +121,7 @@ public:
const OUString& getFallbackURL() const;
bool setMimeType(const OUString& rMimeType);
OUString getMimeType() const;
const OUString& getMimeType() const;
bool setGraphic(const Graphic& rGraphic);
const Graphic & getGraphic() const;
bool setCrop(const css::text::GraphicCrop& rCrop);