From 9463ee0a105e13f1f5f6c71fac3549abe5aa79d0 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 12 Sep 2019 20:15:53 +0200 Subject: [PATCH] sd edit diagram: dispose the diagram dialog after we don't need it Fixes: soffice.bin: /home/vmiklos/git/libreoffice/master/include/vcl/vclptr.hxx:110: VclPtr::~VclPtr() [with reference_type = VclAbstractDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. Change-Id: I4ac6a2e874f816f29ab593e3cbc87f3ddebb8109 Reviewed-on: https://gerrit.libreoffice.org/78840 Reviewed-by: Miklos Vajna Tested-by: Jenkins --- sd/source/ui/view/drviews3.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sd/source/ui/view/drviews3.cxx b/sd/source/ui/view/drviews3.cxx index 5664219e83ca..c5e1450f70e2 100644 --- a/sd/source/ui/view/drviews3.cxx +++ b/sd/source/ui/view/drviews3.cxx @@ -510,7 +510,7 @@ void DrawViewShell::ExecCtrl(SfxRequest& rReq) if (oox::drawingml::DrawingML::IsDiagram(xShape)) { VclAbstractDialogFactory* pFact = VclAbstractDialogFactory::Create(); - VclPtr pDlg + ScopedVclPtr pDlg = pFact->CreateDiagramDialog(GetFrameWeld(), pObj->GetDiagramData()); pDlg->Execute(); }