From 9ece0ae7e1b07d61274c975cbc1cd55966a89013 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 18 Feb 2021 15:40:53 +0100 Subject: [PATCH] loplugin:referencecasting (macOS) Change-Id: I99470067a34fab9fbc2ea53d2f8a634240f0d223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111127 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- avmedia/source/macavf/manager.mm | 2 +- avmedia/source/macavf/player.mm | 2 +- connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx | 2 +- connectivity/source/drivers/macab/MacabPreparedStatement.cxx | 2 +- connectivity/source/drivers/macab/MacabResultSet.cxx | 4 ++-- vcl/osx/a11yfactory.mm | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/avmedia/source/macavf/manager.mm b/avmedia/source/macavf/manager.mm index 44768b54c4e3..d240bb27a8d1 100644 --- a/avmedia/source/macavf/manager.mm +++ b/avmedia/source/macavf/manager.mm @@ -44,7 +44,7 @@ uno::Reference< media::XPlayer > SAL_CALL Manager::createPlayer( const OUString& if( !xPlayer->create( aURL.GetMainURL( INetURLObject::DecodeMechanism::Unambiguous ) ) ) return {}; - return uno::Reference(xPlayer.get()); + return uno::Reference(xPlayer); } diff --git a/avmedia/source/macavf/player.mm b/avmedia/source/macavf/player.mm index 7fdc58247f50..401cba74c2d2 100644 --- a/avmedia/source/macavf/player.mm +++ b/avmedia/source/macavf/player.mm @@ -333,7 +333,7 @@ uno::Reference< media::XFrameGrabber > SAL_CALL Player::createFrameGrabber() if( !pGrabber->create( pMovie ) ) return {}; - return pGrabber.get(); + return pGrabber; } diff --git a/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx b/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx index 540e333aa639..9b3aed095039 100644 --- a/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx +++ b/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx @@ -729,7 +729,7 @@ sal_Bool SAL_CALL MacabDatabaseMetaData::supportsBatchUpdates( ) Reference< XConnection > SAL_CALL MacabDatabaseMetaData::getConnection( ) { - return m_xConnection.get(); + return m_xConnection; } Reference< XResultSet > SAL_CALL MacabDatabaseMetaData::getTableTypes( ) diff --git a/connectivity/source/drivers/macab/MacabPreparedStatement.cxx b/connectivity/source/drivers/macab/MacabPreparedStatement.cxx index cbb3dc75608c..22fd7b499a82 100644 --- a/connectivity/source/drivers/macab/MacabPreparedStatement.cxx +++ b/connectivity/source/drivers/macab/MacabPreparedStatement.cxx @@ -131,7 +131,7 @@ Reference< XResultSetMetaData > SAL_CALL MacabPreparedStatement::getMetaData() m_xMetaData = new MacabResultSetMetaData(getOwnConnection(),sTableName); setMacabFields(); } - Reference< XResultSetMetaData > xMetaData = m_xMetaData.get(); + Reference< XResultSetMetaData > xMetaData = m_xMetaData; return xMetaData; } diff --git a/connectivity/source/drivers/macab/MacabResultSet.cxx b/connectivity/source/drivers/macab/MacabResultSet.cxx index da2d2dafd3ed..b35f6e2d57ca 100644 --- a/connectivity/source/drivers/macab/MacabResultSet.cxx +++ b/connectivity/source/drivers/macab/MacabResultSet.cxx @@ -513,7 +513,7 @@ Reference< XResultSetMetaData > SAL_CALL MacabResultSet::getMetaData() if (!m_xMetaData.is()) m_xMetaData = new MacabResultSetMetaData(m_xStatement->getOwnConnection(), m_sTableName); - Reference< XResultSetMetaData > xMetaData = m_xMetaData.get(); + Reference< XResultSetMetaData > xMetaData = m_xMetaData; return xMetaData; } @@ -668,7 +668,7 @@ Reference< XInterface > SAL_CALL MacabResultSet::getStatement() ::osl::MutexGuard aGuard( m_aMutex ); checkDisposed(MacabResultSet_BASE::rBHelper.bDisposed); - Reference< XStatement > xStatement = m_xStatement.get(); + Reference< XStatement > xStatement = m_xStatement; return xStatement; } diff --git a/vcl/osx/a11yfactory.mm b/vcl/osx/a11yfactory.mm index 0a17f15dad8d..797a7492d391 100644 --- a/vcl/osx/a11yfactory.mm +++ b/vcl/osx/a11yfactory.mm @@ -59,7 +59,7 @@ static bool enabled = false; mdAllWrapper = [ [ [ NSMutableDictionary alloc ] init ] retain ]; // initialize keyboard focus tracker rtl::Reference< AquaA11yFocusListener > listener( AquaA11yFocusListener::get() ); - TheAquaA11yFocusTracker::get().setFocusListener(listener.get()); + TheAquaA11yFocusTracker::get().setFocusListener(listener); enabled = true; } return mdAllWrapper;