strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#137726 hide pivot table dlg so its not a candidate as error dlg parent

Browse source 
because this pivot table dialog is going to disappear on response and the error
dialog is not run in its own event loop but instead async so will end up as a
parent of a dialog that doesn't exist

Change-Id: I78302428a246612e3107d2907ffffb97a2d25ea2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104895
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara 2020-10-27 15:59:56 +00:00
parent 71f6e3862a
commit 9f2daed124
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sc/source/ui/dbgui/PivotLayoutDialog.cxx
View file

@ -628,6 +628,12 @@ void ScPivotLayoutDialog::Close()
IMPL_LINK_NOARG( ScPivotLayoutDialog, OKClicked, weld::Button&, void )
{
/* tdf#137726 hide so its not a candidate to be parent of any error
messages that may appear because this dialog is going to disappear on
response(RET_OK) and the error dialog is not run in its own event loop
but instead async */
m_xDialog->hide();
ApplyChanges();
m_xDialog->response(RET_OK);
}