From 9fb45044d93ffcaa63cfe3275c8fb5feb8c00504 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Tue, 21 Dec 2021 14:47:53 +0100 Subject: [PATCH] xmlsecurity nss: log what XML DOM node is given to libxmlsec We have two environments where the signature and the stream bytes are the same, still in one case the signature verification succeeds and in the other case the hash doesn't match. Log the signature as parsed into a DOM node (recursively), just case something goes wrong during extracting a single signature from the signatures list XML. Change-Id: I54af71fdeb63d8ef44342f106746f938fa51f29a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127991 Reviewed-by: Miklos Vajna Tested-by: Jenkins --- xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx b/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx index e637785fe613..9257771f2767 100644 --- a/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx +++ b/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx @@ -243,6 +243,13 @@ SAL_CALL XMLSignature_NssImpl::validate( if (xmlSecPtrListAdd(&(pDsigCtx->keyInfoReadCtx.enabledKeyData), BAD_CAST xmlSecNssKeyDataX509GetKlass()) < 0) throw RuntimeException("failed to limit allowed key data"); + xmlBufferPtr pBuf = xmlBufferCreate(); + xmlNodeDump(pBuf, nullptr, pNode, 0, 0); + SAL_INFO("xmlsecurity.xmlsec", "xmlSecDSigCtxVerify input XML node is '" + << reinterpret_cast(xmlBufferContent(pBuf)) + << "'"); + xmlBufferFree(pBuf); + //Verify signature int rs = xmlSecDSigCtxVerify( pDsigCtx.get() , pNode );