strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better fix for fdo#56473, Crash when inserting a simple macro

Browse source 
old code used to use XCell->setString, new code uses rDoc.SetString which by default tries to detect number formats. The ScColumn::SetString that eventually
gets called seems to do lots of additional checks ( and apparently even if
an ScSetStringParam instance with mbDetectNumberFormat ( false ) was passed
it seems that it will still try to detect decimal number formats. With that
in mind I restore and un-unoified version of what XCell->setString used do

Change-Id: Ifaef74c78b198f492a390a3d5dc1721622a01ea4
This commit is contained in:
Michael Meeks 2012-11-09 16:58:00 +00:00 committed by Julien Nabet
parent 7cf93f92cc
commit a73c98a708
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
accessibility/source/extended/textwindowaccessibility.cxx
View file

@ -17,7 +17,6 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <accessibility/extended/textwindowaccessibility.hxx>
#include "comphelper/accessibleeventnotifier.hxx"
#include "unotools/accessiblerelationsethelper.hxx"
@ -2124,18 +2123,19 @@ void Document::handleSelectionChangeNotification()
void Document::notifySelectionChange( sal_Int32 nFirst, sal_Int32 nLast )
{
if ( nFirst < nLast )
nFirst = std::max( nFirst, sal_Int32( 0 ) );
nLast = std::min( nLast, sal_Int32( m_xParagraphs->size() ) );
Paragraphs::iterator iFirst(m_xParagraphs->begin() + nFirst);
Paragraphs::iterator iLast(m_xParagraphs->begin() + nLast);
if ( iFirst < m_aVisibleBegin )
iFirst = m_aVisibleBegin;
if ( iLast > m_aVisibleEnd )
iLast = m_aVisibleEnd;
if ( iFirst < iLast )
{
Paragraphs::iterator aItBound1 = m_xParagraphs->begin();
for (sal_Int32 i = 0; i < nLast && aItBound1 != m_xParagraphs->end() ; ++aItBound1, ++i);
Paragraphs::iterator aEnd( ::std::min( aItBound1, m_aVisibleEnd ) );
Paragraphs::iterator aItBound2 = m_xParagraphs->begin();
for (sal_Int32 i = 0; i < nFirst && aItBound2 != m_xParagraphs->end() ; ++aItBound2, ++i);
for ( Paragraphs::iterator aIt = ::std::max( aItBound2, m_aVisibleBegin ); aIt != aEnd; ++aIt )
for ( Paragraphs::iterator i = iFirst; i != iLast; i++ )
{
::rtl::Reference< ParagraphImpl > xParagraph( getParagraph( aIt ) );
::rtl::Reference< ParagraphImpl > xParagraph( getParagraph( i ) );
if ( xParagraph.is() )
{
xParagraph->notifyEvent(